Elisa icon has changed, update it
add the new release branch in the branch list and switch it as default
Details
Details
- Reviewers
vonreth - Group Reviewers
Windows - Commits
- R877:4af54d366ae8: update Elisa icons and add new release branch and set it as default
none
Diff Detail
Diff Detail
- Repository
- R877 Craft Blueprints for KDE
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| extragear/elisa/elisa.py | ||
|---|---|---|
| 9 | Looks good but the default target should not point to a branch. Please rather change the nightly build target in binaryfactory | |
| extragear/elisa/elisa.py | ||
|---|---|---|
| 9 | Any reason you need to set the default target to an unstable version? | |
Comment Actions
- switch default to the latest stable tag (0.4.2 version) for elisa
Sorry for not understanding what you meant. I have fixed the default target to the latest stable tag.
| extragear/elisa/elisa.py | ||
|---|---|---|
| 9 | I have now done exactly what you suggested. Thanks for your invaluable help once more. | |
| extragear/elisa/elisa.py | ||
|---|---|---|
| 9 | Great, I just realised that the versions.ini is basically not used as all targets are defined here. self.versionInfo.setDefaultValues() Or go all for the versions.ini but I think the current setup is confusing. | |
Comment Actions
- switch default to the latest stable tag (0.4.2 version) for elisa
- remove all versions specified in elisa.py, only use version.ini