jguidon (Jerome Guidon)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 14 2019, 3:32 PM (35 w, 1 d)
Availability
Available

Recent Activity

Fri, Oct 11

jguidon added reviewers for D24563: Standardize the database upgrade mechanism: Elisa, mgallien, ngraham, astippich.
Fri, Oct 11, 4:24 PM
jguidon updated the diff for D24563: Standardize the database upgrade mechanism.

Fix qcDebug messages

Fri, Oct 11, 4:22 PM
jguidon requested review of D24563: Standardize the database upgrade mechanism.
Fri, Oct 11, 4:20 PM

Sun, Sep 29

jguidon added inline comments to D23859: Radios: add support for images.
Sun, Sep 29, 5:02 PM
jguidon updated the diff for D23859: Radios: add support for images.
  • Fixed wrong modification in databaseV14
Sun, Sep 29, 4:58 PM
jguidon updated the diff for D23859: Radios: add support for images.
  • Set a database upgrade
  • Rebase on master
Sun, Sep 29, 4:55 PM

Sep 18 2019

jguidon added a comment to D21525: Add support for radio streams.

ok thanks :)

Sep 18 2019, 8:32 AM
jguidon added a comment to D21525: Add support for radio streams.

Thank you for the information.

Sep 18 2019, 7:41 AM

Sep 14 2019

jguidon updated the summary of D23859: Radios: add support for images.
Sep 14 2019, 9:35 AM
jguidon added a comment to D23859: Radios: add support for images.

Some screenshots:

Sep 14 2019, 9:35 AM
jguidon updated the diff for D23859: Radios: add support for images.

Make MediaTrackMetadataView open with width as argument. It opens with larger width for radios where http links can be long.

Sep 14 2019, 9:33 AM

Sep 10 2019

jguidon updated the diff for D23859: Radios: add support for images.
  • Fixed typo
Sep 10 2019, 10:10 PM
jguidon updated subscribers of D23859: Radios: add support for images.
Sep 10 2019, 10:06 PM
jguidon added reviewers for D23859: Radios: add support for images: Elisa, mgallien, ngraham, astippich.
Sep 10 2019, 10:04 PM
jguidon requested review of D23859: Radios: add support for images.
Sep 10 2019, 10:03 PM

Sep 9 2019

jguidon added a comment to D23280: fix issues related to radio and view details in playlist.

Should be good to land now.
Let me know.

Sep 9 2019, 8:17 PM

Sep 8 2019

jguidon added a comment to D23280: fix issues related to radio and view details in playlist.

This issue is fixed but deletion of a newly created radio is not working.

Sep 8 2019, 1:51 PM

Aug 22 2019

jguidon added a comment to D23280: fix issues related to radio and view details in playlist.

I may have two wrong test cases and some minor comments about the code :)

Aug 22 2019, 3:43 PM

Aug 20 2019

jguidon added a comment to D23280: fix issues related to radio and view details in playlist.

I just have two questions about the behavior:

Aug 20 2019, 6:54 PM
jguidon added a comment to D21525: Add support for radio streams.

@jguidon Do you intend to continue to contribute to Elisa ?

Aug 20 2019, 8:21 AM

Aug 19 2019

jguidon added a comment to D21525: Add support for radio streams.

Should I land this patch for you or you have already a KDE developer account ?

Aug 19 2019, 12:59 PM

Aug 14 2019

jguidon added a comment to D21525: Add support for radio streams.

I believe that the best approach would be to allow easy access to a list of user contributed radios (i.e. maybe via store.kde.org ). When testing, I have added one radio I often listen to and that was easy to do. We could easily delay that to a second stage. What do you think ?

Aug 14 2019, 3:03 PM

Aug 13 2019

jguidon added inline comments to D21525: Add support for radio streams.
Aug 13 2019, 4:18 PM
jguidon updated the diff for D21525: Add support for radio streams.
  • Fixed remaining if code style
  • Rebase on master
Aug 13 2019, 4:04 PM

Aug 11 2019

jguidon updated the diff for D21525: Add support for radio streams.
  • Fixed code style, warnings in databaseinterface
  • Change names of signals/slots
  • datamodel.cpp: Integrate trackIndexFromId and radioIndexFromId
  • Split MetaDataDelegate.qml into EditableMetaDataDelegate.qml for editable fields
  • ListBrowserDelegate: fix check on track number
  • databaseinterface.h: rename updateRadioInDatabase to insertRadio. The method handles insert and update.
  • databaseinterface: remove unrelated change
  • MediaTrackMetadataView: rename radio bool property to isRadio
  • datamodel: add one more type
  • Missed qml declaration of ListRadioDataType
  • DataModel::data: make a better check in case of radio data type
  • DataModel::data: remove case for DurationRole/Radio.
  • Added support for persistent state
  • ViewManager::openListView fix wrong bool parameter
Aug 11 2019, 8:29 PM

Jul 29 2019

jguidon added a comment to D21525: Add support for radio streams.

Thank you a lot for your advice.

Jul 29 2019, 10:03 PM

Jul 28 2019

jguidon added inline comments to D21525: Add support for radio streams.
Jul 28 2019, 12:12 PM
jguidon updated the diff for D21525: Add support for radio streams.

Removed unecessary radioModified signal from ModelDataLoader

Jul 28 2019, 12:02 PM
jguidon updated the diff for D21525: Add support for radio streams.
  • DatabaseInterface::updateRadioInDatabase: better fields settings for radios on creation
  • rebase on master
Jul 28 2019, 11:24 AM

Jul 27 2019

jguidon added a comment to D21525: Add support for radio streams.

Thank you for your feedback, I still have one warning opening the detail view for a radio: "QFSFileEngine::open: No file name specified". I am working on it.

Jul 27 2019, 11:58 PM
jguidon updated the diff for D21525: Add support for radio streams.
  • Fix display bug for the track mainLabel (-1 was displayed)
  • Removed MediaRadioMetadataView and integrate it to MediaTrackMetadataView
  • TrackMetadataModel: better integration
  • Fix View Detail window not opening in single album view.
  • ContentView: remove unecessary component for radios
  • Removed unecessary lines and variables in qml
  • DataListView: radio bool property is set from viewmanager
  • Fixed warnings in DataListView by adding cases in datamodel
Jul 27 2019, 11:44 PM

Jul 22 2019

jguidon updated the diff for D21525: Add support for radio streams.
  • Rebase on master
    • NavigationActionBar: create radios button integration
    • Make calls to MediaRadioMetadataView and MediaTrackMetadataView work
    • Remove MediaRadioDelegate
    • Removed RadioMetaDataModel
    • Use resource role instead of http address role
    • Removed RadiosView.qml
    • Removed httpAddress Role from the UI
    • Rebase, Reintegrate Create a radio button in NavigationActionBar.qml
Jul 22 2019, 9:34 PM

Jul 12 2019

jguidon added a comment to D21525: Add support for radio streams.

Thank you very much for your feedback, I will work on this revision this weekend.

Jul 12 2019, 7:19 AM

Jun 25 2019

jguidon updated the diff for D21525: Add support for radio streams.

Added delete feature for a radio, delete button is in the editing window

Jun 25 2019, 3:56 PM

Jun 23 2019

jguidon updated the diff for D21525: Add support for radio streams.

Fixed copyright

Jun 23 2019, 8:46 PM
jguidon updated the diff for D21525: Add support for radio streams.

Create and edit a radio, first version

Jun 23 2019, 8:37 PM

Jun 16 2019

jguidon added a comment to D21525: Add support for radio streams.

Thanks, I am a bit struggling with my current workload. I will try to provide feedback as soon as I can.

Jun 16 2019, 12:30 PM

Jun 5 2019

jguidon updated the diff for D21525: Add support for radio streams.

Fixes:

  • rebase on current master branch
  • fixed swich-cases not taking in account radio
  • removed some comments and cleaned some code
  • enqueue and replace button for all the radios in the view does not appears for the Radios view (suggestion from the vdg discussion, as a stream never ends, so adding several radios into the playlist does not make sense).
Jun 5 2019, 8:29 PM

Jun 4 2019

jguidon added a comment to D21525: Add support for radio streams.

Thanks, for now I just kept the thing working and I did not care about these warnings, I will take it in account and do the rebase also.

Jun 4 2019, 3:20 PM

Jun 3 2019

jguidon added a comment to D21525: Add support for radio streams.

It's blue because it's a mimetype icon and those tend to be colored. It could be copied and made into a monochrome device icon for you.

Jun 3 2019, 9:07 PM

Jun 1 2019

jguidon added a comment to D21525: Add support for radio streams.

I created a first version for the radio stream support with a view for the Radios based on the Tracks view.

Jun 1 2019, 6:08 PM
jguidon added a revision to T7567: Add support for radio streams: D21525: Add support for radio streams.
Jun 1 2019, 5:51 PM · Elisa
jguidon requested review of D21525: Add support for radio streams.
Jun 1 2019, 5:51 PM

Apr 30 2019

jguidon added a comment to T7567: Add support for radio streams.

Just to keep you updated about my progress, I could read a radio stream within Elisa. I also could get some information from the stream like the current played song and update the information in the interface (in the headerbar and the playlist).

Apr 30 2019, 6:45 PM · Elisa

Apr 16 2019

jguidon moved T5376: Allow to undo the clear actions on the playlist from In Progress to Done on the Elisa board.
Apr 16 2019, 3:22 PM · Elisa

Apr 15 2019

jguidon added a watcher for VDG: jguidon.
Apr 15 2019, 9:02 AM

Apr 12 2019

jguidon added a comment to T7567: Add support for radio streams.

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

Apr 12 2019, 9:16 AM · Elisa
jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.

Apr 12 2019, 8:59 AM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.
  • Fixed some typo and removed empty lines
Apr 12 2019, 8:27 AM · Elisa

Mar 26 2019

jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Thanks a lot for your feedback

Mar 26 2019, 11:18 AM · Elisa

Mar 14 2019

jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Fixed use of the closeButton of Kirigami.InlineMessage with Connections in qml. I asked to Marco Martin and I thank him for his help.

Mar 14 2019, 11:23 AM · Elisa

Mar 12 2019

jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Thank you for your feedback !

Mar 12 2019, 9:27 PM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.
  • For Inline Message, use of Kirigami.Action's button instead of InlineMessage closeButton
Mar 12 2019, 9:22 PM · Elisa

Mar 9 2019

jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Here is one screenshot with the inline message :

Mar 9 2019, 10:39 AM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Use Kirigami InlineMessage instead of the system notification

Mar 9 2019, 10:35 AM · Elisa

Mar 8 2019

jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Thanks, I can take a look at the Kirigami InlineMessage.

Mar 8 2019, 5:32 PM · Elisa
jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Thank you for your replies, I could push a diff: https://phabricator.kde.org/D19610 . I tried to follow the instructions as much as possible :)

Mar 8 2019, 2:22 PM · Elisa
jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

you can see three screenshots:

Mar 8 2019, 2:14 PM · Elisa
jguidon requested review of D19610: Allow to undo the clear actions on the playlist.
Mar 8 2019, 2:09 PM · Elisa
jguidon added a revision to T5376: Allow to undo the clear actions on the playlist: D19610: Allow to undo the clear actions on the playlist.
Mar 8 2019, 2:09 PM · Elisa

Feb 27 2019

jguidon moved T5376: Allow to undo the clear actions on the playlist from Backlog to In Progress on the Elisa board.
Feb 27 2019, 3:39 PM · Elisa

Feb 26 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Finally, I could use KNotification to generate on the clear action a system notification with an undo choice (the file elisa.notifyrc may be particular for the packaging, KNotificationGlobalConfigFile).

Feb 26 2019, 7:00 PM · Elisa

Feb 22 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Thank you, I have indeed a few questions after a first look at the code :

Feb 22 2019, 11:21 PM · Elisa

Feb 20 2019

jguidon claimed T5376: Allow to undo the clear actions on the playlist.
Feb 20 2019, 9:20 PM · Elisa

Feb 18 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

I am new here and I am very motivated to invest !

Feb 18 2019, 4:26 PM · Elisa

Feb 15 2019

jguidon added a watcher for Elisa: jguidon.
Feb 15 2019, 2:18 PM
jguidon removed a member for Elisa: jguidon.
Feb 15 2019, 2:18 PM
jguidon added a member for Elisa: jguidon.
Feb 15 2019, 2:18 PM