Yes, I also think it is a great idea!

Thanks @jguidon !
Well done !

Rebase on master

• remove unused includes

Remove synchronous checking in the model, use qml image statusChanged to handle errors.

Thanks :)

Image Url field was not present on creation mode

Rebase: fix some not wanted changes

Rebase on master

• Url validation in models, before the data is sent to the view.

Fixed code style

rebase on master

Fix tests on DatabaseVersion table request

Thanks a lot for your feedback.

• Remove useless affectation in error handling

Fix binding loop qml message and add file:// to a local uri, if it is not an url.

Thanks for your feedback,

Fix qcDebug messages

• Fixed wrong modification in databaseV14

• Set a database upgrade
• Rebase on master

ok thanks :)

Thank you for the information.

Some screenshots:

Make MediaTrackMetadataView open with width as argument. It opens with larger width for radios where http links can be long.

• Fixed typo

Should be good to land now.
Let me know.

This issue is fixed but deletion of a newly created radio is not working.

I may have two wrong test cases and some minor comments about the code :)

I just have two questions about the behavior:

@jguidon Do you intend to continue to contribute to Elisa ?

Should I land this patch for you or you have already a KDE developer account ?

I believe that the best approach would be to allow easy access to a list of user contributed radios (i.e. maybe via store.kde.org ). When testing, I have added one radio I often listen to and that was easy to do. We could easily delay that to a second stage. What do you think ?

• Fixed remaining if code style
• Rebase on master

• Fixed code style, warnings in databaseinterface
• Change names of signals/slots
• datamodel.cpp: Integrate trackIndexFromId and radioIndexFromId
• Split MetaDataDelegate.qml into EditableMetaDataDelegate.qml for editable fields
• ListBrowserDelegate: fix check on track number
• databaseinterface.h: rename updateRadioInDatabase to insertRadio. The method handles insert and update.
• databaseinterface: remove unrelated change
• MediaTrackMetadataView: rename radio bool property to isRadio
• datamodel: add one more type
• Missed qml declaration of ListRadioDataType
• DataModel::data: make a better check in case of radio data type
• DataModel::data: remove case for DurationRole/Radio.
• Added support for persistent state
• ViewManager::openListView fix wrong bool parameter

Thank you a lot for your advice.

Removed unecessary radioModified signal from ModelDataLoader

• DatabaseInterface::updateRadioInDatabase: better fields settings for radios on creation
• rebase on master

Thank you for your feedback, I still have one warning opening the detail view for a radio: "QFSFileEngine::open: No file name specified". I am working on it.

• Fix display bug for the track mainLabel (-1 was displayed)
• Removed MediaRadioMetadataView and integrate it to MediaTrackMetadataView
• TrackMetadataModel: better integration
• Fix View Detail window not opening in single album view.
• ContentView: remove unecessary component for radios
• Removed unecessary lines and variables in qml
• DataListView: radio bool property is set from viewmanager
• Fixed warnings in DataListView by adding cases in datamodel

• Rebase on master
  • NavigationActionBar: create radios button integration
  • Make calls to MediaRadioMetadataView and MediaTrackMetadataView work
  • Remove MediaRadioDelegate
  • Removed RadioMetaDataModel
  • Use resource role instead of http address role
  • Removed RadiosView.qml
  • Removed httpAddress Role from the UI
  • Rebase, Reintegrate Create a radio button in NavigationActionBar.qml

Thank you very much for your feedback, I will work on this revision this weekend.

Added delete feature for a radio, delete button is in the editing window

Fixed copyright

Create and edit a radio, first version

Thanks, I am a bit struggling with my current workload. I will try to provide feedback as soon as I can.

Fixes:

• rebase on current master branch
• fixed swich-cases not taking in account radio
• removed some comments and cleaned some code
• enqueue and replace button for all the radios in the view does not appears for the Radios view (suggestion from the vdg discussion, as a stream never ends, so adding several radios into the playlist does not make sense).

Thanks, for now I just kept the thing working and I did not care about these warnings, I will take it in account and do the rebase also.

It's blue because it's a mimetype icon and those tend to be colored. It could be copied and made into a monochrome device icon for you.

I created a first version for the radio stream support with a view for the Radios based on the Tracks view.

Just to keep you updated about my progress, I could read a radio stream within Elisa. I also could get some information from the stream like the current played song and update the information in the interface (in the headerbar and the playlist).

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.

• Fixed some typo and removed empty lines

Thanks a lot for your feedback

Fixed use of the closeButton of Kirigami.InlineMessage with Connections in qml. I asked to Marco Martin and I thank him for his help.

Thank you for your feedback !

• For Inline Message, use of Kirigami.Action's button instead of InlineMessage closeButton

Here is one screenshot with the inline message :

Use Kirigami InlineMessage instead of the system notification

Thanks, I can take a look at the Kirigami InlineMessage.

Thank you for your replies, I could push a diff: https://phabricator.kde.org/D19610 . I tried to follow the instructions as much as possible :)

you can see three screenshots:

Finally, I could use KNotification to generate on the clear action a system notification with an undo choice (the file elisa.notifyrc may be particular for the packaging, KNotificationGlobalConfigFile).

Thank you, I have indeed a few questions after a first look at the code :

I am new here and I am very motivated to invest !