Differential D25894

properly detect local branches with slash (like release/19.12)
ClosedPublic
Actions

Authored by mgallien on Dec 11 2019, 4:33 PM.

Details

Reviewers
vonreth
Group Reviewers
Windows
Craft
Commits
R138:59357991cc60: properly detect local branches with slash (like release/19.12)
Summary

should fix multiple builds from git with a branch with a slash into its
name by avoiding calling git checkout --track multiple times

Test Plan

fix local build of elisa with release/19.12

see binary-factory failures

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Dec 11 2019, 4:33 PM
mgallien created this revision.
vonreth accepted this revision.Dec 21 2019, 8:23 PM
This revision is now accepted and ready to land.Dec 21 2019, 8:23 PM
mgallien added a comment.Dec 22 2019, 5:21 PM

Thanks for the review but somebody already fixed that bug. Do I still land this patch ?

mgallien updated this revision to Diff 72003.Dec 22 2019, 5:22 PM

rebased patch

Closed by commit R138:59357991cc60: properly detect local branches with slash (like release/19.12) (authored by mgallien, committed by cullmann). · Explain WhyJan 22 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mbin/Source/GitSource.py (2 lines)

Diff 74168

View Options

bin/Source/GitSource.py

Loading...