In D21138#465232, @afarid wrote:

Hi,

Will add @alcinos and @mardelle to review this. For future reference, please note that we have moved to gitlab: invent.kde.org for Kdenlive's development.

Cheers

PS
Send us your address so we can send you a nifty Kdenlive sticker. :D

Will add @alcinos and @mardelle to review this. For future reference, please note that we have moved to gitlab: invent.kde.org for Kdenlive's development.

I agree with everything that @m712 said except for the animation part, the animation features in the titler tool are extremely useful for making things like rolling credits.

I've been using this tool heavily for a couple of days so here are my suggestions.

Fix indentation

In T10747#181105, @emohr wrote:

Note for inkscape: QtSvg only supports TinySvg specification, so inkscape svg must be exported to this format to display properly in Kdenlive (note to add somewhere...)

How about adding some presets for text animations (Click on image to see GIF)?

Well all the edge cases you listed need to be correctly handled and tested, and that is a significant effort.
You sure forgot some of them:

What edge cases are you thinking of? Are there things I didn't think of in my feature suggestion??

I don't know whether I have commit access, but I don't think so. Could you please push it? Thanks!

This was committed some time ago

Thanks for this contribution. Do you have commit access or should I push it myself on your behalf

It seems to me that the list of edge cases out-weights the potential usefulness of such a feature, so I would consider that very low-priority at the moment.
Note that you can just group both clips together to make them move in a coordinated way. Note that for now there are no group effects, so effects would still need to be applied to both halves of the clip.

Note for inkscape: QtSvg only supports TinySvg specification, so inkscape svg must be exported to this format to display properly in Kdenlive (note to add somewhere...)

In the commit, the name of color selection was changed to "chroma-key", instead of "chroma key : advanced". This is a mistake. If you download the newest kdenlive build, this mistake appears.

Remove typo at start of patch

Hello,
Thanks for the contribution, I've integrated it in Applications/19.04 (commit d71922756f58c4c5d86b409703adf61a2bdbdb39)

Yes this is the fix to the bug request. I added "FEATURE: 406077" in the summary. I did make that bug request, and i realised the fix was quite easy so I did it myself. The "git diff" part was a bit complicated tho

I think this is the same request: https://bugs.kde.org/show_bug.cgi?id=406077. correct?

• Handle and modify SVG files (vector graphics) in the titler. That would open a way for some kind of animation (maybe as an new feature for the future in Kdenlive). Some input here: https://bugs.kde.org/show_bug.cgi?id=405249

Changing the color theme changes the color of the audio and video clip as well.

Applied, thanks

I think that editing modifying the MLT is unnecesary as the MLT already have all the functionality to process text, only need something to put together those elements. Like generating a Video Track, parsing the SRT/ASS file and just generating a text clip per parsed item and putting it on the timeline using the timestamps of the file.

Folks, thanks for the effort. FYI, we have merged the refactoring branch to master so 19.04 will be completely new. So focus should be on the refactoring (which is now master.)

Audio capture has been implemented.

Rewrite the render dialog.

Should I be concerned with the refactoring version at the time being, or just 18.12.1?

In T10511#177805, @ianbacanov wrote:

Where is speed control? how to make speed ramp now? on Motion efect I have freeze only

In T9832#177824, @thompsony wrote:

@yurchor

Think I could contribute an edit or two to the documentation. What you think is missing from the manual?

Think I could contribute an edit or two to the documentation. What you think is missing from the manual?

Where is speed control? how to make speed ramp now? on Motion efect I have freeze only

In T10511#176943, @emohr wrote:

proxy clips show up as MKV -> has to be checked why

As far is i saw thers actually no option to reverse a clip. Probably you can it to the "change speed" Dialog...

As far is i saw thers actually no option to reverse a clip. Probably you can it to the "change speed" Dialog...

When I let Kdenlive for 1 hour or 2 on it's own whitout working -> timeline doesn't react anymore.

In T10511#176945, @mardelle wrote:

• automatic compositions from old projects lose automatic feature

that unearths another bug: the existing project has an image clip in project 1920x1080 resolution with an "alpha opertions" effect on it.
It was originally set to operation: blur, threshold: 500, and amount: 3.
in refactoring it is set to operation: noop, threshold: 1000, and amount: 1000.
image clip is svg

• automatic compositions from old projects lose automatic feature
• Cursor getting out of view on pressing end on large zoom
• Don't scale video thumbs with zoom

check the Youtube video to grab bugs still with refactoring: https://www.youtube.com/watch?v=LZ34zSR-6Ys&lc=UgxbQa6hWZrgDzL6qnR4AaABAg

proxy clips show up as MKV -> has to be checked why

In T10511#176928, @emohr wrote:

> Equaliz0r and G -> no settings -> We might however hide the arrow on such effects because it is confusing.

Feature request: Title -> anitmating text position/size would be nice

After draggingit down the timeline, hovering over it causes the timeline to jump up again. -> we should implement a "test/checker" to avoid that.

Equaliz0r and G -> no settings -> We might however hide the arrow on such effects because it is confusing.

Here is the archive that valgrind produced after testing some actions in the bin like selecting and moving the arrows up and down, as well as jkl and playback.

Related to this: https://bugs.kde.org/show_bug.cgi?id=403924

Thanks again. I just pushed your change in refactoring branch so that now rigth click will reset effect.

Yes, seems like a good start!

For some reason I never manage to close differential revisions through my commit messages, but this was committed in refactoring_timeline branch so manually close. Thanks

Thanks for your contribution. The "middle click" to reset is available on all effect types, so we should ideally use the same method on all effects. Some effects have a contaxt menu, in which case there already is a "reset value" entry. So I guess it's not a problem to change it all to right click.

The UI for the dialog box in my mind:

An idea for the icon and a link for designing icons: https://kdenlive.org/en/project/designing-kdenlive-icons/

Thanks afarid. My plan was to do that task after I fix the UI :)

Nice one, please have a look at this related task as well. :)

I'm thinking, maybe replace the plus sign with a "capture" icon and have a dialog box pop up with the same options?

Build #61 looks good. Even with "zebra" for the channels and good contrast.
Top would be if we have the channel names "L,R,Ls,Rs,C,LFE".

sorry, no need for acknowledgement.
If you insist, do it under luzpaz <luzpaz@users.noreply.github.com>

Kunda, did you get my message ? Can you mail me your full name / email adress so that I can acknowledge you in the commit?

In T10085#173857, @emohr wrote:

The waveform visibility is in Adobe Premiere mutch more better.

Speed issue solved with Build #56. Thanks

Applied, thanks a lot

The waveform visibility is in Adobe Premiere mutch more better.

I introduced a typo in the previous patch. Fixed now.

Ok...re-rolled a patch on top of refractoring_timeline
Please test it out

I'll take a look at the refactoring_timeline branch and report back.

I am sorry for my silence on this issue. The main reason I didn't merge is that since 2 years, all the work went in the refactoring_timeline branch.
At this point I am not sure we can successfully merge back into master so we might need to make a forced push.

Do audio clips normally only show one side of the waveform? If so, that might make it more difficult to spot phase related issues.

nvm, I re-rolled the patch omitting the 3rd party libs