alcinos (Nicolas Carion)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 17 2017, 11:51 PM (104 w, 1 d)
Availability
Available

Recent Activity

Nov 6 2018

alcinos added a comment to D16363: Add Threads library to linkage.

Can you paste the error you get when compiling with clang? I'm not sure why this is needed

Nov 6 2018, 1:08 AM

Aug 21 2018

alcinos committed R158:8bda4a1b46b1: fix compilation (authored by alcinos).
fix compilation
Aug 21 2018, 1:30 AM
alcinos committed R158:806031da2dac: model updates are now applied independently (authored by alcinos).
model updates are now applied independently
Aug 21 2018, 1:30 AM

Jul 9 2018

alcinos committed R158:0ed66bca2d0a: some modifications to group movement and more tests (authored by alcinos).
some modifications to group movement and more tests
Jul 9 2018, 1:37 AM
alcinos committed R158:a4508664a323: remove redundant lock checks (authored by alcinos).
remove redundant lock checks
Jul 9 2018, 1:37 AM
alcinos committed R158:b8be3cc1395a: add protection when track is locked (authored by alcinos).
add protection when track is locked
Jul 9 2018, 1:37 AM
alcinos committed R158:a408e1b5f591: failsafe message in core (authored by alcinos).
failsafe message in core
Jul 9 2018, 1:37 AM

Jul 8 2018

alcinos added a member for Kdenlive: alcinos.
Jul 8 2018, 10:30 PM
alcinos added a watcher for Kdenlive: alcinos.
Jul 8 2018, 10:30 PM

Jul 5 2018

alcinos added a comment to T7082: Timeline.

Thanks @manuelmuzzurru, I fixed the bug for selection

Jul 5 2018, 12:08 AM · Kdenlive
alcinos committed R158:abe17b0ecb01: fix selection bounds (authored by alcinos).
fix selection bounds
Jul 5 2018, 12:01 AM

Jul 4 2018

alcinos committed R158:c354bb156fd7: more interface cleanup (authored by alcinos).
more interface cleanup
Jul 4 2018, 11:16 PM
alcinos committed R158:e66eb94e204a: some doc (authored by alcinos).
some doc
Jul 4 2018, 11:16 PM
alcinos committed R158:6d4a820b24eb: slight clean-up in clipmodel interface (authored by alcinos).
slight clean-up in clipmodel interface
Jul 4 2018, 11:16 PM

Jun 22 2018

alcinos committed R158:7c2ae67e6fd0: fix timewarp and workaround Mlt's weird rounding behaviour (authored by alcinos).
fix timewarp and workaround Mlt's weird rounding behaviour
Jun 22 2018, 9:47 PM
alcinos committed R158:e64fca7261e9: checking if an effect is there accounts for groups (authored by alcinos).
checking if an effect is there accounts for groups
Jun 22 2018, 9:47 PM
alcinos committed R158:1fc4053d729e: fix TreeItem::accumulate and add const version (authored by alcinos).
fix TreeItem::accumulate and add const version
Jun 22 2018, 9:47 PM
alcinos committed R158:29fd6a5c4ab6: start using mutex locks in EffectStackModel (authored by alcinos).
start using mutex locks in EffectStackModel
Jun 22 2018, 9:47 PM
alcinos committed R158:9196c6bacb87: make sure udpateStackLength also iterates over children (authored by alcinos).
make sure udpateStackLength also iterates over children
Jun 22 2018, 9:46 PM
alcinos committed R158:9e159104d636: add function to iterate over leaves of a tree (authored by alcinos).
add function to iterate over leaves of a tree
Jun 22 2018, 9:46 PM

Jun 20 2018

alcinos committed R158:8880c016f5d7: clang format (authored by alcinos).
clang format
Jun 20 2018, 2:04 PM
alcinos committed R158:24ecc96fa3c2: add clang-format-ignore (authored by alcinos).
add clang-format-ignore
Jun 20 2018, 2:04 PM
alcinos committed R158:f599b769183c: Update Catch+FakeIt, simplify logic for timewarping and start testing timewarp… (authored by alcinos).
Update Catch+FakeIt, simplify logic for timewarping and start testing timewarp…
Jun 20 2018, 1:54 PM

May 29 2018

alcinos committed R158:24ba13b43b13: fix compil when purpose is not present (authored by alcinos).
fix compil when purpose is not present
May 29 2018, 1:06 AM
alcinos committed R158:1eeaa528b522: restrict the range of pickable speeds from the gui (authored by alcinos).
restrict the range of pickable speeds from the gui
May 29 2018, 12:58 AM
alcinos committed R158:046e20b0e5e3: filewatcher now belongs to projectItemModel and takes undoable insert/remove… (authored by alcinos).
filewatcher now belongs to projectItemModel and takes undoable insert/remove…
May 29 2018, 12:58 AM
alcinos committed R158:bc0a34c44f4d: move model notification logic for speed change inside clipmodel (authored by alcinos).
move model notification logic for speed change inside clipmodel
May 29 2018, 12:58 AM

May 23 2018

alcinos committed R158:b4c5a2116e4f: remove duplicate undo push (authored by alcinos).
remove duplicate undo push
May 23 2018, 12:30 AM
alcinos committed R158:90e190820eb9: add consistency checks for groups and fix tests (authored by alcinos).
add consistency checks for groups and fix tests
May 23 2018, 12:22 AM
alcinos committed R158:6205d798cb85: add proxy to ClipBoard (authored by alcinos).
add proxy to ClipBoard
May 23 2018, 12:22 AM

May 21 2018

alcinos committed R158:f6e9b4dc9b49: fix compilation with newer cmake (authored by alcinos).
fix compilation with newer cmake
May 21 2018, 6:04 PM

May 11 2018

alcinos accepted D12799: Simplify video producer handling.

Ok let's go for option 1 then.

May 11 2018, 10:43 AM
alcinos added a comment to D12799: Simplify video producer handling.

Yeah I guess that's a choice we need to make. If you have a group Audio + Video, then you cannot drag the audio in the video, for sure (and vice versa). However, we need to decide what we want to do for video only clips that have a sound track on the producer (for eg that were inserted, then the audio was degrouped and removed):

May 11 2018, 10:15 AM
alcinos added inline comments to D12799: Simplify video producer handling.
May 11 2018, 1:05 AM

May 2 2018

alcinos committed R158:0f74f3d15fd1: formatting (authored by alcinos).
formatting
May 2 2018, 11:37 PM
alcinos committed R158:55c685bbb7b7: wip to correctly apply bin's effect (authored by alcinos).
wip to correctly apply bin's effect
May 2 2018, 11:33 PM
alcinos committed R158:134b98b1b681: fixed some leaky includes (authored by alcinos).
fixed some leaky includes
May 2 2018, 11:33 PM
alcinos committed R158:19bdf56ea75b: effectstacks can manage several services (authored by alcinos).
effectstacks can manage several services
May 2 2018, 11:33 PM
alcinos committed R158:3569ac0517df: nicer split track computed on drop (authored by alcinos).
nicer split track computed on drop
May 2 2018, 12:40 AM
alcinos committed R158:b671f7edeff2: fix waveform wrongly showing on video clips (authored by alcinos).
fix waveform wrongly showing on video clips
May 2 2018, 12:40 AM

May 1 2018

alcinos committed R158:eafde0c2b97c: fix clip menu to show only enable/disable (authored by alcinos).
fix clip menu to show only enable/disable
May 1 2018, 11:06 PM
alcinos committed R158:9b5ef7969a79: auto change clip type when switching track. Cleaner function to disable (authored by alcinos).
auto change clip type when switching track. Cleaner function to disable
May 1 2018, 10:47 PM
alcinos committed R158:33f6037eac41: correct display of disabled clips (authored by alcinos).
correct display of disabled clips
May 1 2018, 9:01 PM
alcinos committed R158:dc892a51019d: fix clip disabling (authored by alcinos).
fix clip disabling
May 1 2018, 8:37 PM
alcinos committed R158:0b413c8b5b5c: groups are now moved by the model and not the view. Moving av group has the… (authored by alcinos).
groups are now moved by the model and not the view. Moving av group has the…
May 1 2018, 12:17 AM

Apr 30 2018

alcinos committed R158:6785afa77d4b: much cleaner timewarping (authored by alcinos).
much cleaner timewarping
Apr 30 2018, 10:26 PM
alcinos committed R158:72198cb6adba: better enum to be used from qml (authored by alcinos).
better enum to be used from qml
Apr 30 2018, 10:26 PM
alcinos committed R158:3fc4464f474a: Steps towards better gestion of the master producers in the projectClip (authored by alcinos).
Steps towards better gestion of the master producers in the projectClip
Apr 30 2018, 10:26 PM
alcinos committed R158:7761e619af1f: detect speed when creating clipmodel (authored by alcinos).
detect speed when creating clipmodel
Apr 30 2018, 10:26 PM

Apr 29 2018

alcinos committed R158:86a82e6c18a3: remove unused member variable (authored by alcinos).
remove unused member variable
Apr 29 2018, 2:59 PM
alcinos committed R158:c18116c251e3: stricter mutexes in clipModel (authored by alcinos).
stricter mutexes in clipModel
Apr 29 2018, 2:59 PM
alcinos committed R158:db742b68a184: remove unused parameters in adjustStackLength (authored by alcinos).
remove unused parameters in adjustStackLength
Apr 29 2018, 2:59 PM

Apr 26 2018

alcinos committed R158:ddd7a425be85: some fixes on audio splitting + tests (authored by alcinos).
some fixes on audio splitting + tests
Apr 26 2018, 5:50 PM
alcinos committed R158:7cf732a8795f: add better check of presence of audio in producers (authored by alcinos).
add better check of presence of audio in producers
Apr 26 2018, 5:50 PM

Mar 14 2018

alcinos accepted D8928: Summary: Make it possible to drag multiple clips to the timeline.
Mar 14 2018, 3:33 PM

Mar 4 2018

alcinos committed R158:09cf443b5f8d: cleanup some debug (authored by alcinos).
cleanup some debug
Mar 4 2018, 9:28 PM
alcinos committed R158:88168bf94c3e: retain group type when splitting/undoing + tests (authored by alcinos).
retain group type when splitting/undoing + tests
Mar 4 2018, 9:22 PM
alcinos committed R158:2eb78bf4543e: fix potential issue when splitting leaf nodes (authored by alcinos).
fix potential issue when splitting leaf nodes
Mar 4 2018, 6:22 PM

Feb 23 2018

alcinos added a comment to D10772: Reimplement Rotoscoping effect through keyframemodel.

Looks mostly good to me, the main comments are 1) move some roto related functions out of the keyframe class 2) don't break keyframemodellist interface.

Feb 23 2018, 5:34 PM · Kdenlive

Feb 22 2018

alcinos updated the task description for T7128: Refactoring Blockers.
Feb 22 2018, 2:04 PM · Kdenlive
alcinos committed R158:e7091e00aaaf: safer error gestion in case of multiple resize (authored by alcinos).
safer error gestion in case of multiple resize
Feb 22 2018, 2:08 AM
alcinos committed R158:ac506287f02c: fix crash on undo clip insertion in case of audio split (authored by alcinos).
fix crash on undo clip insertion in case of audio split
Feb 22 2018, 1:50 AM
alcinos committed R158:3f858c78ea4e: clang format (authored by alcinos).
clang format
Feb 22 2018, 1:50 AM
alcinos committed R158:3d188d5729b4: apply the same fixes for requestClipInsertion (authored by alcinos).
apply the same fixes for requestClipInsertion
Feb 22 2018, 12:48 AM
alcinos committed R158:cc59d0ca0246: adjust tests to reflect change in zone syntax (authored by alcinos).
adjust tests to reflect change in zone syntax
Feb 22 2018, 12:34 AM
alcinos committed R158:723ee972598c: Add safeguard when requesting creation of clip with invalid id (authored by alcinos).
Add safeguard when requesting creation of clip with invalid id
Feb 22 2018, 12:28 AM

Feb 21 2018

alcinos committed R158:bf05f244f421: clean up a bunch of unused functions (authored by alcinos).
clean up a bunch of unused functions
Feb 21 2018, 12:31 AM

Feb 14 2018

alcinos committed R158:18335e75e37f: Hardening the (de)registration of groups (authored by alcinos).
Hardening the (de)registration of groups
Feb 14 2018, 12:45 AM

Feb 12 2018

alcinos committed R158:d037a28ac5f4: small formatting (authored by alcinos).
small formatting
Feb 12 2018, 11:54 PM
alcinos committed R158:2a0641aedb5c: fix ClipModel tests (authored by alcinos).
fix ClipModel tests
Feb 12 2018, 11:53 PM

Feb 5 2018

alcinos committed R158:bf4f168cbb89: fix keyframes modification in case gui is not there (authored by alcinos).
fix keyframes modification in case gui is not there
Feb 5 2018, 7:40 PM
alcinos committed R158:ac2cd57597eb: fix typo in profile checking (authored by alcinos).
fix typo in profile checking
Feb 5 2018, 7:40 PM

Feb 4 2018

alcinos committed R158:36ffc03ef866: force creation of job manager a bit earlier (authored by alcinos).
force creation of job manager a bit earlier
Feb 4 2018, 4:32 PM

Nov 29 2017

alcinos committed R158:a52f1011312c: rewove dependency on binController in projectItemModel (authored by alcinos).
rewove dependency on binController in projectItemModel
Nov 29 2017, 12:29 AM
alcinos committed R158:d374d8775068: remove binController from timeline view classes (authored by alcinos).
remove binController from timeline view classes
Nov 29 2017, 12:29 AM

Nov 25 2017

alcinos committed R158:1a7fac1056d1: remove references to bincontroller in clipcontroller (authored by alcinos).
remove references to bincontroller in clipcontroller
Nov 25 2017, 6:44 PM
alcinos committed R158:7bc5a8edf8de: remove old unused functions (authored by alcinos).
remove old unused functions
Nov 25 2017, 6:13 PM
alcinos committed R158:bee67ca443cf: fix compilation (authored by alcinos).
fix compilation
Nov 25 2017, 6:13 PM
alcinos committed R158:3e0144b41516: make sure parent folder are correctly stored (authored by alcinos).
make sure parent folder are correctly stored
Nov 25 2017, 5:50 PM

Nov 22 2017

alcinos added inline comments to D8928: Summary: Make it possible to drag multiple clips to the timeline.
Nov 22 2017, 12:20 PM
alcinos added a comment to D8808: Use the thumb producer form project clip in ThumbJob.

See https://community.kde.org/Infrastructure/Phabricator#Workflow. You can use arc land or git push if you don't need to squash

Nov 22 2017, 12:19 PM

Nov 21 2017

alcinos requested changes to D8928: Summary: Make it possible to drag multiple clips to the timeline.

Thanks for the diff, it looks good to me, minus some small details that I pointed out inline.

Nov 21 2017, 11:55 PM

Nov 20 2017

alcinos committed R158:4c934826154f: partial fix for project loading (authored by alcinos).
partial fix for project loading
Nov 20 2017, 12:33 AM
alcinos committed R158:d0105d2c5fba: port necessary function for saving (authored by alcinos).
port necessary function for saving
Nov 20 2017, 12:06 AM
alcinos committed R158:6d65893723cc: make sure thumbs are loaded on bin loading (authored by alcinos).
make sure thumbs are loaded on bin loading
Nov 20 2017, 12:06 AM
alcinos committed R158:f53203890b6f: First stab at bin saving/loading (WIP) (authored by alcinos).
First stab at bin saving/loading (WIP)
Nov 20 2017, 12:06 AM
alcinos committed R158:6187c297f675: Add checks on jobs queries (authored by alcinos).
Add checks on jobs queries
Nov 20 2017, 12:06 AM

Nov 17 2017

alcinos added a comment to T7128: Refactoring Blockers.

Well if you called called requestClipInsertion, then you got back the id of the clip you just added. Then the clipModel has a getPlaytime() method that do what you want. I see that there is no direct getter for the length in the timeline class (there is one for position though, getClipPosition), but you can create your own getter for that on the same model.

Nov 17 2017, 5:35 PM · Kdenlive
alcinos accepted D8808: Use the thumb producer form project clip in ThumbJob.
Nov 17 2017, 5:27 PM
alcinos added a comment to D8808: Use the thumb producer form project clip in ThumbJob.

LGTM. Please note that we have a .clang-format file in the top directory to help you format your code (I can spot some extra spaces here and there :p )

Nov 17 2017, 5:26 PM

Nov 14 2017

alcinos added a comment to T7128: Refactoring Blockers.

Well actually, you probably need a helper function to add several clips consecutively starting from a given (track, position). The right place to implement this is TimelineFunctions. The signature should be along the lines of

static bool requestAddMultipleClips(std::shared_ptr<TimelineItemModel> timeline, const std::vector<int>& binIds, QList<int>& clipIds);

where cliIpIds is a return parameter of the ids of the created clips (if successful). This function repeatedly call requestClipInsertion (the version with undo/redo), unless a conflict is found.

Nov 14 2017, 6:27 PM · Kdenlive
alcinos added a comment to T7128: Refactoring Blockers.

Not directly. The code you are writing will probably be sitting in the timeline qml, and you don't have direct access to groupmodel from there (it is not advisable anyways to access it directly). Rather use requestClipsGroup/requestClipsUngroup from timelineModel.

Nov 14 2017, 4:47 PM · Kdenlive
alcinos added a comment to T7128: Refactoring Blockers.

@boiko sounds good. You have to insert clips using the appropriate function of the timelinemodel, and then group them while the user is dragging (to make sure they all move together) and finally ungroup when the user release them. Let me know if anything goes wrong

Nov 14 2017, 1:35 PM · Kdenlive

Nov 10 2017

alcinos added a comment to T7078: Bin.

I'm probably the one to blame for both issues there :)

Nov 10 2017, 6:59 PM · Kdenlive

Oct 30 2017

alcinos updated the task description for T7128: Refactoring Blockers.
Oct 30 2017, 8:42 PM · Kdenlive

Oct 29 2017

alcinos committed R158:b20e6da1ee35: delete bin clip when loading is not successful (authored by alcinos).
delete bin clip when loading is not successful
Oct 29 2017, 9:16 AM
alcinos committed R158:55179ce4288a: remove depracated producer queue (authored by alcinos).
remove depracated producer queue
Oct 29 2017, 9:12 AM

Oct 28 2017

alcinos committed R158:3dad3f43193b: clang-format (authored by alcinos).
clang-format
Oct 28 2017, 11:19 PM
alcinos committed R158:20407bdaf787: Huge cleanup of clip creation and jobs (authored by alcinos).
Huge cleanup of clip creation and jobs
Oct 28 2017, 11:15 PM
alcinos committed R158:f100d1362620: edit gitignore (authored by alcinos).
edit gitignore
Oct 28 2017, 11:15 PM