Differential D18214

Changed way to reset ColorWheel in LiftGammaGain
ClosedPublic
Actions

Authored by kurtz on Jan 12 2019, 7:48 PM.

Details

Reviewers
mardelle
Group Reviewers
Kdenlive
Maniphest Tasks
T10295: Improve "lift_gamma_gain" effect UI
Summary

Changed way to restore the default of the color wheel from middle mouse click to right mouse click because it is the better way for Mac/Windows/Laptop users.
See https://phabricator.kde.org/T10295

Diff Detail

Repository
R158 Kdenlive
Lint
Lint Skipped
Unit
Unit Tests Skipped
kurtz requested review of this revision.Jan 12 2019, 7:48 PM
kurtz created this revision.
kurtz added a reviewer: mardelle.
kurtz added a task: T10295: Improve "lift_gamma_gain" effect UI.
mardelle added a comment.Jan 25 2019, 4:56 PM

Thanks for your contribution. The "middle click" to reset is available on all effect types, so we should ideally use the same method on all effects. Some effects have a contaxt menu, in which case there already is a "reset value" entry. So I guess it's not a problem to change it all to right click.

mardelle accepted this revision.Jan 31 2019, 6:49 PM

Thanks again. I just pushed your change in refactoring branch so that now rigth click will reset effect.

This revision is now accepted and ready to land.Jan 31 2019, 6:49 PM
mardelle closed this revision.Jan 31 2019, 6:49 PM

Revision Contents
Changeset List

Diff 49350

View Options

src/assets/view/widgets/colorwheel.cpp

Loading...