Misc. typos

Authored by kundak on Mar 27 2018, 10:02 AM.



Found via codespell -q 3 -L uint,splitted,creat,tim,atleast,aline,nd,ang,dur,acount,filesnames,unselect,nto,originaly,shotcut -S ./src/lib/external/kiss_fft,./.git/logs
Rebased on refractoring_timeline

Diff Detail

R158 Kdenlive
Lint Skipped
Unit Tests Skipped
kundak requested review of this revision.Mar 27 2018, 10:02 AM
kundak created this revision.

First time submitting to phabricator, can anyone please at least respond ?

mardelle accepted this revision.Mar 30 2018, 12:06 PM

We are a very small team, so please be patient. Ok to me.

This revision is now accepted and ready to land.Mar 30 2018, 12:06 PM

Patch is still valid with current HEAD. Please merge.

Is it possible to get an ETA on when this patch will land ?

aacid added a subscriber: aacid.Jan 16 2019, 11:31 PM

unfortunately doesn't seem to apply anymore.

If you updated it, i'll try to commit it in a timeline manner.

kundak updated this revision to Diff 49687.Jan 17 2019, 7:09 AM


ugh, not sure but I don't think src/lib/external/kiss_fft/* files should be in the patch but I added them by mistake. Should I remove them or can you manually omit it?

kundak updated this revision to Diff 49688.Jan 17 2019, 7:16 AM

nvm, I re-rolled the patch omitting the 3rd party libs

I am sorry for my silence on this issue. The main reason I didn't merge is that since 2 years, all the work went in the refactoring_timeline branch.
At this point I am not sure we can successfully merge back into master so we might need to make a forced push.

It would be much better to create a patch for this branch. Again, sorry for my very poor support on this issue.

I'll take a look at the refactoring_timeline branch and report back.

kundak updated this revision to Diff 49696.Jan 17 2019, 10:12 AM

Ok...re-rolled a patch on top of refractoring_timeline
Please test it out

kundak updated this revision to Diff 49699.Jan 17 2019, 10:18 AM
kundak edited the summary of this revision. (Show Details)

I introduced a typo in the previous patch. Fixed now.

Kunda, did you get my message ? Can you mail me your full name / email adress so that I can acknowledge you in the commit?

sorry, no need for acknowledgement.
If you insist, do it under luzpaz <luzpaz@users.noreply.github.com>

mardelle closed this revision.Jan 25 2019, 4:59 PM

For some reason I never manage to close differential revisions through my commit messages, but this was committed in refactoring_timeline branch so manually close. Thanks