- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jan 5 2019
Jan 4 2019
You also need to handle correctly the cases where you resize the screen (ctrl+F to remove fullscreen) and be sure texts are well displayed and elements don't override with other ones
Jan 3 2019
When running the activity : qrc:/gcompris/src/core/ : No such file or directory
There should not be warnings or errors.
Jan 2 2019
@echarruau , @timotheegiet : is it good for you to merge it?
@rohitdas sorry for the long delay but on my side, I think it will be better to implement it via the multiple dataset (basically, it will mean adding a new abstraction level to let the child choose the difficulty he wants to play with. We can have one dataset with number between 1 and 3, another one between 2 and 6...). For now, multiple_dataset is still a WIP (https://cgit.kde.org/gcompris.git/log/?h=multiple_dataset) but once available, it will provide more separated difficulty levels for children.
In D17850#384907, @dekumar wrote:The same tutorial is also displayed in case of other activities using the same base code (as planegame for example) and it's not expected, Can you explain this in detail please?
Jan 1 2019
Thank you for the patch.
I have this warning when I start the activity: qrc:/gcompris/src/core/Tutorial.qml:187:9: Unable to assign [undefined] to QUrl
Dec 31 2018
A few notes (pros/cons) on programming side:
- Using the in-menu choice:
We only need to update the menu code once, and for each activity, add the datasets, levels in ActivityInfo.qml and update the logic to use the dataset.
- Using the configuration in activity:
For each activity, we need to add the datasets, levels in ActivityInfo.qml and update the logic to use the dataset.
Plus, adding/updating the configuration dialog, finding a way to not have to duplicate it on all the activities, finding a common generic way to load/store the information. Once it's changed, we need to restart the activity to first level + handling correctly if there are other configuration changes.
Dec 29 2018
Dec 25 2018
Dec 24 2018
Dec 23 2018
Dec 22 2018
Dec 21 2018
Sorry for delay.
- Renaming the activities to Ordering numbers, Ordering letters.
Dec 20 2018
Dec 19 2018
Dec 18 2018
Thank you!
Sorry for delay, I fixed other issues within the patch:
- when you submit an answer, you may have 3 texts displayed on the right that was hidden by the light (too much color/not enough color...)
- I put the score on the left to avoid potential overriding and having a floating score
- I set a max value for the circle radius to avoid having it going too big.
Dec 17 2018
There are still some issues with overriding when reducing the size screen.
As Timothée will rework the activity later (replace the texts with icons, better layout), it may be better to let him integrate the feature and fix these overriding if you prefer?
Else feel free to continue :)
Dec 16 2018
Thank you, it's commited: https://commits.kde.org/gcompris/41b4d43d5885f9350ada3b6c1b12549495fb828a
We are now above 50% of lines tested in GCompris (you can find the result in https://build.kde.org/job/Extragear/job/gcompris/job/kf5-qt5%20SUSEQt5.10/35/cobertura/!
I removed the 2 cases with register of test_isDataRegistered, as it did not work as expected.