Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T10213: Adding tutorials and addition of extra level in even odd activity
Diff Detail
- Repository
- R2 GCompris
- Branch
- new
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6457 Build 6475: arc lint + arc unit
Thanks in advance for fixing issues.
| src/activities/planegame/planegame.js | ||
|---|---|---|
| 49 | This is not the classic definition. It holds true for the decimal system only. | |
| src/activities/planegame/resource/tutorial.qml | ||
| 16 | Typo: does not end -> do not end | |
| src/activities/planegame/resource/tutorial2.qml | ||
| 20 | The question sign at the end is not needed. | |
| 117 | Typo: No -> No, | |
| src/activities/planegame/resource/tutorial3.qml | ||
| 21 | The question sign at the end is not needed. | |
| 118 | Typo: No -> No, | |
| src/activities/planegame/resource/tutorial4.qml | ||
| 20 | The question sign at the end is not needed. | |
| 117 | Typo: No -> No, | |
@yurchor I would fix all the issue and update the diff again.Thanks for reviewing it :)
Thank you for the patch.
I have this warning when I start the activity: qrc:/gcompris/src/core/Tutorial.qml:187:9: Unable to assign [undefined] to QUrl
The same tutorial is also displayed in case of other activities using the same base code (as planegame for example) and it's not expected.
When I continue on the tutorial: qrc:/gcompris/src/activities/planegame/resource/tutorial2.qml:66:7: QML GCText: Cannot anchor to an item that isn't a parent or sibling.
| src/activities/planegame/planegame.js | ||
|---|---|---|
| 49 | Even numbers are numbers which leave remainder 0 when divisible by 2. | |
| 54 | why starting with "tutorial1", then "tutorial", then "tutorial2" as filename and not order them? | |
| src/activities/planegame/resource/tutorial.qml | ||
| 13 | id: even | |
| 15 | 2 spaces between "numbers" and "are" | |
| src/activities/planegame/resource/tutorial1.qml | ||
| 13 | Some spaces shouldn't be there to separate the numbers. | |
| src/activities/planegame/resource/tutorial2.qml | ||
| 13 | variable naming is not good | |
| 42 | why do you want to translate 2? | |
| 97 | you probably can use only one GCText to display if it is good or not and change the text accordingly | |
| src/activities/planegame/resource/tutorial3.qml | ||
| 117 | it does not leave | |
The same tutorial is also displayed in case of other activities using the same base code (as planegame for example) and it's not expected, Can you explain this in detail please?
Run the activity "planegame" or "alphabet_sequence" and you'll still see the tutorial. There are several activity that inherits from other ones to avoid duplicating code. For planegame: AlphabetSequence, NumbersOddEven and Planegame (https://github.com/gcompris/GCompris-qt/search?l=QML&q=Planegame&type=).
The tutorial content is specific to NumbersOddEven (we can probably add ones for the other 2, but the content will need to be adapted).