KritaProject
ActivePublic

Details

Description

This is the primary project for upcoming Krita projects and versions.
New features leading to the next major release and wishlist items go here.

Flow of a feature:

  1. First goes into Krita: Abyss
    1. Here artists with ideas can leave their idea(but do notify us first).
  2. Then someone who is interested, will take this task(assign it to themselves). (You absolutely need to be commited to making the feature work)
  3. It will be moved to Krita: Next Features
    1. Figure out usecases(idea gathering)
    2. Consolidation of ideas.
    3. First architecture is designed.
    4. Make gui.
    5. Make the feature... feature complete..
    6. get approved for merge.
  4. If feature is implemented, merged, and there has been a mail to the mailing list(!Important!)
  5. Assign Krita: Manual and krita testing. (So that it can be documented, and get a test-by-fire)
  6. When those are done. Move to Krita next releases, where it'll be put into a 'make noise' column.
  7. Final resting place in column of release that it was in.

Discussion and GUI design of the upcoming features

Please use this dashboard for quick access to all discussion and testing tasks:
https://phabricator.kde.org/dashboard/view/25/

(You can also access the same tasks from the big Krita: Next Features board itself)

Release process:

The process of making a release (building packages and making announcements) is managed in Krita Current (3.1.2) board.

To get more information, see a special dashboard:
https://phabricator.kde.org/dashboard/view/24/
(all the "Tasks" panels are linked to the corresponding columns of the board)

Other boards:

Source: T3541

Recent Activity

Today

catalingeorgefestila created T11225: Krita 4.2.2 import krita module change code.
Mon, Jul 15, 6:35 PM · Krita
amedonosova added a comment to T11194: Krita Saving Issues.

Shouldn't a QIODevice::close() do the fsync already?

Mon, Jul 15, 5:56 AM · Krita

Fri, Jul 12

rempt added a comment to T11194: Krita Saving Issues.

Shouldn't a QIODevice::close() do the fsync already?

Fri, Jul 12, 8:00 AM · Krita
amedonosova edited projects for T11021: Enhancements to quality assurance, added: Krita; removed Krita: Abyss.
Fri, Jul 12, 3:54 AM · Krita

Thu, Jul 11

amedonosova added a comment to T11194: Krita Saving Issues.

I do not understand how it is possible to not get any warning anymore when saving fails in the ordinary way, because we now explicitly check whether there is a readable file in the destination location.

Thu, Jul 11, 1:46 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:1615e9129bcd: Checkpoints are drawn now, :).
Thu, Jul 11, 2:52 AM · Krita

Tue, Jul 9

hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:da0cf17c6c97: Selection works as expected.
Tue, Jul 9, 6:29 PM · Krita

Mon, Jul 8

hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:b44404ee9bc6: Selection can be done with the Magnetic Lasso.
Mon, Jul 8, 9:21 PM · Krita
amedonosova added a comment to T11194: Krita Saving Issues.

Related bug report - a race condition in the saving process leading to missing files: https://bugs.kde.org/show_bug.cgi?id=409395, work in progress fix: https://invent.kde.org/kde/krita/merge_requests/59

Mon, Jul 8, 12:29 PM · Krita
rempt added a comment to T11194: Krita Saving Issues.

QSaveFile on Windows triggers the problems with dropbox/onedrive/gdrive where the syncing system locks the temporary file so it cannot be atomically renamed: that's why I implemented the temporary file + copy system.

Mon, Jul 8, 10:49 AM · Krita
tymond added a comment to T11194: Krita Saving Issues.

Anna Medonosová wrote:

Mon, Jul 8, 10:44 AM · Krita
tymond added a comment to T11194: Krita Saving Issues.

(About the "Related" links about Dropbox issues and the workaround):

Mon, Jul 8, 10:43 AM · Krita
tymond added a comment to T11194: Krita Saving Issues.

Anna Medonosova wrote:

Mon, Jul 8, 10:42 AM · Krita
tymond added a comment to T11194: Krita Saving Issues.

I managed to reproduce it that way:
Open a big animation file.
Add a new layer on top of everything.
Add a new frame on 0th.
Draw something on it.
Wait for autosave to kick in and finish its work. (Save during autosave most probably won’t work, either, but it will leave the file unsaved, so Krita will ask whether we want to close it or not)
Save the file.
Very quickly click “X” on the window top bar; Windows ask if it should close Krita; don’t do anything
Krita will start responding and it will close just after that.
No saved file anywhere.
Not sure how reproduceable it is in general. Also there is that additional thing that Windows ask what to do with unresponding Krita - no one reported it beforehand.
I guess it happens when Krita is busy for example making a copy of the image and maybe that happens before Krita starts blocking itself because of the saving going on…

Mon, Jul 8, 10:41 AM · Krita
tymond created T11194: Krita Saving Issues.
Mon, Jul 8, 10:40 AM · Krita

Sun, Jul 7

hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:70b167f41b9f: Optimized the algorithm, implemented checkpoints.
Sun, Jul 7, 7:53 AM · Krita

Mon, Jul 1

hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:79aeb7826c2c: LoG now runs on tool activation.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:7b53f2e4659d: Creates a bouding rectangle before searching.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:b64a646d303a: Reduced the number of calls KisPaintDevice::exactBounds() is called.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:3f74df11d694: Initial take on the UI.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:8fc4030bdcce: Set the initial structure for Magnetic Selection Tool.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:58c2ab7acc3e: Added a couple of comments and completed the test.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:463a9b189150: The algorithm is almost perfect now.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:ca7340a0eef8: Not clean but the output is closer to what is expected.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:958cc6b1e584: The algorithm works as expected now.
Mon, Jul 1, 1:27 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:1ca04c3f8b3c: Fixed the intensity function.
Mon, Jul 1, 1:27 PM · Krita

Mon, Jun 24

rempt closed D21886: Simplify QApplication created to wrap test GLContext..
Mon, Jun 24, 1:31 PM · Krita
rempt added a comment to D21886: Simplify QApplication created to wrap test GLContext..

Sure!

Mon, Jun 24, 1:29 PM · Krita
davidedmundson added a comment to D21886: Simplify QApplication created to wrap test GLContext..

I'm away at a sprint without my git checkout of krita and poor internet.

Mon, Jun 24, 1:29 PM · Krita

Thu, Jun 20

rempt added a comment to D21886: Simplify QApplication created to wrap test GLContext..

Yes, this works :-)

Thu, Jun 20, 8:08 AM · Krita
rempt accepted D21886: Simplify QApplication created to wrap test GLContext..
Thu, Jun 20, 8:07 AM · Krita

Wed, Jun 19

vanyossi added a comment to T11114: Add live Multiple tip brush.

From what I understand from the video is this:

Wed, Jun 19, 3:31 PM · Krita

Tue, Jun 18

davidedmundson requested review of D21886: Simplify QApplication created to wrap test GLContext..
Tue, Jun 18, 8:08 PM · Krita

Mon, Jun 17

scottpetrovic added a comment to T11114: Add live Multiple tip brush.

Do we need any ability to edit individual tips, or just add and remove them from external files (like these two example videos are doing). I think the editing is where it might start getting tricky on the UI.

Mon, Jun 17, 9:40 PM · Krita
vanyossi created T11114: Add live Multiple tip brush.
Mon, Jun 17, 8:10 PM · Krita

Jun 14 2019

tusooaw added a comment to D20103: Color Slider Docker.

That's because floating point RGB colorspaces are RGB, while integer are BGR. As for KisDisplayConverter, we don't expose that to Python yet.

Jun 14 2019, 3:05 AM · Krita

Jun 13 2019

hellozee added a comment to T10894: Porting Magnetic Lasso to Krita.

Oo commits are showing up now

Jun 13 2019, 5:31 PM · Krita
dkazakov added a comment to D21682: Palettize Filter.

Oups, looks like I've pasted wrong email into the commit. I'm sorry, @surt :( I should have used the line from the copyright notice... Anyway, we are moving to gitlab now (https://invent.kde.org), so such mistakes shouldn't happen anymore :(

Jun 13 2019, 12:46 PM · Krita
rempt added a comment to D20103: Color Slider Docker.

That's because floating point RGB colorspaces are RGB, while integer are BGR. As for KisDisplayConverter, we don't expose that to Python yet.

Jun 13 2019, 7:40 AM · Krita
dkazakov requested changes to D20103: Color Slider Docker.

Okay. Actually, I don't think it should actually "support" non-rgb color spaces. It just show colors correctly when image color space is non-rgb. For that it must use KisDisplayColorConverter class, converts image colors into a correct QColor.

Jun 13 2019, 7:34 AM · Krita
tusooaw added a comment to D20103: Color Slider Docker.

The patch works as expected :)

I have found only two minor issues:

  1. The settings dialog should use QSpinBox instead of QLineEdit
  2. [DISPUTABLE] The arrow looks as if it is offset to the top. Was it expected?

Please fix at least the first point and push the patch into master without any further review :)

Jun 13 2019, 12:55 AM · Krita

Jun 12 2019

hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:51e0986a4748: Distance heuristic function takes threshold into account now.
Jun 12 2019, 4:46 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:5adb8eb6d6a9: AStar Search is doing its job, mostly likely.
Jun 12 2019, 4:46 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:09c77df3cce0: Implemented boost::astar_search using the KisMagneticGraph wrapper.
Jun 12 2019, 4:46 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:d8e844a362c6: Implemented the boost::graph interface for KisPaintDevice.
Jun 12 2019, 4:46 PM · Krita
hellozee added a commit to T10894: Porting Magnetic Lasso to Krita: R37:afcb9243c0a2: Added initial structure for KisMagneticWorkerTest.
Jun 12 2019, 4:46 PM · Krita
dkazakov accepted D20103: Color Slider Docker.

The patch works as expected :)

Jun 12 2019, 4:13 PM · Krita
dkazakov added a comment to D21682: Palettize Filter.

Thank you for your patch, it looks and works perfectly, so I have merged it into master :)

Jun 12 2019, 3:55 PM · Krita
dkazakov closed D21682: Palettize Filter.
Jun 12 2019, 3:52 PM · Krita
dkazakov closed D20475: High Pass Filter.
Jun 12 2019, 3:15 PM · Krita