emmetoneill (Emmet O'Neill)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2018, 8:24 PM (35 w, 6 d)
Availability
Available

Recent Activity

Wed, Nov 14

emmetoneill added a comment to D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..

It looks like I didn't set Update to be checked by default in the .ui file, so that may be what caused the issue.

Wed, Nov 14, 3:56 AM · Krita

Tue, Nov 13

emmetoneill added a comment to D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..

Hi, @emmetoneill!

I have tested your patch very briefly. It looks fine :) Here are the notes:

  1. [Regression?] Normal Ctrl+click in a paint too has stopped working for some reason. Do you have the same?
  2. Shift+Ctrl+click seem to work fine and does what expected
  3. Blending while dragging seem to work.
  4. The Color Picker GUI looks good :)
Tue, Nov 13, 4:06 AM · Krita

Mon, Nov 12

emmetoneill added a comment to D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..

Part of T8708

Mon, Nov 12, 7:14 AM · Krita
emmetoneill updated the summary of D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..
Mon, Nov 12, 7:12 AM · Krita
emmetoneill requested review of D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..
Mon, Nov 12, 6:56 AM · Krita

Oct 14 2018

emmetoneill committed R37:3f6177619dcc: Improved responsiveness of moving large SVG objects. (authored by emmetoneill).
Improved responsiveness of moving large SVG objects.
Oct 14 2018, 8:52 PM
emmetoneill added a comment to T8708: Color Picker Improvements and Refactoring..

Add of adjust a KisSignalCompressor with configurable sensitivity.

Oct 14 2018, 3:33 PM · Krita: Abyss
emmetoneill committed R37:e9b382d7ffd4: Restored ability to pick colors from the Text Editor. (authored by emmetoneill).
Restored ability to pick colors from the Text Editor.
Oct 14 2018, 1:20 PM

Oct 12 2018

emmetoneill committed R37:ce8254dc5ea7: Color smudge brushes now work properly in combination with alpha lock. (authored by emmetoneill).
Color smudge brushes now work properly in combination with alpha lock.
Oct 12 2018, 6:22 PM

Oct 10 2018

emmetoneill committed R37:ffb7d98ce4b2: Fix regression in node undo/redo. (authored by emmetoneill).
Fix regression in node undo/redo.
Oct 10 2018, 9:14 PM
emmetoneill committed R37:20406f0cb05f: Fix KisImageLayerAddCommand Redo/Undo Updating Bug. (authored by emmetoneill).
Fix KisImageLayerAddCommand Redo/Undo Updating Bug.
Oct 10 2018, 9:36 AM

Oct 9 2018

emmetoneill committed R37:189679b7108a: Avoid blending bug on first color pick. (authored by emmetoneill).
Avoid blending bug on first color pick.
Oct 9 2018, 7:51 PM
emmetoneill committed R37:d056aac2e60d: Fixed Selection Tool Crash on View Change. (authored by emmetoneill).
Fixed Selection Tool Crash on View Change.
Oct 9 2018, 11:59 AM

Oct 8 2018

emmetoneill committed R37:a28ce83a44f8: Fix missing shortcut from Fill Tool tooltip. (authored by emmetoneill).
Fix missing shortcut from Fill Tool tooltip.
Oct 8 2018, 11:33 AM

Oct 7 2018

emmetoneill committed R37:83a05fffb07d: Prevent opening filter dialogs on non-editable layers. (authored by emmetoneill).
Prevent opening filter dialogs on non-editable layers.
Oct 7 2018, 7:21 PM
emmetoneill committed R37:4976def25dc7: Color picker now correctly picks alpha values. (authored by emmetoneill).
Color picker now correctly picks alpha values.
Oct 7 2018, 4:25 PM

Oct 2 2018

emmetoneill added a comment to D15755: Global Kinetic Scrolling.

If D8015 didn't take care of it already, this would also close this wishlist/bug: https://bugs.kde.org/show_bug.cgi?id=324005

Oct 2 2018, 7:16 PM · Krita
emmetoneill added a comment to M137: Consolidated brush editor UI design ideas.

Sounds good to me! Nice work so far.

Oct 2 2018, 12:11 AM · Krita

Oct 1 2018

emmetoneill added a comment to M138: Krita: Multi-target Exporter.

From a UI standpoint, my main concern is that 90% of the people that use export want it the way it works now. They just want to simply output the file to a different format.

Oct 1 2018, 11:45 PM · Krita: Abyss
emmetoneill added a comment to M137: Consolidated brush editor UI design ideas.

I think the balancing act is how do we appease people that want to see a lot of settings at one time, and how do we appease the people that want just a slice of the settings so they can maximize their canvas workable area.

Oct 1 2018, 9:26 PM · Krita

Sep 30 2018

emmetoneill created M138: Krita: Multi-target Exporter.
Sep 30 2018, 10:24 PM · Krita: Abyss

Sep 28 2018

emmetoneill added a comment to M137: Consolidated brush editor UI design ideas.

Hi Scott. I like the direction of the new design and I think you did a great job saving space without making any major compromises.

Sep 28 2018, 1:15 AM · Krita

Sep 26 2018

emmetoneill added a comment to D15755: Global Kinetic Scrolling.

I'm not totally sure about this

Sep 26 2018, 10:46 PM · Krita
emmetoneill added a comment to D15755: Global Kinetic Scrolling.

Hi Alvin,

Sep 26 2018, 5:07 AM · Krita
emmetoneill resigned from D15755: Global Kinetic Scrolling.

(Removing myself as a reviewer since I helped a bit with this one.)

Sep 26 2018, 12:30 AM · Krita

Sep 15 2018

emmetoneill added a member for Bugsquad: emmetoneill.
Sep 15 2018, 7:54 PM

Aug 2 2018

emmetoneill committed R37:6a737a98957a: Fixed SegFault in LibKis Node mergeDown (authored by emmetoneill).
Fixed SegFault in LibKis Node mergeDown
Aug 2 2018, 7:04 AM

Aug 1 2018

emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
Aug 1 2018, 3:22 AM · Krita: Abyss

Jun 28 2018

emmetoneill added a comment to T8708: Color Picker Improvements and Refactoring..

Reddit user Rous2 suggested the possibility of pressure sensitive color picker mixing (blend).

Jun 28 2018, 1:35 AM · Krita: Abyss

Jun 11 2018

emmetoneill added a comment to D13441: Manual: Timeline Docker - Edit and Update for v4.1 .

Ok, thanks for the help!

Jun 11 2018, 5:44 AM · Krita: Manual

Jun 9 2018

emmetoneill updated the diff for D13441: Manual: Timeline Docker - Edit and Update for v4.1 .

Installed Sphinx. It was super easy to get working (on Linux, at least), just install and build. Overall Sphinx has been great to work with! Much improved workflow, in my opinion.

Jun 9 2018, 10:33 PM · Krita: Manual
emmetoneill updated the diff for D13441: Manual: Timeline Docker - Edit and Update for v4.1 .

Spelling and grammar fixes.

Jun 9 2018, 12:47 AM · Krita: Manual
emmetoneill updated the diff for D13441: Manual: Timeline Docker - Edit and Update for v4.1 .
Jun 9 2018, 12:43 AM · Krita: Manual
emmetoneill requested review of D13441: Manual: Timeline Docker - Edit and Update for v4.1 .
Jun 9 2018, 12:38 AM · Krita: Manual

Jun 8 2018

emmetoneill claimed T8973: 4.1 Timeline improvements.

If you want to take a stab at it, the contributor's manual (readme) has instructions on how to contribute to sphinx. You can also write up the text here, in which case I'll port it.

Jun 8 2018, 5:09 PM · Krita: Manual
emmetoneill added a comment to T8973: 4.1 Timeline improvements.

Hey Wolfthera, I'd like to help with this if possible. Is this the only page that needs to be updated? I'd be happy to write about the new features as of 4.1 and edit what's already there.

Jun 8 2018, 12:18 AM · Krita: Manual

Jun 6 2018

emmetoneill closed D13376: Bugfix: Animation Timeline's "Remove Frames and Pull" now removes expect frames consistently..

Fixed and built the tests, and then pushed! Closing. Thanks again, Dmitry.

Jun 6 2018, 7:06 PM · Krita
emmetoneill committed R37:b2ae65a74562: Fixed Timeline's "Remove Frames/Columns and Pull" Actions. (authored by emmetoneill).
Fixed Timeline's "Remove Frames/Columns and Pull" Actions.
Jun 6 2018, 7:00 PM
emmetoneill updated the summary of D13376: Bugfix: Animation Timeline's "Remove Frames and Pull" now removes expect frames consistently..
Jun 6 2018, 7:13 AM · Krita
emmetoneill requested review of D13376: Bugfix: Animation Timeline's "Remove Frames and Pull" now removes expect frames consistently..
Jun 6 2018, 7:10 AM · Krita

May 29 2018

emmetoneill closed D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

Pushed R37:7030f6a906da7b9ec0d660394dad7f691edf9bc2. Closing.

May 29 2018, 8:49 PM · Krita
emmetoneill committed R37:7030f6a906da: Animation Timeline Refactor + Bugfix (authored by emmetoneill).
Animation Timeline Refactor + Bugfix
May 29 2018, 8:44 PM

May 28 2018

emmetoneill updated the diff for D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

Resolved the regression caused by my previous patch 7c639729115b3a3bb20e1b0a1046c1bfbb6f41fe, which caused only one frame to be added by the "insert frames/columns left/right" actions regardless of number of selected frames. These actions now correctly insert new blank keyframes on the correct side of the cursor based on the number of currently selected frame slots.

May 28 2018, 5:45 AM · Krita

May 27 2018

emmetoneill added a comment to D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

Alright! I'm looking into it right now.

May 27 2018, 6:28 PM · Krita

May 25 2018

emmetoneill added a comment to D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

I have tested your patch, it works and looks mostly fine. I have managed to find one small regression though:

  1. Select three consecutive frames
  2. Press "Insert keyframe right"

    Expected (old) behavior:
  3. Three new frames are added at the right of the current selection

    Regression in the patch:
  4. One new frame is added

    The same problem happens with "Insert frame left" and their columns counterparts. I guess this small regression is the last thing that blocks the patch from being pushed :)
May 25 2018, 12:25 AM · Krita

May 24 2018

emmetoneill updated the diff for D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

Here's an update patch that fixes the menus. I popped a few more of the one-liners that call more general member functions into the header. I also fixed a tiny bug with the separators in the insert frame/hold columns menus and cleaned up some unused headers.

May 24 2018, 5:53 AM · Krita

May 22 2018

emmetoneill added a comment to T3496: Cycles in animation.

I assume in your example the run cycle is drawn somewhere outside the range of frames you describe here.

May 22 2018, 7:50 PM · Krita: Next Features (Needs usecases and ideas)

May 21 2018

emmetoneill added a comment to T3496: Cycles in animation.

Our users should be able to:

  • mark a cycle on the timeline
  • change the range frames which are repeated
  • edit the frames of a cycle. Changes should be reflected in the repeats.
  • convert repeats into actual keyframes or clone frames
  • draw on repeats without breaking the cycle due to automatic keyframing (option in autokey?)
May 21 2018, 11:04 PM · Krita: Next Features (Needs usecases and ideas)

May 20 2018

emmetoneill added a comment to T3496: Cycles in animation.

Hey everyone, I just wanted to share a possible design mock-up for animation cycles that I put together.

May 20 2018, 11:18 PM · Krita: Next Features (Needs usecases and ideas)
emmetoneill added a comment to T3587: Open as layer command line parameter.

Interesting idea.

May 20 2018, 9:35 PM · Krita: Next Features
emmetoneill updated the summary of D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.
May 20 2018, 6:58 AM · Krita
emmetoneill updated the diff for D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.

Added code-reuse refactor for hold frames and hold columns.

May 20 2018, 6:57 AM · Krita

May 19 2018

emmetoneill updated the summary of D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.
May 19 2018, 8:26 AM · Krita
emmetoneill requested review of D12977: Refactor: Animation Timeline Code Reuse and Menu Simplification.
May 19 2018, 8:16 AM · Krita

May 18 2018

emmetoneill added revisions to T8652: Krita 4.1.4 Release Task: D11895: Feature: Color Picker Blending, D12843: Animation Timeline Docker: Insert Keyframes with Timing. .
May 18 2018, 8:40 PM · Krita: Releases
emmetoneill added a task to D11895: Feature: Color Picker Blending: T8652: Krita 4.1.4 Release Task.
May 18 2018, 8:40 PM · Krita
emmetoneill added a task to D12843: Animation Timeline Docker: Insert Keyframes with Timing. : T8652: Krita 4.1.4 Release Task.
May 18 2018, 8:40 PM · Krita: Abyss
emmetoneill edited projects for T8708: Color Picker Improvements and Refactoring., added: Krita: Abyss; removed Krita.
May 18 2018, 8:36 PM · Krita: Abyss
emmetoneill added a comment to T8652: Krita 4.1.4 Release Task.

Hey boud and wolthera. Would it be ok to add these feature revisions to the task? They're both in master now.

May 18 2018, 6:07 PM · Krita: Releases
emmetoneill triaged T8708: Color Picker Improvements and Refactoring. as Low priority.
May 18 2018, 6:24 AM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 18 2018, 6:24 AM · Krita: Abyss
emmetoneill updated the summary of D12953: Bug fix: Ctrl-activated color picker no longer glitches out when double clicking with a mouse..
May 18 2018, 6:22 AM · Krita
emmetoneill added reviewers for D12953: Bug fix: Ctrl-activated color picker no longer glitches out when double clicking with a mouse.: Krita, rempt, dkazakov.
May 18 2018, 6:19 AM · Krita
emmetoneill requested review of D12953: Bug fix: Ctrl-activated color picker no longer glitches out when double clicking with a mouse..
May 18 2018, 6:18 AM · Krita
emmetoneill added a comment to T8708: Color Picker Improvements and Refactoring..

Color selector tool changes to the random colors. [ https://bugs.kde.org/show_bug.cgi?id=394396 ]

May 18 2018, 5:35 AM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 18 2018, 5:27 AM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 18 2018, 4:37 AM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 18 2018, 4:01 AM · Krita: Abyss

May 17 2018

emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 17 2018, 6:55 PM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 17 2018, 6:53 PM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 17 2018, 6:51 PM · Krita: Abyss
emmetoneill added a comment to D12941: Refactor: Unified Color Picker Code & Removed Some Duplication.

Great. Thanks again, Dmitry.

May 17 2018, 6:35 PM · Krita: Abyss
emmetoneill updated the summary of D12941: Refactor: Unified Color Picker Code & Removed Some Duplication.
May 17 2018, 7:19 AM · Krita: Abyss
emmetoneill requested review of D12941: Refactor: Unified Color Picker Code & Removed Some Duplication.
May 17 2018, 7:17 AM · Krita: Abyss

May 16 2018

emmetoneill updated the diff for D12843: Animation Timeline Docker: Insert Keyframes with Timing. .

Stupid mistake there, sorry about that! Seems to be all fixed up now and working correctly. Thanks for catching that, Dmitry.

May 16 2018, 8:42 PM · Krita: Abyss

May 15 2018

emmetoneill added a comment to D12843: Animation Timeline Docker: Insert Keyframes with Timing. .

@dkazakov, thanks for the kind words and feedback. I'm glad you like it. I went ahead and made the changes that you requested and I actually properly tested the column insertion this time! Even though I saw the code for columns before, I actually wasn't fully aware of / didn't fully understand what the feature was or how to use it because I never tried clicking on the timeline. That's my mistake though, as it's a useful feature!

May 15 2018, 6:41 PM · Krita: Abyss
emmetoneill updated the diff for D12843: Animation Timeline Docker: Insert Keyframes with Timing. .
  • Fixed bug that caused unwanted creation of columns. Whoops!
  • Added timing and GUI changes to column insertion.
May 15 2018, 6:14 PM · Krita: Abyss
emmetoneill updated the task description for T8708: Color Picker Improvements and Refactoring..
May 15 2018, 4:18 AM · Krita: Abyss
emmetoneill created T8708: Color Picker Improvements and Refactoring..
May 15 2018, 4:15 AM · Krita: Abyss

May 14 2018

emmetoneill added a comment to D12843: Animation Timeline Docker: Insert Keyframes with Timing. .

I added @Bollebib onto this so he can give feedack on the useful-ness of this

May 14 2018, 6:27 PM · Krita: Abyss

May 13 2018

emmetoneill updated the summary of D12843: Animation Timeline Docker: Insert Keyframes with Timing. .
May 13 2018, 6:27 AM · Krita: Abyss
emmetoneill added a comment to T8548: Popup palette improvements.

Hey Scott, I agree with that and I've abandoned my other 'experimental' revision/discussion. Really sorry for the delay in joining you over here even though you added me almost a month ago! In my defense, I'm still very much a phabricator newbie and I get really lost among all the other KDE projects and stuff like that. Please bear with me. =]

May 13 2018, 5:54 AM · Krita: Abyss
emmetoneill abandoned D12815: Feature Discussion: QuickZoom and Popup-Palette Button Changes..
May 13 2018, 5:39 AM · Krita
emmetoneill requested review of D12843: Animation Timeline Docker: Insert Keyframes with Timing. .
May 13 2018, 5:34 AM · Krita: Abyss

May 12 2018

emmetoneill added a member for Krita: Stable bug fixes: emmetoneill.
May 12 2018, 5:42 PM
emmetoneill added a member for Krita: Website and Translations: emmetoneill.
May 12 2018, 5:41 PM
emmetoneill added a member for Krita: Next Features: emmetoneill.
May 12 2018, 5:39 PM
emmetoneill added a member for Krita: Manual: emmetoneill.
May 12 2018, 5:39 PM
emmetoneill added a member for Krita: Abyss: emmetoneill.
May 12 2018, 5:39 PM
emmetoneill accepted D12682: Animation timeline improvements and added "empty frame" concept to data model.
May 12 2018, 5:20 PM
emmetoneill added a comment to D12682: Animation timeline improvements and added "empty frame" concept to data model.

Oh yeah, totally, push it as soon as possible!

May 12 2018, 5:16 PM
emmetoneill added a comment to D12682: Animation timeline improvements and added "empty frame" concept to data model.

Love the patch so far, the animation tools just keep getting better!

May 12 2018, 7:22 AM
emmetoneill added a comment to D12815: Feature Discussion: QuickZoom and Popup-Palette Button Changes..

Hm... I'm wondering about the discoverability of this feature, even with tooltips.

May 12 2018, 5:54 AM · Krita

May 11 2018

emmetoneill updated the summary of D12815: Feature Discussion: QuickZoom and Popup-Palette Button Changes..
May 11 2018, 6:07 AM · Krita
emmetoneill requested review of D12815: Feature Discussion: QuickZoom and Popup-Palette Button Changes..
May 11 2018, 6:05 AM · Krita

Apr 16 2018

emmetoneill added a comment to D12199: Show and configure a reference vanishing point grid.

Working very nicely now! Density updates responsively, hiding works, and the selection highlighting is clear and looks great.

Apr 16 2018, 2:38 AM

Apr 14 2018

emmetoneill added a comment to D12178: Clicking outside preview box moves view to that point.

Seems to work nicely!

Apr 14 2018, 10:30 PM
emmetoneill added a comment to D12199: Show and configure a reference vanishing point grid.

Hi Scott, good idea and nice work. I agree that this is a nice improvement to the way vanishing point assistants are visualized!

Apr 14 2018, 9:27 PM

Apr 11 2018

emmetoneill requested review of D12128: Futher Fixed Bug 391921 - Canvas position popping after pop-up palette rotation reset..
Apr 11 2018, 10:55 PM · Krita

Apr 7 2018

emmetoneill added a comment to T1855: Improve color category..

I'd like to add this section about "color picker blending" under the "off-canvas" section of the Mixing Colors page, and just above the section on the digital colors mixer docker.

Apr 7 2018, 9:23 PM · Krita: Manual