victorw (Victor Wåhlström)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 30 2015, 1:26 PM (215 w, 2 d)
Availability
Available

Recent Activity

May 9 2019

victorw committed R37:a9b68dbb910e: Change Document::createFilterMask API to require either a Selection or a Node… (authored by victorw).
Change Document::createFilterMask API to require either a Selection or a Node…
May 9 2019, 11:31 AM

May 5 2019

victorw committed R37:199cd9f52115: Remove unnecessary include (authored by victorw).
Remove unnecessary include
May 5 2019, 4:15 PM
victorw committed R37:84eb32f2b998: Fix crash when checking if a channel is visible (authored by victorw).
Fix crash when checking if a channel is visible
May 5 2019, 4:13 PM
victorw committed R37:840a169728ef: Prevent additional taskbar entry when invoking the on-canvas color selector (authored by victorw).
Prevent additional taskbar entry when invoking the on-canvas color selector
May 5 2019, 9:27 AM

Feb 4 2019

victorw accepted D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.
Feb 4 2019, 9:54 PM · Krita
victorw added a comment to D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.

I've already added a flake8 config and instructions to run it, and my plan was to squash the flake8 warnings bit by bit and have a bit of an eye on the code, and bring up any issues worth discussing as I find them, such as right now the line lengths (and keep notes for documenting the stuff).

Feb 4 2019, 9:49 PM · Krita

Feb 3 2019

victorw added a comment to D18708: Python code checks: assigneprofiledialog, colorspace, documentttols.

Krita doesn't have any formal style guides yet. I added T6588 to address this, although it's not likely to get much further unless we sit down and figure out what's important and what works for Krita.

Feb 3 2019, 7:39 PM · Krita

Aug 7 2018

victorw committed R37:9e2e5d994809: Add Qt version strings (compiled and runtime) to the bug info dialog (authored by victorw).
Add Qt version strings (compiled and runtime) to the bug info dialog
Aug 7 2018, 7:05 PM

Jul 18 2018

victorw committed R37:da6eb244d873: Use Qt's internal error message as custom error message when file export fails… (authored by victorw).
Use Qt's internal error message as custom error message when file export fails…
Jul 18 2018, 12:32 PM
victorw committed R37:93fb593ec872: Use Qt's internal error message as custom error message when file export fails. (authored by victorw).
Use Qt's internal error message as custom error message when file export fails.
Jul 18 2018, 12:14 PM

Jul 17 2018

victorw committed R37:d6debd29e866: Improve error message in dialog when saving fails and no custom error message… (authored by victorw).
Improve error message in dialog when saving fails and no custom error message…
Jul 17 2018, 9:53 PM
victorw committed R37:d151b0dce2eb: Fix PyQt5 check. Broke for version 5.10.1. (authored by victorw).
Fix PyQt5 check. Broke for version 5.10.1.
Jul 17 2018, 3:14 PM
victorw committed R37:124b522c168c: Add ${SOURCE}/po/ to .gitignore; ignore external translation files if available (authored by victorw).
Add ${SOURCE}/po/ to .gitignore; ignore external translation files if available
Jul 17 2018, 2:33 PM
victorw committed R37:eb5d9f4d284c: Replace i18n() with ki18n() in kis_filter_category_ids.cpp to ensure strings… (authored by victorw).
Replace i18n() with ki18n() in kis_filter_category_ids.cpp to ensure strings…
Jul 17 2018, 11:29 AM
victorw committed R37:7dc40cbc358d: Remove unused FiltersCategoryNonPhotorealisticId (authored by victorw).
Remove unused FiltersCategoryNonPhotorealisticId
Jul 17 2018, 9:50 AM
victorw closed D14164: Extracted kis_filter category KoIDs to separate file.

Committed: https://phabricator.kde.org/R37:08968e7b66ea49ef21ebfee96aaf3b5eb38b3deb

Jul 17 2018, 9:43 AM · Krita
victorw committed R37:08968e7b66ea: Extracted filter category KoIDs to a separate file (authored by victorw).
Extracted filter category KoIDs to a separate file
Jul 17 2018, 9:37 AM
victorw added a commit to T6560: Optimize KoID: R37:08968e7b66ea: Extracted filter category KoIDs to a separate file.
Jul 17 2018, 9:37 AM · Krita

Jul 16 2018

victorw added inline comments to D14164: Extracted kis_filter category KoIDs to separate file.
Jul 16 2018, 5:31 PM · Krita
victorw added inline comments to D14164: Extracted kis_filter category KoIDs to separate file.
Jul 16 2018, 5:21 PM · Krita
victorw requested review of D14164: Extracted kis_filter category KoIDs to separate file.
Jul 16 2018, 5:15 PM · Krita
victorw added a comment to T6560: Optimize KoID.

Looking at the code base, there are two steps that should be taken before any radical change occurs:

Jul 16 2018, 2:15 PM · Krita
victorw committed R37:6c9272c4c4b6: Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp… (authored by victorw).
Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp…
Jul 16 2018, 1:38 PM
victorw added a commit to T6560: Optimize KoID: R37:6c9272c4c4b6: Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp….
Jul 16 2018, 1:38 PM · Krita

Jul 14 2018

victorw committed R37:11668dad1bfc: Move kis_assert.h include in KoColor from header to source as it's no longer… (authored by victorw).
Move kis_assert.h include in KoColor from header to source as it's no longer…
Jul 14 2018, 9:31 AM
victorw added a comment to T8462: Add a Qt Designer plugin for Krita.

I've added the necessary build scripts for building a designer plugin collection, including plugins for KisColorSpaceSelector and KisGradientSlider. You can toggle building of the plugin collection with

Jul 14 2018, 9:17 AM · Krita

Jul 12 2018

victorw committed R37:900c531ec4b0: Added initial Qt Designer plugin for Krita widgets KisColorSpaceSelector and… (authored by victorw).
Added initial Qt Designer plugin for Krita widgets KisColorSpaceSelector and…
Jul 12 2018, 3:41 PM
victorw added a commit to T8462: Add a Qt Designer plugin for Krita: R37:900c531ec4b0: Added initial Qt Designer plugin for Krita widgets KisColorSpaceSelector and….
Jul 12 2018, 3:41 PM · Krita
victorw closed D12043: Qt Designer plugin for Krita, proof of concept.
Jul 12 2018, 3:41 PM · Krita

Apr 8 2018

victorw added a comment to D12043: Qt Designer plugin for Krita, proof of concept.

Note that I've only tested this under Linux (Ubuntu 17.10). There are quite a few gotchas for Windows, which requires that the plugin is compiled under similar conditions as Qt Designer itself. See https://doc.qt.io/qtcreator/adding-plugins.html#matching-build-keys

Apr 8 2018, 12:31 PM · Krita
victorw added inline comments to D12043: Qt Designer plugin for Krita, proof of concept.
Apr 8 2018, 12:16 PM · Krita
victorw requested review of D12043: Qt Designer plugin for Krita, proof of concept.
Apr 8 2018, 11:46 AM · Krita
victorw added a comment to T8462: Add a Qt Designer plugin for Krita.

I wrote an initial implementation for two widgets as a test.

Apr 8 2018, 10:31 AM · Krita
victorw triaged T8462: Add a Qt Designer plugin for Krita as Wishlist priority.
Apr 8 2018, 10:24 AM · Krita

Mar 18 2018

victorw committed R37:bacc6a476ab5: Fix potential crash when the last text input line in the SVG Text Tool is a… (authored by victorw).
Fix potential crash when the last text input line in the SVG Text Tool is a…
Mar 18 2018, 9:39 PM

Mar 1 2018

victorw closed D7121: Refactored the "Hello" Python script and added excessive documentation.

This has already been pushed in 80af6093bad5847fe3681e4715f7ab8b683b2a6a (2017-08-04)

Mar 1 2018, 6:24 PM · Krita

Feb 28 2018

victorw committed R37:aa509c639f95: Updated HACKING file with Python guidelines (authored by victorw).
Updated HACKING file with Python guidelines
Feb 28 2018, 8:21 PM
victorw closed D6891: Added proposed Python guidelines to Krita.
Feb 28 2018, 8:21 PM

Feb 24 2018

victorw committed R37:df10ea0bd77e: Scripter: PEP8 fixes * Whitespace * Don't use empty exception blocks * Use… (authored by victorw).
Scripter: PEP8 fixes * Whitespace * Don't use empty exception blocks * Use…
Feb 24 2018, 8:18 AM

Jan 7 2018

victorw committed R37:7a4da579e9c6: Add ConvertToSubClassCode blocks to all Node subclass sip files, allowing… (authored by victorw).
Add ConvertToSubClassCode blocks to all Node subclass sip files, allowing…
Jan 7 2018, 10:07 PM

Dec 27 2017

victorw added a comment to T6588: Define Python scripting guidelines.

There should be guidelines about where scripts ought to persist their data.

Good point. Do you have any actual use-cases in mind?

Dec 27 2017, 6:36 PM · Krita

Nov 28 2017

victorw committed R37:a0624f31a0cb: Fix compile error in KisPPMImport::convert() (authored by victorw).
Fix compile error in KisPPMImport::convert()
Nov 28 2017, 9:35 PM

Nov 10 2017

victorw committed R37:114be49b9413: Fix softproofing compilation errors for Qt < 5.8 (authored by victorw).
Fix softproofing compilation errors for Qt < 5.8
Nov 10 2017, 11:25 PM

Nov 3 2017

victorw committed R37:e152c2ea7e89: Merge branch 'master' into victorw/T6774-logging-improvements (authored by victorw).
Merge branch 'master' into victorw/T6774-logging-improvements
Nov 3 2017, 5:58 PM
victorw committed R37:f4ea9c24bff4: Remove Python log handler setup debug print (authored by victorw).
Remove Python log handler setup debug print
Nov 3 2017, 5:55 PM

Sep 20 2017

victorw added a comment to D7878: Extend the bugzilla/irc gateway with two new options.

The usage of try/except blocks in this case is deliberate and intentional to ensure that any errors in a given entry don't break the script entirely but just cause that entry to fail.

Sep 20 2017, 7:16 PM

Sep 19 2017

victorw added inline comments to D7878: Extend the bugzilla/irc gateway with two new options.
Sep 19 2017, 9:58 PM

Aug 27 2017

victorw added a comment to D7441: Add Win8+ "Pointer Input Message" support.

Fixed the incorrect localPos calculation.

New build: https://drive.google.com/open?id=0B1i7Q5Isuy2JeTJpczNvRHV4MlE

Aug 27 2017, 7:09 PM · Krita: Next Features
victorw added a comment to D7441: Add Win8+ "Pointer Input Message" support.

I tested this on my Surface Pro 2 (Wacom) to see if there were any regressions. For me it looks like the Win8+ "Pointer Input Message" produces jitter compared to the wintab version. I've attached an image of two reasonably straight lines, drawn in two instances of the 4.0-prealpha_winink build. The first one with the Win8+ Pointer Input Message support enabled, the second without. I merged the images to show the difference (top: "winink", bottom: "wintab"):

Aug 27 2017, 4:31 PM · Krita: Next Features

Aug 18 2017

victorw committed R37:687ebc8f5269: Added copyright notice (authored by victorw).
Added copyright notice
Aug 18 2017, 9:07 PM
victorw committed R37:3df54afc87a8: Added initial C++ hooks for Python logging (authored by victorw).
Added initial C++ hooks for Python logging
Aug 18 2017, 9:00 PM

Aug 13 2017

victorw created T6774: Improve logging.
Aug 13 2017, 4:27 PM · Krita

Aug 5 2017

abrahams awarded D7121: Refactored the "Hello" Python script and added excessive documentation a Evil Spooky Haunted Tree token.
Aug 5 2017, 3:03 AM · Krita

Aug 4 2017

victorw committed R37:a84b561e5997: Add more information to logs when QLibrary::load() fails. (authored by victorw).
Add more information to logs when QLibrary::load() fails.
Aug 4 2017, 10:31 PM
victorw committed R37:14c4f748c4b5: Fixed newlines in Python script error tooltip (authored by victorw).
Fixed newlines in Python script error tooltip
Aug 4 2017, 7:26 PM

Aug 3 2017

victorw committed R37:80af6093bad5: Refactored and documented the "hello" Python script example (authored by victorw).
Refactored and documented the "hello" Python script example
Aug 3 2017, 10:06 PM
victorw added inline comments to D7121: Refactored the "Hello" Python script and added excessive documentation.
Aug 3 2017, 9:59 PM · Krita
victorw created D7121: Refactored the "Hello" Python script and added excessive documentation.
Aug 3 2017, 8:28 PM · Krita

Jul 25 2017

victorw committed R37:64188779077f: Ran "autopep8 --ignore=E501,E241" on all Python files. (authored by victorw).
Ran "autopep8 --ignore=E501,E241" on all Python files.
Jul 25 2017, 6:50 AM
victorw added a commit to T6588: Define Python scripting guidelines: R37:64188779077f: Ran "autopep8 --ignore=E501,E241" on all Python files..
Jul 25 2017, 6:50 AM · Krita

Jul 24 2017

victorw added a comment to D6891: Added proposed Python guidelines to Krita.

I ran autopep8.py on the entire code base as an experiment, and there is one set of PEP8 rules which I'm a bit torn about: The spacing after commas and operators. If it's followed, then

Jul 24 2017, 11:26 PM
victorw created D6891: Added proposed Python guidelines to Krita.
Jul 24 2017, 10:42 PM
victorw created T6588: Define Python scripting guidelines.
Jul 24 2017, 10:15 PM · Krita

Jul 22 2017

victorw updated the task description for T6560: Optimize KoID.
Jul 22 2017, 9:42 AM · Krita
victorw created T6560: Optimize KoID.
Jul 22 2017, 9:40 AM · Krita

Jul 19 2017

victorw committed R37:1f2031628b64: Added optional success state bool to KoColor::fromXML() to improve handling of… (authored by victorw).
Added optional success state bool to KoColor::fromXML() to improve handling of…
Jul 19 2017, 2:34 PM

Jul 17 2017

victorw added a commit to T6475: Krita 3.2 Release main task.: R37:2c28382d84cc: Remove incorrect assert in KisVisualColorSelector::slotRebuildSelectors().
Jul 17 2017, 2:35 PM · Krita: Releases
victorw added a task to R37:2c28382d84cc: Remove incorrect assert in KisVisualColorSelector::slotRebuildSelectors(): T6475: Krita 3.2 Release main task..
Jul 17 2017, 2:35 PM
victorw committed R37:2c28382d84cc: Remove incorrect assert in KisVisualColorSelector::slotRebuildSelectors() (authored by victorw).
Remove incorrect assert in KisVisualColorSelector::slotRebuildSelectors()
Jul 17 2017, 2:33 PM
victorw added a commit to T6475: Krita 3.2 Release main task.: R37:9c969b60fa29: Respect transparencyFillcolor configuration when exporting to jpeg or png….
Jul 17 2017, 1:22 PM · Krita: Releases
victorw added a task to R37:9c969b60fa29: Respect transparencyFillcolor configuration when exporting to jpeg or png…: T6475: Krita 3.2 Release main task..
Jul 17 2017, 1:21 PM
victorw committed R37:9c969b60fa29: Respect transparencyFillcolor configuration when exporting to jpeg or png… (authored by victorw).
Respect transparencyFillcolor configuration when exporting to jpeg or png…
Jul 17 2017, 1:10 PM

Jul 16 2017

victorw committed R37:6214f5effcb0: Fix crash in KisPaletteView::trySelectClosestColor() if no color set has been… (authored by victorw).
Fix crash in KisPaletteView::trySelectClosestColor() if no color set has been…
Jul 16 2017, 8:13 PM
victorw committed R37:b22f38b67309: Heightmap: Added import and export support for raw 32bit float heightmaps (*. (authored by victorw).
Heightmap: Added import and export support for raw 32bit float heightmaps (*.
Jul 16 2017, 10:56 AM

Jul 15 2017

victorw added a comment to T6475: Krita 3.2 Release main task..

You may wish to backport the following commits from master. They should all merge cleanly in the following order:

Jul 15 2017, 2:13 PM · Krita: Releases
victorw committed R37:8b56d9d1a25f: Use same fallback defaults for transparencyFillcolor everywhere (authored by victorw).
Use same fallback defaults for transparencyFillcolor everywhere
Jul 15 2017, 2:10 PM
victorw committed R37:c8ca1c0fd1a1: JPEG Export: Respect transparencyFillcolor configuration (authored by victorw).
JPEG Export: Respect transparencyFillcolor configuration
Jul 15 2017, 1:38 PM
victorw committed R37:864348016a5f: PNG Export: Respect transparencyFillcolor configuration when exporting without… (authored by victorw).
PNG Export: Respect transparencyFillcolor configuration when exporting without…
Jul 15 2017, 1:10 PM
victorw committed R37:bebbe66cce72: PNG Export: Don't leave the alpha channel checkbox checked if it's disabled… (authored by victorw).
PNG Export: Don't leave the alpha channel checkbox checked if it's disabled…
Jul 15 2017, 12:13 PM

Jul 14 2017

victorw committed R37:b4b9021616ed: Add support for non-square heightmap import/export and various related… (authored by victorw).
Add support for non-square heightmap import/export and various related…
Jul 14 2017, 7:45 PM
victorw closed D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs. by committing R37:b4b9021616ed: Add support for non-square heightmap import/export and various related….
Jul 14 2017, 7:45 PM

Jul 9 2017

victorw committed R37:377027476ca6: * Don't crash and default to "All supported files" when passing an empty… (authored by victorw).
* Don't crash and default to "All supported files" when passing an empty…
Jul 9 2017, 3:29 PM

Jul 8 2017

victorw added inline comments to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
Jul 8 2017, 9:06 PM
victorw updated the diff for D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
  • Added importConfiguration helper functions to KisConfig that mimics exportConfiguration, but with a different tag
  • Remember endianness for import and export heightmap dialog separately, per mime type
  • Use KisSequentialConstIterator when exporting data
Jul 8 2017, 8:47 PM

Jul 6 2017

victorw added inline comments to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
Jul 6 2017, 10:08 PM
victorw added a comment to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..

The patch looks fine. Though I'd suggest two small fixes to make UIX more obvious:

  1. When importing and exporting set endianness to the default endianness of the currently running system. Or at least save the last used value and reuse it next time. Right now the UIX is not very smooth:
    1. User saves .r16 map in big-endian mode
    2. User opens the file, the dialog suggests him that the file is little-endian (not nice, but okay)
    3. User opens the same file again, and the dialog suggests him that the file is little-endian again (already not okay, can make people furious :) )
Jul 6 2017, 9:16 PM

Jul 4 2017

victorw added a comment to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..

Updated screenshot of import dialog:

Jul 4 2017, 9:59 PM
victorw updated the diff for D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
  • Removed references of PC and Mac from the UI.
  • Added standard file diff unit tests (disabled because the function is broken?)
Jul 4 2017, 9:55 PM

Jul 3 2017

victorw added a comment to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
In D6460#121238, @rempt wrote:

Can the endianness still really be described by PC vs Mac? Mac have been x86 for ages now.

Jul 3 2017, 6:58 PM

Jul 1 2017

victorw added a comment to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..

Screenshot of the new import dialog:

Jul 1 2017, 3:47 PM
victorw added inline comments to D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
Jul 1 2017, 3:45 PM
victorw created D6460: Add support for non-square heightmaps. Improve import dialog. Fix various import export bugs..
Jul 1 2017, 3:35 PM

Jun 26 2017

victorw committed R37:bfc1a2f21856: Fix two warnings pointing out an uninitialized variable and a bad if-statement… (authored by victorw).
Fix two warnings pointing out an uninitialized variable and a bad if-statement…
Jun 26 2017, 7:47 PM

Jun 25 2017

victorw committed R37:a19026847750: Fix uninitialized value in positionSelector of DefaultToolGeometryWidget. It… (authored by victorw).
Fix uninitialized value in positionSelector of DefaultToolGeometryWidget. It…
Jun 25 2017, 3:57 PM
victorw committed R37:0363df89516e: Revert "Merge branch 'master' of git://anongit.kde.org/krita" (authored by victorw).
Revert "Merge branch 'master' of git://anongit.kde.org/krita"
Jun 25 2017, 2:24 PM
victorw added a reverting change for R37:c2025574aaf8: Merge branch 'master' of git://anongit.kde.org/krita: R37:0363df89516e: Revert "Merge branch 'master' of git://anongit.kde.org/krita".
Jun 25 2017, 2:24 PM
victorw committed R37:c2025574aaf8: Merge branch 'master' of git://anongit.kde.org/krita (authored by victorw).
Merge branch 'master' of git://anongit.kde.org/krita
Jun 25 2017, 2:10 PM
victorw committed R37:67aa7b805149: Fix crash and safe assert when creating two documents in a row, due to bad… (authored by victorw).
Fix crash and safe assert when creating two documents in a row, due to bad…
Jun 25 2017, 2:10 PM

Jun 22 2017

victorw committed R37:fe557fb538cc: Show the closed hand cursor while panning using global shortcuts (authored by victorw).
Show the closed hand cursor while panning using global shortcuts
Jun 22 2017, 9:05 PM

Jun 20 2017

victorw committed R37:c0cfa5cc56fc: Suppress unused variables warning (authored by victorw).
Suppress unused variables warning
Jun 20 2017, 8:15 PM