jhoolmans (Jeroen Hoolmans)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 6 2018, 6:26 PM (71 w, 6 d)
Availability
Available

Recent Activity

Feb 8 2019

jhoolmans added a comment to D18729: Fix for OpenEXR erroneous semi-transparent pixels.

32-bit version of the CandleGlass exr.

Feb 8 2019, 11:21 AM · Krita
jhoolmans added a comment to D18729: Fix for OpenEXR erroneous semi-transparent pixels.

Even though it's hard to see, you can see clipping in those areas. Left one is master, right one is with this patch.

Feb 8 2019, 10:20 AM · Krita
jhoolmans added a comment to D18729: Fix for OpenEXR erroneous semi-transparent pixels.

The blue part is a bug in the alpha value becoming zero. I have to double check.
With the current master there is still the issue of modified alpha values which is noticeable with soft shadows and shouldn't happen.
I agree that EXR are some sort of light emission, it's also raw data that should not be modified in any way.
What the patch is doing here is basically a max(epsilon, alpha) as mentioned in here http://www.openexr.com/documentation/TechnicalIntroduction.pdf

Feb 8 2019, 9:51 AM · Krita

Feb 4 2019

jhoolmans requested review of D18729: Fix for OpenEXR erroneous semi-transparent pixels.
Feb 4 2019, 4:19 PM · Krita

Feb 1 2019

jhoolmans committed R37:d7d67085fb9a: cleanup alpha changed message. (authored by jhoolmans).
cleanup alpha changed message.
Feb 1 2019, 7:40 PM
jhoolmans committed R37:67efd59c933a: exr: simplified unpremult alpha code. (authored by jhoolmans).
exr: simplified unpremult alpha code.
Feb 1 2019, 7:40 PM
jhoolmans committed R37:bd382d19b44b: cleanup alpha changed message. (authored by jhoolmans).
cleanup alpha changed message.
Feb 1 2019, 2:50 PM
jhoolmans committed R37:a3d41d4d4dd0: exr: simplified unpremult alpha code. (authored by jhoolmans).
exr: simplified unpremult alpha code.
Feb 1 2019, 2:50 PM

May 20 2018

jhoolmans committed R37:c94a09030c86: OpenEXR loading performance optimizations. (authored by jhoolmans).
OpenEXR loading performance optimizations.
May 20 2018, 7:23 PM
jhoolmans closed D12972: OpenEXR Loading Performance Improvements.
May 20 2018, 7:23 PM · Krita
jhoolmans updated the diff for D12972: OpenEXR Loading Performance Improvements.

You're right, didn't crash this time. Must've done something wrong.

May 20 2018, 10:13 AM · Krita

May 19 2018

jhoolmans updated the diff for D12972: OpenEXR Loading Performance Improvements.
May 19 2018, 9:42 PM · Krita
jhoolmans committed R37:ad0ceaa56228: Ported EXR iterator to the KisSequentialIterator. (authored by jhoolmans).
Ported EXR iterator to the KisSequentialIterator.
May 19 2018, 9:13 PM
jhoolmans added inline comments to D12972: OpenEXR Loading Performance Improvements.
May 19 2018, 9:10 PM · Krita
jhoolmans added a comment to D12972: OpenEXR Loading Performance Improvements.

Ah that sounds great. Maybe I can do the same with saving also.

May 19 2018, 9:24 AM · Krita

May 18 2018

jhoolmans requested review of D12972: OpenEXR Loading Performance Improvements.
May 18 2018, 9:29 PM · Krita
jhoolmans committed R37:b5dcab4ffd35: Fixes a crash when saving exr files (authored by jhoolmans).
Fixes a crash when saving exr files
May 18 2018, 8:48 PM

May 17 2018

jhoolmans committed R37:0b44f43d92f3: Moved unmultiplyAlpha warning outside of the loop. (authored by jhoolmans).
Moved unmultiplyAlpha warning outside of the loop.
May 17 2018, 9:43 PM
jhoolmans committed R37:90271067ba81: Loaded exr files now take displayWindows into account. (authored by jhoolmans).
Loaded exr files now take displayWindows into account.
May 17 2018, 8:58 PM

May 16 2018

jhoolmans committed R37:5e45508d79a2: restructured decode1 and decode4 to benefit from threading. (authored by jhoolmans).
restructured decode1 and decode4 to benefit from threading.
May 16 2018, 10:09 PM
jhoolmans added a member for Krita: Abyss: jhoolmans.
May 16 2018, 3:26 PM
jhoolmans created T8728: White balancing.
May 16 2018, 3:21 PM · Krita
jhoolmans committed R37:6509644e3cb8: Added support to compile with Python2.7 on Linux (authored by jhoolmans).
Added support to compile with Python2.7 on Linux
May 16 2018, 2:58 PM
jhoolmans closed D12838: Optional Python 2 Support for Krita.
May 16 2018, 2:58 PM · Krita

May 15 2018

jhoolmans updated the diff for D12838: Optional Python 2 Support for Krita.

For now I've disabled the option for Windows.
This needs some more investigation.

May 15 2018, 6:45 PM · Krita
jhoolmans added a comment to D12838: Optional Python 2 Support for Krita.

I agree, I haven't tested this with Windows and assumed this would be a solution since Py_SetPath isn't available in Python 2. Only the PySys_SetPath.
We do have a big chunk of machines on Windows (sadly), that would have to fall back to Photoshop, But that's fine for now.

May 15 2018, 9:22 AM · Krita

May 12 2018

woltherav awarded D12838: Optional Python 2 Support for Krita a Like token.
May 12 2018, 4:35 PM · Krita
jhoolmans requested review of D12838: Optional Python 2 Support for Krita.
May 12 2018, 4:34 PM · Krita

May 7 2018

jhoolmans requested review of D12750: Renamed Document::setBackGroundColor to setBackgroundColor.
May 7 2018, 9:19 PM · Krita

May 6 2018

jhoolmans added a project to D12729: Added an API method to get and set the document background color: Krita.
May 6 2018, 6:58 PM · Krita
jhoolmans requested review of D12729: Added an API method to get and set the document background color.
May 6 2018, 6:44 PM · Krita
jhoolmans added a watcher for Krita: jhoolmans.
May 6 2018, 6:27 PM