alvinhochun (Alvin Wong)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2016, 12:39 PM (148 w, 1 d)
Availability
Available

Recent Activity

Sat, Apr 20

alvinhochun committed R37:c84dc6644114: Merge branch 'alvin/fractional-dpi-scaling' into 'master' (authored by alvinhochun).
Merge branch 'alvin/fractional-dpi-scaling' into 'master'
Sat, Apr 20, 2:59 PM
alvinhochun committed R37:16929f11eaed: Use RoundPreferFloor when fractional scaling is disabled (authored by alvinhochun).
Use RoundPreferFloor when fractional scaling is disabled
Sat, Apr 20, 2:59 PM
alvinhochun committed R37:887e9fd4118f: Add option to toggle fractional DPI scaling (authored by alvinhochun).
Add option to toggle fractional DPI scaling
Sat, Apr 20, 2:59 PM
alvinhochun committed R37:a05da09781a5: Add ext_qt patch for Windows to support fractional DPI scaling (authored by alvinhochun).
Add ext_qt patch for Windows to support fractional DPI scaling
Sat, Apr 20, 2:59 PM
alvinhochun committed R37:b4dcb33a677c: Add ext_qt patch to fix moving window between screens (authored by alvinhochun).
Add ext_qt patch to fix moving window between screens
Sat, Apr 20, 2:59 PM

Fri, Apr 19

alvinhochun committed R37:6885f97f567f: Fix wrong dialog being used with Touch Docker (authored by alvinhochun).
Fix wrong dialog being used with Touch Docker
Fri, Apr 19, 4:49 AM
alvinhochun abandoned D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Fri, Apr 19, 2:54 AM · Krita
alvinhochun updated the summary of D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Fri, Apr 19, 2:53 AM · Krita
alvinhochun committed R37:8b885b2d89ad: Add ext_qt patch for Windows to support fractional DPI scaling (authored by alvinhochun).
Add ext_qt patch for Windows to support fractional DPI scaling
Fri, Apr 19, 2:48 AM
alvinhochun committed R37:776e2a54fcf7: Add ext_qt patch to fix moving window between screens (authored by alvinhochun).
Add ext_qt patch to fix moving window between screens
Fri, Apr 19, 2:48 AM
alvinhochun closed T10765: Make canvas render correctly under fractional scaling, a subtask of T2299: Make the canvas behave in HiDPI mode, as Resolved.
Fri, Apr 19, 2:35 AM · Krita: Next Features
alvinhochun closed T10765: Make canvas render correctly under fractional scaling as Resolved.
Fri, Apr 19, 2:35 AM · Krita: Next Features

Thu, Apr 18

alvinhochun added 1 commit(s) for D20657: Fix fullscreen mode on Windows with OpenGL: R37:012d64083350: Fix patch for Windows fullscreen mode hack.
Thu, Apr 18, 5:05 PM · Krita
alvinhochun added an edge to R37:012d64083350: Fix patch for Windows fullscreen mode hack: D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 5:05 PM
alvinhochun committed R37:012d64083350: Fix patch for Windows fullscreen mode hack (authored by alvinhochun).
Fix patch for Windows fullscreen mode hack
Thu, Apr 18, 5:03 PM
alvinhochun requested review of D20666: Add an FAQ item for fullscreen mode workaround on Windows.
Thu, Apr 18, 2:45 PM · Krita: Manual
alvinhochun updated the diff for D20607: Add ext_qt patch for Windows to support fractional DPI scaling.

Updated patch for master

Thu, Apr 18, 1:45 PM · Krita
alvinhochun committed R37:b5800a8dde0f: Add ext_qt hack to allow windepolyqt to package build with debug info (authored by alvinhochun).
Add ext_qt hack to allow windepolyqt to package build with debug info
Thu, Apr 18, 12:39 PM
alvinhochun committed R37:e83e87794bdd: Fix fullscreen mode on Windows with OpenGL (authored by alvinhochun).
Fix fullscreen mode on Windows with OpenGL
Thu, Apr 18, 12:33 PM
alvinhochun closed D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 12:33 PM · Krita
alvinhochun updated the diff for D20657: Fix fullscreen mode on Windows with OpenGL.

Upload the correct patch

Thu, Apr 18, 12:21 PM · Krita
alvinhochun updated the summary of D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 12:09 PM · Krita
alvinhochun updated the diff for D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 11:07 AM · Krita
alvinhochun planned changes to D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 10:52 AM · Krita
alvinhochun requested review of D20657: Fix fullscreen mode on Windows with OpenGL.
Thu, Apr 18, 10:49 AM · Krita

Wed, Apr 17

alvinhochun added a comment to D20607: Add ext_qt patch for Windows to support fractional DPI scaling.

The question is: should we change the default behaviour to RoundPreferFloor instead of trying to keep the old behaviour by using Round? I feel like RoundPreferFloor would be more useful to users who doesn't want to enable fractional scaling (but that will probably be the minority if we can enable fractional scaling by default).

Wed, Apr 17, 5:35 PM · Krita

Tue, Apr 16

alvinhochun requested review of D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Tue, Apr 16, 5:32 PM · Krita
alvinhochun committed R37:f0f35797d2af: ext_vc: Make it not rely on a fixed install path (authored by alvinhochun).
ext_vc: Make it not rely on a fixed install path
Tue, Apr 16, 8:34 AM

Mon, Apr 15

alvinhochun committed R37:1fdda43f9b68: Fix OpenGL canvas under fractional DPI scaling (authored by alvinhochun).
Fix OpenGL canvas under fractional DPI scaling
Mon, Apr 15, 5:14 PM
alvinhochun closed D20097: Fix OpenGL canvas under fractional DPI scaling.
Mon, Apr 15, 5:14 PM · Krita

Sun, Apr 14

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.

Moved some code from the converter to the canvas.

Sun, Apr 14, 9:53 AM · Krita

Sat, Apr 13

alvinhochun updated the summary of D20097: Fix OpenGL canvas under fractional DPI scaling.
Sat, Apr 13, 11:02 AM · Krita

Fri, Apr 12

alvinhochun updated the summary of D20097: Fix OpenGL canvas under fractional DPI scaling.
Fri, Apr 12, 5:39 PM · Krita
alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.

Speaking truly, I don't understand, what bug this huge refactoring is intended to fix. Please list the problems you are trying to resolve.

Right now the patch introduces at lease two huge regressions:

  1. Zoom with mouse wheel and Ctrl+Space centers around wrong point.
  2. Rotation with Shift+Space center around wrong point and drifts from place to place (some rounding issues).

    The main point, I don't see what problem we are trying to solve?
Fri, Apr 12, 5:33 PM · Krita

Wed, Apr 10

alvinhochun committed R37:d627fade1d0c: build.cmd: Add option to launch cmd prompt with build env (authored by alvinhochun).
build.cmd: Add option to launch cmd prompt with build env
Wed, Apr 10, 3:36 PM
alvinhochun committed R37:f841ad904cc7: build.cmd: Remove extra echo command (authored by alvinhochun).
build.cmd: Remove extra echo command
Wed, Apr 10, 2:39 PM
alvinhochun added a comment to D8543: Sharpness brush option rework.

Could not update this revission as it is not mine. Im continuing the work on this here https://phabricator.kde.org/D20423

  • Softness Controls alpha borders
  • Strenght controls how soon dark pixels clip to black
  • Pixel brushes work as normal

    Missing
  • save settings doesn't work
Wed, Apr 10, 6:15 AM · Krita

Tue, Apr 9

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
Tue, Apr 9, 5:50 PM · Krita

Mon, Apr 8

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
Mon, Apr 8, 5:38 PM · Krita

Sat, Apr 6

alvinhochun updated the task description for T10765: Make canvas render correctly under fractional scaling.
Sat, Apr 6, 8:35 AM · Krita: Next Features
alvinhochun added a revision to T10765: Make canvas render correctly under fractional scaling: D20097: Fix OpenGL canvas under fractional DPI scaling.
Sat, Apr 6, 7:09 AM · Krita: Next Features
alvinhochun added a task to D20097: Fix OpenGL canvas under fractional DPI scaling: T10765: Make canvas render correctly under fractional scaling.
Sat, Apr 6, 7:09 AM · Krita
alvinhochun triaged T10765: Make canvas render correctly under fractional scaling as Normal priority.
Sat, Apr 6, 7:09 AM · Krita: Next Features

Fri, Apr 5

alvinhochun added inline comments to D20097: Fix OpenGL canvas under fractional DPI scaling.
Fri, Apr 5, 5:44 PM · Krita
alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
  • Starting to convert more stuff to use device pixel
  • Beginning to differentiate between device pixel and logical pixels
Fri, Apr 5, 5:26 PM · Krita

Thu, Apr 4

alvinhochun committed R37:f3858d112d54: Make Windows build create thin archives when linking (authored by alvinhochun).
Make Windows build create thin archives when linking
Thu, Apr 4, 3:35 PM

Tue, Apr 2

alvinhochun committed R37:e59ed34c0ced: Win: Add pre-built OpenSSL as dep (authored by alvinhochun).
Win: Add pre-built OpenSSL as dep
Tue, Apr 2, 7:17 PM
alvinhochun closed D20206: Add pre-built OpenSSL for Windows.
Tue, Apr 2, 7:17 PM · Krita
alvinhochun updated the diff for D20206: Add pre-built OpenSSL for Windows.

Add comments and updated 3rdparty/README.md

Tue, Apr 2, 4:07 PM · Krita
alvinhochun requested review of D20206: Add pre-built OpenSSL for Windows.
Tue, Apr 2, 3:52 PM · Krita
alvinhochun committed R37:5b0dcbc15892: ext_qt: Use external zlib/libpng/libjpeg (authored by alvinhochun).
ext_qt: Use external zlib/libpng/libjpeg
Tue, Apr 2, 2:38 PM
alvinhochun committed R37:95979cc09fb6: Improve 3rdparty/README.md (authored by alvinhochun).
Improve 3rdparty/README.md
Tue, Apr 2, 9:22 AM
alvinhochun committed R37:9e1ada220418: Windows: Simplify use of ext_gettext target (authored by alvinhochun).
Windows: Simplify use of ext_gettext target
Tue, Apr 2, 9:03 AM
alvinhochun committed R37:eff0c7010ac3: Fix wrong DPI when moving window across screens (authored by alvinhochun).
Fix wrong DPI when moving window across screens
Tue, Apr 2, 8:19 AM
alvinhochun closed D20171: Fix wrong DPI when moving window across screens.
Tue, Apr 2, 8:19 AM · Krita

Mon, Apr 1

alvinhochun added a task to D20171: Fix wrong DPI when moving window across screens: T2299: Make the canvas behave in HiDPI mode.
Mon, Apr 1, 3:44 PM · Krita
alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20171: Fix wrong DPI when moving window across screens.
Mon, Apr 1, 3:44 PM · Krita: Next Features
alvinhochun requested review of D20171: Fix wrong DPI when moving window across screens.
Mon, Apr 1, 3:30 PM · Krita

Sun, Mar 31

alvinhochun committed R37:c06939163973: Fix gettext static binary download (authored by alvinhochun).
Fix gettext static binary download
Sun, Mar 31, 5:09 PM
alvinhochun committed R37:7fcbda062fe4: Fix Windows build script targets (authored by alvinhochun).
Fix Windows build script targets
Sun, Mar 31, 3:27 PM

Thu, Mar 28

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.
Thu, Mar 28, 6:11 PM · Krita: Next Features
alvinhochun added a task to D20097: Fix OpenGL canvas under fractional DPI scaling: T2299: Make the canvas behave in HiDPI mode.
Thu, Mar 28, 5:41 PM · Krita
alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20097: Fix OpenGL canvas under fractional DPI scaling.
Thu, Mar 28, 5:41 PM · Krita: Next Features
alvinhochun requested review of D20097: Fix OpenGL canvas under fractional DPI scaling.
Thu, Mar 28, 5:41 PM · Krita

Wed, Mar 27

alvinhochun committed R37:8f022ec33007: Fix splash screen for some high DPI setup (authored by alvinhochun).
Fix splash screen for some high DPI setup
Wed, Mar 27, 8:06 PM

Tue, Mar 26

alvinhochun created P356 (An Untitled Masterwork) in the S1 KDE Community space.
Tue, Mar 26, 12:48 PM
alvinhochun created P355 stack2line.py in the S1 KDE Community space.
Tue, Mar 26, 12:21 PM · Krita
alvinhochun committed R37:b67e02041a28: Fix Intel OpenGL driver detection for newer drivers (authored by alvinhochun).
Fix Intel OpenGL driver detection for newer drivers
Tue, Mar 26, 9:58 AM
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

That bug should be fixed with R37:331beffd5332.

Tue, Mar 26, 9:34 AM · Krita
alvinhochun committed R37:331beffd5332: Fix Python scripting broken by new pyqt and sip (authored by alvinhochun).
Fix Python scripting broken by new pyqt and sip
Tue, Mar 26, 9:30 AM
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

See https://bugs.kde.org/show_bug.cgi?id=405796#c4

Tue, Mar 26, 8:08 AM · Krita
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

After last night's test, I can say this is not the fix to the pyqt situation on Windows.

Tue, Mar 26, 6:52 AM · Krita

Mar 16 2019

alvinhochun added a comment to D19807: Fix formatting and minor typos.

I'm a little skeptical about 'an hsv filter' as that would be verbalized as 'an hatchesvee filter', and we also talk about 'a human', 'a hatchet', 'a house', 'a hamlet' and not 'an human', 'an hatchet', 'an house'.

@rempt do you have an idea?

The English Wikipedia uses "an":

https://en.wikipedia.org/wiki/HSL_and_HSV#From_HSV

I think it's because it begins with /eɪtʃ/.

Mar 16 2019, 8:14 PM · Krita: Manual

Mar 14 2019

alvinhochun committed R37:5c108eac4ef5: Remove openssl requirement in ext_qt (authored by alvinhochun).
Remove openssl requirement in ext_qt
Mar 14 2019, 1:40 PM
alvinhochun added a reverting change for R37:0fc1a756ba73: Add openssl build step on OSX and windows: R37:5c108eac4ef5: Remove openssl requirement in ext_qt.
Mar 14 2019, 1:40 PM
alvinhochun added a comment to D15585: Add openssl download and build step to krita.

I see that you've already committed this but unfortunately it is just broken on Windows. Running config definitely isn't how one would be able to build openssl on Windows.

Mar 14 2019, 1:23 PM · Krita
alvinhochun added a comment to D19726: Setup for android(arm) build.

I agree you should make a separate define for use with OpenGL-ES-only environments. OpenGL ES is not limited to Android after all.

Mar 14 2019, 9:53 AM · Krita
alvinhochun added a comment to D18710: Update Windows installation methods.
  • Should I still remove Chocolatey, if it's very similar to Homebrew on Mac?
Mar 14 2019, 8:28 AM · Krita: Manual

Mar 7 2019

alvinhochun added a comment to D19592: Added Support For libheif in 3rdparty.

Though having the CMakeLists.txt doesn't mean they really support CMake build and probably nobody knows what would happen if you try to use it with the mingw-w64 native toolchain...

Mar 7 2019, 2:08 PM · Krita
alvinhochun added a comment to D19592: Added Support For libheif in 3rdparty.

Both libraries seems to contain a CMakeLists.txt file. If they do support CMake there is no reason to not prefer it over using the autotools build.

Mar 7 2019, 2:00 PM · Krita

Feb 16 2019

alvinhochun created P322 Ugly WIP rust code in the S1 KDE Community space.
Feb 16 2019, 6:59 PM · Krita

Feb 11 2019

alvinhochun added a comment to D18692: Fix resource locations in FAQ.

Does this make sense?

Feb 11 2019, 2:53 PM · Krita: Manual

Feb 4 2019

alvinhochun added a comment to D18710: Update Windows installation methods.

I would like to mention the Shell extension for KRA previews here. I notice that my Store-version--created files have a preview, and my other (older) files don't.

Is the shell extension bundled with the Store version, or are previews automatically saved for it? I'm happy to update the diff appropriately.

Feb 4 2019, 9:39 AM · Krita: Manual

Feb 3 2019

alvinhochun added a comment to D18692: Fix resource locations in FAQ.

See https://docs.microsoft.com/en-us/windows/uwp/porting/desktop-to-uwp-behind-the-scenes#file-system

Feb 3 2019, 6:10 PM · Krita: Manual

Jan 23 2019

alvinhochun added a comment to D18407: Port krita to use Quazip instead of KArchive, to support Zip64.
  • Can it be made to save as Zip64 only when the file doesn't fit in a typical zip file?

Not easily: we cannot predict exactly when a file will become bigger than 4 GiB from the size of the image in memory.

Jan 23 2019, 3:09 PM · Krita

Jan 21 2019

alvinhochun added a comment to D18407: Port krita to use Quazip instead of KArchive, to support Zip64.

A few things:

Jan 21 2019, 1:24 PM · Krita

Dec 13 2018

alvinhochun committed R37:b763b61ec551: Fix broken CMake command line (authored by alvinhochun).
Fix broken CMake command line
Dec 13 2018, 4:04 PM

Oct 17 2018

alvinhochun reopened T2299: Make the canvas behave in HiDPI mode as "Open".

@dkazakov I see that you've changed the code to use devicePixelRatioF. I can see that the canvas now attempts to render at 100% device pixel size.

Oct 17 2018, 8:41 AM · Krita: Next Features
alvinhochun added a task to R37:046ce7128a7e: Fix fractional display scale factor: T2299: Make the canvas behave in HiDPI mode.
Oct 17 2018, 7:47 AM
alvinhochun added a commit to T2299: Make the canvas behave in HiDPI mode: R37:046ce7128a7e: Fix fractional display scale factor.
Oct 17 2018, 7:47 AM · Krita: Next Features

Oct 14 2018

alvinhochun added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

With cases like this it's usually preferred to do feature detection instead of checking for specific versions.

Oct 14 2018, 9:12 AM · Krita

Oct 11 2018

alvinhochun added a comment to D16128: Add a rotate slider to the overview docker..

Krita lacks options to rotate the canvas

Oct 11 2018, 2:39 PM · Krita

Oct 10 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

One more issue: The fix seems to have used the integer version of devicePixelRatio somewhere instead of the floating point devicePixelRatioF. This is from my observation forcing a 1.5x scaling on Windows. I haven't checked the code. Even though Qt now rounds the scale factor to nearest integer on Windows, we should assume that real fractional scaling support will be added in the future. In fact the then-in-progress task https://bugreports.qt.io/browse/QTBUG-53022 is exactly for this. (It might even be already supported on KDE, but I can't confirm.) So please fix it to use the floating point devicePixelRatio.

Oct 10 2018, 4:38 PM · Krita: Next Features
alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

@dkazakov Thanks for the partial fix. I've done some testing on Windows with krita-nightly-x64-v4.1.3.1-239-ge64348e693, so here's my observations/findings:

Oct 10 2018, 4:38 PM · Krita: Next Features

Oct 5 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

I'm not sure that it really happens this way.

Feel free to check.

This fixes one of the two issues that will make it less blurry https://phabricator.kde.org/P263

Oct 5 2018, 2:39 AM · Krita: Next Features

Oct 4 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

Hi, @davidedmundson!

I have just tried to reproduce the problem again, and I do still reproduce it with Qt 5.9.1. I will try to search for exact lines in Qt's code, but I'm not sure I will manage to finish it today. Steps to reproduce:

  1. Set GUI scaling in windows to 150-200%
  2. Start Krita
  3. Go to Settings->General->Enable HiDPI support (it basically activates GUI scaling). Without this option, openGL canvas behaves exactly like you explain, that is, renders inRestart hardware pixels. But after activating this option, scaling starts.
  4. Restart Krita
  5. Create 500x200 image
  6. Activate "Use same aspect as pixels" box at the bottom-right corner of the window
  7. Press '1' to set 100% zoom
  8. BUG: See that the image has actually size of 1000x400 physical pixels. And Krita does not pass any extra scaling to openGL. It paints just in logical pixels.
Oct 4 2018, 5:31 PM · Krita: Next Features

Sep 27 2018

alvinhochun added a comment to D15755: Global Kinetic Scrolling.

Actually, only right-click press itself is for opening context menus
and some context-sensitive actions. I don't think right-click drag is
used for anything, or is it? Using right-click drag for scrolling is
not so implausible.

Ok. I was thinking that context menus often pop up on mouse down,
which would interfere with the scrolling. And since right-click release events
often trigger menu selections (does that happen on Windows too?
I can't remember off the top of my head) it might be prone to accidents.

Of course, all that stuff could be worked around and there's no harm in testing it!

Sep 27 2018, 9:16 AM · Krita

Sep 26 2018

alvinhochun added a comment to D15755: Global Kinetic Scrolling.

Alvin, is your issue that the middle mouse button is used by default? Because there are other scroll methods available already in the existing code(finger scroll and mouseclick scroll). I've been using the latter on my system.

Sep 26 2018, 1:08 PM · Krita
alvinhochun added a comment to D15755: Global Kinetic Scrolling.

This is a bit of a misunderstanding, I think.

Scroll bars are still enabled by default, as they probably should be.
It's merely that the checkbox says "Hide Scrollbars" now, and that users have to opt into hiding them.
It's purely a semantic change, the users opts into "hiding" the scrollbars instead of opting out of "showing" them.

Sep 26 2018, 8:39 AM · Krita
alvinhochun added a comment to D15755: Global Kinetic Scrolling.

This patch takes the concept of Kinetic Scrolling and applies it uniformly across Krita's user interface, where applicable. To do so, we've created a new KisKineticScrolling namespace that encompasses most of the behavior of kinetic scrolling in a single place, which allows for adding consistent kinetic scrolling behavior to any UI element with just a few function calls. Using the new namespace we were able to easily add kinetic scrolling to all of Krita's scrollable user interface elements including dockers, the toolbox, the brush preset selector, palettes, animation timeline, etc. Because all of these elements share the same code path, they all use the same user-configured settings. The namespace also has a couple of utility functions, including a cursor updater to unify the visual feedback.

Sep 26 2018, 3:33 AM · Krita