alvinhochun (Alvin Wong)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2016, 12:39 PM (129 w, 5 d)
Availability
Available

Recent Activity

Thu, Dec 13

alvinhochun committed R37:b763b61ec551: Fix broken CMake command line (authored by alvinhochun).
Fix broken CMake command line
Thu, Dec 13, 4:04 PM

Oct 17 2018

alvinhochun reopened T2299: Make the canvas behave in HiDPI mode as "Open".

@dkazakov I see that you've changed the code to use devicePixelRatioF. I can see that the canvas now attempts to render at 100% device pixel size.

Oct 17 2018, 8:41 AM · Krita: Next Features
alvinhochun added a task to R37:046ce7128a7e: Fix fractional display scale factor: T2299: Make the canvas behave in HiDPI mode.
Oct 17 2018, 7:47 AM
alvinhochun added a commit to T2299: Make the canvas behave in HiDPI mode: R37:046ce7128a7e: Fix fractional display scale factor.
Oct 17 2018, 7:47 AM · Krita: Next Features

Oct 14 2018

alvinhochun added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

With cases like this it's usually preferred to do feature detection instead of checking for specific versions.

Oct 14 2018, 9:12 AM · Krita

Oct 11 2018

alvinhochun added a comment to D16128: Add a rotate slider to the overview docker..

Krita lacks options to rotate the canvas

Oct 11 2018, 2:39 PM · Krita

Oct 10 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

One more issue: The fix seems to have used the integer version of devicePixelRatio somewhere instead of the floating point devicePixelRatioF. This is from my observation forcing a 1.5x scaling on Windows. I haven't checked the code. Even though Qt now rounds the scale factor to nearest integer on Windows, we should assume that real fractional scaling support will be added in the future. In fact the then-in-progress task https://bugreports.qt.io/browse/QTBUG-53022 is exactly for this. (It might even be already supported on KDE, but I can't confirm.) So please fix it to use the floating point devicePixelRatio.

Oct 10 2018, 4:38 PM · Krita: Next Features
alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

@dkazakov Thanks for the partial fix. I've done some testing on Windows with krita-nightly-x64-v4.1.3.1-239-ge64348e693, so here's my observations/findings:

Oct 10 2018, 4:38 PM · Krita: Next Features

Oct 5 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

I'm not sure that it really happens this way.

Feel free to check.

This fixes one of the two issues that will make it less blurry https://phabricator.kde.org/P263

Oct 5 2018, 2:39 AM · Krita: Next Features

Oct 4 2018

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.

Hi, @davidedmundson!

I have just tried to reproduce the problem again, and I do still reproduce it with Qt 5.9.1. I will try to search for exact lines in Qt's code, but I'm not sure I will manage to finish it today. Steps to reproduce:

  1. Set GUI scaling in windows to 150-200%
  2. Start Krita
  3. Go to Settings->General->Enable HiDPI support (it basically activates GUI scaling). Without this option, openGL canvas behaves exactly like you explain, that is, renders inRestart hardware pixels. But after activating this option, scaling starts.
  4. Restart Krita
  5. Create 500x200 image
  6. Activate "Use same aspect as pixels" box at the bottom-right corner of the window
  7. Press '1' to set 100% zoom
  8. BUG: See that the image has actually size of 1000x400 physical pixels. And Krita does not pass any extra scaling to openGL. It paints just in logical pixels.
Oct 4 2018, 5:31 PM · Krita: Next Features

Sep 27 2018

alvinhochun added a comment to D15755: Global Kinetic Scrolling.

Actually, only right-click press itself is for opening context menus
and some context-sensitive actions. I don't think right-click drag is
used for anything, or is it? Using right-click drag for scrolling is
not so implausible.

Ok. I was thinking that context menus often pop up on mouse down,
which would interfere with the scrolling. And since right-click release events
often trigger menu selections (does that happen on Windows too?
I can't remember off the top of my head) it might be prone to accidents.

Of course, all that stuff could be worked around and there's no harm in testing it!

Sep 27 2018, 9:16 AM · Krita

Sep 26 2018

alvinhochun added a comment to D15755: Global Kinetic Scrolling.

Alvin, is your issue that the middle mouse button is used by default? Because there are other scroll methods available already in the existing code(finger scroll and mouseclick scroll). I've been using the latter on my system.

Sep 26 2018, 1:08 PM · Krita
alvinhochun added a comment to D15755: Global Kinetic Scrolling.

This is a bit of a misunderstanding, I think.

Scroll bars are still enabled by default, as they probably should be.
It's merely that the checkbox says "Hide Scrollbars" now, and that users have to opt into hiding them.
It's purely a semantic change, the users opts into "hiding" the scrollbars instead of opting out of "showing" them.

Sep 26 2018, 8:39 AM · Krita
alvinhochun added a comment to D15755: Global Kinetic Scrolling.

This patch takes the concept of Kinetic Scrolling and applies it uniformly across Krita's user interface, where applicable. To do so, we've created a new KisKineticScrolling namespace that encompasses most of the behavior of kinetic scrolling in a single place, which allows for adding consistent kinetic scrolling behavior to any UI element with just a few function calls. Using the new namespace we were able to easily add kinetic scrolling to all of Krita's scrollable user interface elements including dockers, the toolbox, the brush preset selector, palettes, animation timeline, etc. Because all of these elements share the same code path, they all use the same user-configured settings. The namespace also has a couple of utility functions, including a cursor updater to unify the visual feedback.

Sep 26 2018, 3:33 AM · Krita

Sep 23 2018

alvinhochun added a comment to D15585: Add openssl download and build step to krita.

This post [1] describes a way of building OpenSSL with mingw(-w64).

That's rather different from what's in the openssl readme itself :-(

Sep 23 2018, 4:25 PM · Krita

Sep 19 2018

alvinhochun added a comment to D15585: Add openssl download and build step to krita.

This post [1] describes a way of building OpenSSL with mingw(-w64).

Sep 19 2018, 11:08 AM · Krita

Sep 10 2018

alvinhochun added a comment to T9256: HDR Support in Krita.
In T9256#159693, @rempt wrote:

Angle

  • The version of Angle that is packaged with Qt only supports OpenGL ES 2, which does not support 16 or 32 bits floating point textures: when using Angle, Krita's support for HDR images is already broken.
Sep 10 2018, 3:08 PM · Krita

Jul 21 2018

alvinhochun committed R37:be4ed821832f: Relicense Win8 pointer input code as BSD 2-Clause (authored by alvinhochun).
Relicense Win8 pointer input code as BSD 2-Clause
Jul 21 2018, 10:20 AM

Jul 6 2018

alvinhochun added a comment to M131: Discuss Toolbox customization .

RE point 1: The toolbox's minimum size should be one tool button wide, does it mean some people want to reduce its size to smaller than one tool button? Or is it that they somehow want all the (perhaps only often used) tool buttons to be visible at once? Or that they want to hide the toolbox and make it a pop-up when pressing on a toolbar button, like the brush editor and etc.?

Jul 6 2018, 9:14 PM · Krita

Jun 14 2018

alvinhochun added a comment to D13548: Use KFormat for formatting byte sizes.

I think you probably should specify KFormat::JEDECBinaryDialect.

Jun 14 2018, 9:24 PM · Krita

Jun 9 2018

alvinhochun edited P235 POC patch to qtbase for bug 394376.
Jun 9 2018, 10:07 PM · Krita: Stable bug fixes

Jun 8 2018

alvinhochun edited P235 POC patch to qtbase for bug 394376.
Jun 8 2018, 7:31 PM · Krita: Stable bug fixes
alvinhochun edited P235 POC patch to qtbase for bug 394376.
Jun 8 2018, 4:33 PM · Krita: Stable bug fixes
alvinhochun edited P235 POC patch to qtbase for bug 394376.
Jun 8 2018, 11:37 AM · Krita: Stable bug fixes

Jun 7 2018

alvinhochun created P235 POC patch to qtbase for bug 394376 in the S1 KDE Community space.
Jun 7 2018, 2:29 PM · Krita: Stable bug fixes

May 31 2018

alvinhochun committed R37:6180b407073a: Remove ffmpeg from Windows build script (authored by alvinhochun).
Remove ffmpeg from Windows build script
May 31 2018, 10:53 PM

May 27 2018

alvinhochun committed R37:006d9da940f4: Windows deps: Add prebuilt ffmpeg by Zeranoe (authored by alvinhochun).
Windows deps: Add prebuilt ffmpeg by Zeranoe
May 27 2018, 6:04 PM
alvinhochun committed R37:b33f82e15626: NSIS: Make FFmpeg unable to be deselected (authored by alvinhochun).
NSIS: Make FFmpeg unable to be deselected
May 27 2018, 6:04 PM

May 23 2018

alvinhochun added a comment to T8803: Bundle FFmpeg in the Windows installer.
  1. it should not be mentioned in the installer. It should just be included

I get it that you probably don't want to confuse users, but would showing an option really be a huge issue? At this rate it would seem that the Windows build should even just have the ffmpeg path selection box hidden and the path hard-coded.

May 23 2018, 9:41 PM · Krita: Releases
alvinhochun added a comment to T8803: Bundle FFmpeg in the Windows installer.
In T8803#143757, @rempt wrote:

Ben noted on irc that we should use a stripped down version like suse does -- but I'm not sure whether that's an option.

I don't see it in the backlog, it's overflown :( What does stripped down mean here? Custom build with limited features enabled?

Ideally we'd bundle it.

Yep.

I'm not sure about giving people an opt-out is all that useful.

Well, it does take a bit more space, I don't know if people would start complaining about that 8) Also not every users would need to render animations.

We should note that we include ffmpeg in the license text in the installer.

If you feel like doing it, can you make a copy of the license rtf and add the text there?

I would prefer to have it downloaded like any 3rdparty component

About 5, I'm not sure what would be best...

If files.kde.org doesn't mind 40MB extra of traffic with every deps build done, then it's simpler if you just just throw the original zeranoe build 4.0 packages up there, and I'll add the ExternalProject in CMake to fetch them. Would probably also make future updates easier.

May 23 2018, 9:34 PM · Krita: Releases

May 22 2018

alvinhochun updated the task description for T8803: Bundle FFmpeg in the Windows installer.
May 22 2018, 8:30 PM · Krita: Releases
alvinhochun triaged T8803: Bundle FFmpeg in the Windows installer as Normal priority.
May 22 2018, 8:25 PM · Krita: Releases
alvinhochun committed R37:f6e0f4a79efc: Remove install(krita_versions_detect.nsh) for real (authored by alvinhochun).
Remove install(krita_versions_detect.nsh) for real
May 22 2018, 7:45 PM

May 21 2018

alvinhochun committed R37:4a5aa169c9ff: Remove installer script added accidentally (authored by alvinhochun).
Remove installer script added accidentally
May 21 2018, 8:23 PM
alvinhochun committed R37:69dbdf171de8: Improve ffmpeg path handling on Windows (authored by alvinhochun).
Improve ffmpeg path handling on Windows
May 21 2018, 8:08 PM
alvinhochun committed R37:e2fb370b3399: Make FFmpeg optional for Windows installer (authored by alvinhochun).
Make FFmpeg optional for Windows installer
May 21 2018, 8:08 PM
alvinhochun committed R37:e4c56d75aadb: Add ffmpeg to Windows package if exists (authored by alvinhochun).
Add ffmpeg to Windows package if exists
May 21 2018, 8:08 PM
alvinhochun committed R37:01f52202aa84: Use installer files from Krita source tree (authored by alvinhochun).
Use installer files from Krita source tree
May 21 2018, 8:08 PM
alvinhochun committed R37:cbaa6269f78f: Import Krita-specific NSIS installer scripts (authored by alvinhochun).
Import Krita-specific NSIS installer scripts
May 21 2018, 8:08 PM
alvinhochun committed R37:5dd877bc2a55: Move files related to Windows installer (authored by alvinhochun).
Move files related to Windows installer
May 21 2018, 8:08 PM

May 20 2018

alvinhochun committed R37:98f2dce0cd24: Remove now-unused Windows packaging utils (authored by alvinhochun).
Remove now-unused Windows packaging utils
May 20 2018, 8:36 PM

May 19 2018

alvinhochun committed R37:3a1a6a3cb401: Try to get default language to work for more languages (authored by alvinhochun).
Try to get default language to work for more languages
May 19 2018, 8:26 PM
alvinhochun committed R37:4c7aa19551f3: Use QLocale::uiLanguages as the default language(s) (authored by alvinhochun).
Use QLocale::uiLanguages as the default language(s)
May 19 2018, 3:22 PM
alvinhochun committed R37:88588c2baa0e: Change i18n* in the static context to ki18n* (authored by alvinhochun).
Change i18n* in the static context to ki18n*
May 19 2018, 2:34 PM

May 18 2018

alvinhochun updated the task description for T8050: WinTab support code enhancement.
May 18 2018, 7:46 PM · Krita: Abyss

May 17 2018

alvinhochun committed R37:e38339f14ca2: Merge branch 'alvin/D12710-tablet-tester' (authored by alvinhochun).
Merge branch 'alvin/D12710-tablet-tester'
May 17 2018, 5:47 PM
alvinhochun closed D12710: Add tablet tester from Drawpile.
May 17 2018, 5:46 PM · Krita
alvinhochun committed R37:c0cf2856ea3a: Improve logging of tablet proximity events (authored by alvinhochun).
Improve logging of tablet proximity events
May 17 2018, 5:46 PM
alvinhochun committed R37:512be25cf5fd: Adapt and enable tablet tester (authored by alvinhochun).
Adapt and enable tablet tester
May 17 2018, 5:46 PM
alvinhochun committed R37:fc43b0de4975: Replace tabs with spaces (authored by alvinhochun).
Replace tabs with spaces
May 17 2018, 5:46 PM
alvinhochun committed R37:39e15d603bdc: Add TabletTester code files from Drawpile (authored by alvinhochun).
Add TabletTester code files from Drawpile
May 17 2018, 5:46 PM
alvinhochun updated the diff for D12710: Add tablet tester from Drawpile.

Improved the logging of proximity events.

May 17 2018, 3:51 PM · Krita
alvinhochun abandoned D10988: Windows: Update ext_qt to Qt 5.9.4 again with extra patch.

This patch to Qt isn't needed anymore now that D12762 "fixed" the issue.

May 17 2018, 3:13 PM · Krita
alvinhochun committed R37:b1d67ddc2d36: Make QQuickWidget accept touch events on recent Qt versions (authored by alvinhochun).
Make QQuickWidget accept touch events on recent Qt versions
May 17 2018, 3:11 PM
alvinhochun closed D12762: Make QQuickWidget accept touch events.
May 17 2018, 3:11 PM · Krita
alvinhochun updated the diff for D12762: Make QQuickWidget accept touch events.

Added run-time version check for Qt 5.9.x where x > 3 and Qt 5.10.1 or above.

May 17 2018, 12:35 PM · Krita

May 15 2018

alvinhochun accepted D12838: Optional Python 2 Support for Krita.

Looks good to me now. I haven't tested it but I believe the remaining changes shouldn't specifically affect the Windows build.

May 15 2018, 6:56 PM · Krita
alvinhochun added a comment to D12838: Optional Python 2 Support for Krita.

Maybe you can find a way to make it work on Windows using a user-specified Python 2.7 install and self-built SIP/PyQt, but it must use separate code paths that is switched by an ifdef.

May 15 2018, 9:35 AM · Krita
alvinhochun requested changes to D12838: Optional Python 2 Support for Krita.

I would suggest just not allow Python 2.7 to be used with Windows/MinGW because the whole Python setup for the Windows build is pretty much tied to the embedded Python 3.6 package.
Do note that the Python setup for the Windows build is pretty specific and even requires a certain version range of Python to be installed on the build host to build properly.
Unless you also modify ext_python, ext_sip, ext_pyqt, the Python plugin code and the packaging scripts to be able to produce a package with Python 2.7 embedded into it, it's basically not usable.

May 15 2018, 9:11 AM · Krita

May 12 2018

alvinhochun added a comment to D12710: Add tablet tester from Drawpile.

Should I make improvements based on this specific code from Drawpile, or revive the old tablet tester that @rempt mentioned, or better write a new tablet tester to suit Krita's needs?

May 12 2018, 3:34 PM · Krita

May 9 2018

alvinhochun added a comment to D12762: Make QQuickWidget accept touch events.

You can make a runtime check for version

static const bool shouldSetAcceptTouchEvents = QVersionNumber::fromString(qVersion()) > QVersionNumber(5, 9, 3);
if (shouldSetAcceptTouchEvents) {
    quickWidget->setAttribute(Qt::WA_AcceptTouchEvents);
}
May 9 2018, 2:18 PM · Krita

May 8 2018

alvinhochun updated the summary of D12762: Make QQuickWidget accept touch events.
May 8 2018, 4:43 PM · Krita
alvinhochun requested review of D12762: Make QQuickWidget accept touch events.
May 8 2018, 4:43 PM · Krita
alvinhochun added a comment to D12710: Add tablet tester from Drawpile.

That is interesting. Is it the same output in Drawpile? Because it should be now that Drawpile borrows the tablet code from Krita.

May 8 2018, 8:52 AM · Krita

May 5 2018

alvinhochun updated the diff for D12710: Add tablet tester from Drawpile.
May 5 2018, 7:38 PM · Krita
alvinhochun added a task to D12710: Add tablet tester from Drawpile: T8050: WinTab support code enhancement.
May 5 2018, 6:51 PM · Krita
alvinhochun added a revision to T8050: WinTab support code enhancement: D12710: Add tablet tester from Drawpile.
May 5 2018, 6:51 PM · Krita: Abyss
alvinhochun added a comment to D12710: Add tablet tester from Drawpile.

I should also add that this is not a replacement of the tablet log since it bypasses KisInputManager completely.

May 5 2018, 6:49 PM · Krita
alvinhochun requested review of D12710: Add tablet tester from Drawpile.
May 5 2018, 6:25 PM · Krita
alvinhochun committed R37:1d6a7e2ec62c: Readd errorously removed bracket (authored by alvinhochun).
Readd errorously removed bracket
May 5 2018, 1:50 PM

Apr 18 2018

alvinhochun added a comment to M125: Krita.org download page alternate version.

Seems good to me

Apr 18 2018, 5:30 PM · Krita: Website and Translations

Apr 16 2018

alvinhochun committed R37:a5c3f39157f9: Win: Fix the Qt patch for QSaveFile (authored by alvinhochun).
Win: Fix the Qt patch for QSaveFile
Apr 16 2018, 12:32 PM
alvinhochun closed D11905: Prompt user if WinTab cannot be loaded.
Apr 16 2018, 12:31 PM · Krita
alvinhochun added 1 commit(s) for D11905: Prompt user if WinTab cannot be loaded: R37:3bea0c743840: Enable WinInk or prompt if WinTab cannot be loaded.
Apr 16 2018, 12:31 PM · Krita
alvinhochun added an edge to R37:3bea0c743840: Enable WinInk or prompt if WinTab cannot be loaded: D11905: Prompt user if WinTab cannot be loaded.
Apr 16 2018, 12:31 PM
alvinhochun committed R37:3bea0c743840: Enable WinInk or prompt if WinTab cannot be loaded (authored by alvinhochun).
Enable WinInk or prompt if WinTab cannot be loaded
Apr 16 2018, 12:30 PM

Apr 15 2018

alvinhochun updated the diff for D11905: Prompt user if WinTab cannot be loaded.
  • Now automatically selects WinInk if there exists a WinInk pen device.
  • Changed the prompts.
Apr 15 2018, 12:30 PM · Krita

Apr 14 2018

alvinhochun committed R37:5f6e9e9eac42: Win: Fix the Qt patch for QSaveFile (authored by alvinhochun).
Win: Fix the Qt patch for QSaveFile
Apr 14 2018, 7:06 AM

Apr 13 2018

alvinhochun committed R37:572348686b82: Win: Patch Qt to fix QSaveFile locking with Dropbox (authored by rempt).
Win: Patch Qt to fix QSaveFile locking with Dropbox
Apr 13 2018, 1:51 PM
alvinhochun committed R37:e3c358a9b0ff: Win: Patch Qt to fix QSaveFile locking with Dropbox (authored by rempt).
Win: Patch Qt to fix QSaveFile locking with Dropbox
Apr 13 2018, 1:49 PM

Apr 11 2018

alvinhochun planned changes to D11905: Prompt user if WinTab cannot be loaded.
Apr 11 2018, 7:14 PM · Krita

Apr 6 2018

alvinhochun added a comment to D11905: Prompt user if WinTab cannot be loaded.

It would be a bit tricky to detect N-Trig digitizers, but it should technically be doable. However, I would be reluctant to implement a special override for N-Trig digitizers. Some users might still want to install and use a Wacom tablet.

Apr 6 2018, 3:02 AM · Krita

Apr 4 2018

alvinhochun added a comment to D11905: Prompt user if WinTab cannot be loaded.

Hm... I'm wondering, can we not just load the winink code silently if we don't find a wintab driver?

Apr 4 2018, 7:38 AM · Krita

Apr 3 2018

woltherav awarded D11905: Prompt user if WinTab cannot be loaded a Love token.
Apr 3 2018, 5:17 PM · Krita
alvinhochun updated the diff for D11905: Prompt user if WinTab cannot be loaded.
Apr 3 2018, 5:00 PM · Krita
alvinhochun requested review of D11905: Prompt user if WinTab cannot be loaded.
Apr 3 2018, 4:59 PM · Krita

Mar 29 2018

alvinhochun created P182 Test for bug 392408 (QSaveFile) in the S1 KDE Community space.
Mar 29 2018, 1:52 PM · Krita
alvinhochun committed R37:87199d23f95c: Windows: Fix build script if Python path contains close paren (authored by alvinhochun).
Windows: Fix build script if Python path contains close paren
Mar 29 2018, 1:12 PM

Mar 28 2018

alvinhochun created P180 Patch for bug 392408 (QSaveFile)? in the S1 KDE Community space.
Mar 28 2018, 3:07 PM · Krita

Mar 25 2018

alvinhochun added a reviewer for D11689: fix precise paint device wrapper readRects in wrap around mode: dkazakov.

@dkazakov should check this.

Mar 25 2018, 4:32 PM

Mar 20 2018

alvinhochun added a comment to D11507: Change the behaviour of the add layer button.

Haven't tested but looks fine to me.
Though there are some minor issues with the code formatting:

Mar 20 2018, 11:33 AM · Krita

Mar 13 2018

alvinhochun awarded D11275: Add Script Starter script a Like token.
Mar 13 2018, 2:36 AM · Krita

Mar 11 2018

alvinhochun added a comment to D11139: Stop the auto-scroll from staying on with some tools.

Hi @scottpetrovic, does this fix https://bugs.kde.org/show_bug.cgi?id=362659 and can the commit 61a84e2c008939cb1989f648320e53b5d91760bd? be reverted?

Mar 11 2018, 12:06 PM

Mar 6 2018

alvinhochun committed R37:427efb5dc787: Do not include column in name when saving backup preset (authored by alvinhochun).
Do not include column in name when saving backup preset
Mar 6 2018, 5:12 PM
alvinhochun committed R37:861444628a91: Do not include column in name when saving backup preset (authored by alvinhochun).
Do not include column in name when saving backup preset
Mar 6 2018, 5:12 PM

Mar 5 2018

alvinhochun updated the task description for T8050: WinTab support code enhancement.
Mar 5 2018, 4:41 PM · Krita: Abyss
alvinhochun committed R37:c8fba12819ab: Revert "Update all thumbnails and all presets and merge my Brushkit8.2" (authored by alvinhochun).
Revert "Update all thumbnails and all presets and merge my Brushkit8.2"
Mar 5 2018, 4:24 PM
alvinhochun added a reverting change for R37:d06267c671ac: Update all thumbnails and all presets and merge my Brushkit8.2: R37:c8fba12819ab: Revert "Update all thumbnails and all presets and merge my Brushkit8.2".
Mar 5 2018, 4:24 PM
alvinhochun committed R37:993e9ff7d9ef: Revert "Update splash images for 4.0" (authored by alvinhochun).
Revert "Update splash images for 4.0"
Mar 5 2018, 4:20 PM
alvinhochun added a reverting change for R37:e09e7bdd9992: Update splash images for 4.0: R37:993e9ff7d9ef: Revert "Update splash images for 4.0".
Mar 5 2018, 4:20 PM