alvinhochun (Alvin Wong)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2016, 12:39 PM (173 w, 1 d)
Availability
Available

Recent Activity

May 24 2019

alvinhochun added a comment to T10935: Need testing for WinInk tablet support.

I tested the build https://yadi.sk/d/aPP0OEDRdUt0Mw and this is my test result:

May 24 2019, 2:09 PM · Krita: Next Features (Needs Testing)

May 18 2019

alvinhochun added a comment to T10935: Need testing for WinInk tablet support.

The touch docker appears to work fine on my SP2017, but the other QML windows (the open/save file dialogs) doesn't respond to the stylus

May 18 2019, 11:27 AM · Krita: Next Features (Needs Testing)

May 13 2019

alvinhochun created T10922: Replace usage of QDesktopWidget with QScreen.
May 13 2019, 4:32 PM · Krita

May 8 2019

alvinhochun committed R37:47b250d1b8f0: Fix splash_screen_x2.xpm to be right size (authored by alvinhochun).
Fix splash_screen_x2.xpm to be right size
May 8 2019, 5:19 PM

Apr 28 2019

alvinhochun committed R37:e36e243b8400: Fix duplicated canvasMousePositionChanged signal connections (authored by alvinhochun).
Fix duplicated canvasMousePositionChanged signal connections
Apr 28 2019, 2:18 PM
alvinhochun committed R37:f265001b55fa: Make zoom mode persist when moving across screens (authored by alvinhochun).
Make zoom mode persist when moving across screens
Apr 28 2019, 8:28 AM

Apr 27 2019

alvinhochun committed R37:458beaaaee87: Fix rounding of doc offset in fractional DPI scaling (authored by alvinhochun).
Fix rounding of doc offset in fractional DPI scaling
Apr 27 2019, 12:58 PM

Apr 26 2019

alvinhochun committed R37:ab98e9b5b49c: Remove "EXPERIMENTAL" wording for WinInk in settings (authored by alvinhochun).
Remove "EXPERIMENTAL" wording for WinInk in settings
Apr 26 2019, 3:52 PM

Apr 25 2019

alvinhochun updated the task description for T10838: Qt patches required by Krita.
Apr 25 2019, 1:07 PM · Krita: Releases

Apr 24 2019

alvinhochun committed R37:3251e72081dd: Fix some #ifdef guards in main.cc (authored by alvinhochun).
Fix some #ifdef guards in main.cc
Apr 24 2019, 3:19 PM
alvinhochun added a comment to T10838: Qt patches required by Krita.

Fix debug on openGL ES (not published, 0004-Fix-debug-on-openGL-ES.patch)

Apr 24 2019, 11:18 AM · Krita: Releases

Apr 23 2019

alvinhochun added inline comments to D20759: Add gitlab workflow to Untranslatable Pages.
Apr 23 2019, 1:08 PM · Krita: Manual
alvinhochun added inline comments to D20759: Add gitlab workflow to Untranslatable Pages.
Apr 23 2019, 10:26 AM · Krita: Manual

Apr 20 2019

alvinhochun committed R37:c84dc6644114: Merge branch 'alvin/fractional-dpi-scaling' into 'master' (authored by alvinhochun).
Merge branch 'alvin/fractional-dpi-scaling' into 'master'
Apr 20 2019, 2:59 PM
alvinhochun committed R37:16929f11eaed: Use RoundPreferFloor when fractional scaling is disabled (authored by alvinhochun).
Use RoundPreferFloor when fractional scaling is disabled
Apr 20 2019, 2:59 PM
alvinhochun committed R37:887e9fd4118f: Add option to toggle fractional DPI scaling (authored by alvinhochun).
Add option to toggle fractional DPI scaling
Apr 20 2019, 2:59 PM
alvinhochun committed R37:a05da09781a5: Add ext_qt patch for Windows to support fractional DPI scaling (authored by alvinhochun).
Add ext_qt patch for Windows to support fractional DPI scaling
Apr 20 2019, 2:59 PM
alvinhochun committed R37:b4dcb33a677c: Add ext_qt patch to fix moving window between screens (authored by alvinhochun).
Add ext_qt patch to fix moving window between screens
Apr 20 2019, 2:59 PM

Apr 19 2019

alvinhochun committed R37:6885f97f567f: Fix wrong dialog being used with Touch Docker (authored by alvinhochun).
Fix wrong dialog being used with Touch Docker
Apr 19 2019, 4:49 AM
alvinhochun abandoned D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Apr 19 2019, 2:54 AM · Krita
alvinhochun updated the summary of D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Apr 19 2019, 2:53 AM · Krita
alvinhochun committed R37:8b885b2d89ad: Add ext_qt patch for Windows to support fractional DPI scaling (authored by alvinhochun).
Add ext_qt patch for Windows to support fractional DPI scaling
Apr 19 2019, 2:48 AM
alvinhochun committed R37:776e2a54fcf7: Add ext_qt patch to fix moving window between screens (authored by alvinhochun).
Add ext_qt patch to fix moving window between screens
Apr 19 2019, 2:48 AM
alvinhochun closed T10765: Make canvas render correctly under fractional scaling, a subtask of T2299: Make the canvas behave in HiDPI mode, as Resolved.
Apr 19 2019, 2:35 AM · Krita: Next Features
alvinhochun closed T10765: Make canvas render correctly under fractional scaling as Resolved.
Apr 19 2019, 2:35 AM · Krita: Next Features

Apr 18 2019

alvinhochun added 1 commit(s) for D20657: Fix fullscreen mode on Windows with OpenGL: R37:012d64083350: Fix patch for Windows fullscreen mode hack.
Apr 18 2019, 5:05 PM · Krita
alvinhochun added an edge to R37:012d64083350: Fix patch for Windows fullscreen mode hack: D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 5:05 PM
alvinhochun committed R37:012d64083350: Fix patch for Windows fullscreen mode hack (authored by alvinhochun).
Fix patch for Windows fullscreen mode hack
Apr 18 2019, 5:03 PM
alvinhochun requested review of D20666: Add an FAQ item for fullscreen mode workaround on Windows.
Apr 18 2019, 2:45 PM · Krita: Manual
alvinhochun updated the diff for D20607: Add ext_qt patch for Windows to support fractional DPI scaling.

Updated patch for master

Apr 18 2019, 1:45 PM · Krita
alvinhochun committed R37:b5800a8dde0f: Add ext_qt hack to allow windepolyqt to package build with debug info (authored by alvinhochun).
Add ext_qt hack to allow windepolyqt to package build with debug info
Apr 18 2019, 12:39 PM
alvinhochun committed R37:e83e87794bdd: Fix fullscreen mode on Windows with OpenGL (authored by alvinhochun).
Fix fullscreen mode on Windows with OpenGL
Apr 18 2019, 12:33 PM
alvinhochun closed D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 12:33 PM · Krita
alvinhochun updated the diff for D20657: Fix fullscreen mode on Windows with OpenGL.

Upload the correct patch

Apr 18 2019, 12:21 PM · Krita
alvinhochun updated the summary of D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 12:09 PM · Krita
alvinhochun updated the diff for D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 11:07 AM · Krita
alvinhochun planned changes to D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 10:52 AM · Krita
alvinhochun requested review of D20657: Fix fullscreen mode on Windows with OpenGL.
Apr 18 2019, 10:49 AM · Krita

Apr 17 2019

alvinhochun added a comment to D20607: Add ext_qt patch for Windows to support fractional DPI scaling.

The question is: should we change the default behaviour to RoundPreferFloor instead of trying to keep the old behaviour by using Round? I feel like RoundPreferFloor would be more useful to users who doesn't want to enable fractional scaling (but that will probably be the minority if we can enable fractional scaling by default).

Apr 17 2019, 5:35 PM · Krita

Apr 16 2019

alvinhochun requested review of D20607: Add ext_qt patch for Windows to support fractional DPI scaling.
Apr 16 2019, 5:32 PM · Krita
alvinhochun committed R37:f0f35797d2af: ext_vc: Make it not rely on a fixed install path (authored by alvinhochun).
ext_vc: Make it not rely on a fixed install path
Apr 16 2019, 8:34 AM

Apr 15 2019

alvinhochun committed R37:1fdda43f9b68: Fix OpenGL canvas under fractional DPI scaling (authored by alvinhochun).
Fix OpenGL canvas under fractional DPI scaling
Apr 15 2019, 5:14 PM
alvinhochun closed D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 15 2019, 5:14 PM · Krita

Apr 14 2019

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.

Moved some code from the converter to the canvas.

Apr 14 2019, 9:53 AM · Krita

Apr 13 2019

alvinhochun updated the summary of D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 13 2019, 11:02 AM · Krita

Apr 12 2019

alvinhochun updated the summary of D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 12 2019, 5:39 PM · Krita
alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.

Speaking truly, I don't understand, what bug this huge refactoring is intended to fix. Please list the problems you are trying to resolve.

Right now the patch introduces at lease two huge regressions:

  1. Zoom with mouse wheel and Ctrl+Space centers around wrong point.
  2. Rotation with Shift+Space center around wrong point and drifts from place to place (some rounding issues).

    The main point, I don't see what problem we are trying to solve?
Apr 12 2019, 5:33 PM · Krita

Apr 10 2019

alvinhochun committed R37:d627fade1d0c: build.cmd: Add option to launch cmd prompt with build env (authored by alvinhochun).
build.cmd: Add option to launch cmd prompt with build env
Apr 10 2019, 3:36 PM
alvinhochun committed R37:f841ad904cc7: build.cmd: Remove extra echo command (authored by alvinhochun).
build.cmd: Remove extra echo command
Apr 10 2019, 2:39 PM
alvinhochun added a comment to D8543: Sharpness brush option rework.

Could not update this revission as it is not mine. Im continuing the work on this here https://phabricator.kde.org/D20423

  • Softness Controls alpha borders
  • Strenght controls how soon dark pixels clip to black
  • Pixel brushes work as normal

    Missing
  • save settings doesn't work
Apr 10 2019, 6:15 AM · Krita

Apr 9 2019

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 9 2019, 5:50 PM · Krita

Apr 8 2019

alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 8 2019, 5:38 PM · Krita

Apr 6 2019

alvinhochun updated the task description for T10765: Make canvas render correctly under fractional scaling.
Apr 6 2019, 8:35 AM · Krita: Next Features
alvinhochun added a revision to T10765: Make canvas render correctly under fractional scaling: D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 6 2019, 7:09 AM · Krita: Next Features
alvinhochun added a task to D20097: Fix OpenGL canvas under fractional DPI scaling: T10765: Make canvas render correctly under fractional scaling.
Apr 6 2019, 7:09 AM · Krita
alvinhochun triaged T10765: Make canvas render correctly under fractional scaling as Normal priority.
Apr 6 2019, 7:09 AM · Krita: Next Features

Apr 5 2019

alvinhochun added inline comments to D20097: Fix OpenGL canvas under fractional DPI scaling.
Apr 5 2019, 5:44 PM · Krita
alvinhochun updated the diff for D20097: Fix OpenGL canvas under fractional DPI scaling.
  • Starting to convert more stuff to use device pixel
  • Beginning to differentiate between device pixel and logical pixels
Apr 5 2019, 5:26 PM · Krita

Apr 4 2019

alvinhochun committed R37:f3858d112d54: Make Windows build create thin archives when linking (authored by alvinhochun).
Make Windows build create thin archives when linking
Apr 4 2019, 3:35 PM

Apr 2 2019

alvinhochun committed R37:e59ed34c0ced: Win: Add pre-built OpenSSL as dep (authored by alvinhochun).
Win: Add pre-built OpenSSL as dep
Apr 2 2019, 7:17 PM
alvinhochun closed D20206: Add pre-built OpenSSL for Windows.
Apr 2 2019, 7:17 PM · Krita
alvinhochun updated the diff for D20206: Add pre-built OpenSSL for Windows.

Add comments and updated 3rdparty/README.md

Apr 2 2019, 4:07 PM · Krita
alvinhochun requested review of D20206: Add pre-built OpenSSL for Windows.
Apr 2 2019, 3:52 PM · Krita
alvinhochun committed R37:5b0dcbc15892: ext_qt: Use external zlib/libpng/libjpeg (authored by alvinhochun).
ext_qt: Use external zlib/libpng/libjpeg
Apr 2 2019, 2:38 PM
alvinhochun committed R37:95979cc09fb6: Improve 3rdparty/README.md (authored by alvinhochun).
Improve 3rdparty/README.md
Apr 2 2019, 9:22 AM
alvinhochun committed R37:9e1ada220418: Windows: Simplify use of ext_gettext target (authored by alvinhochun).
Windows: Simplify use of ext_gettext target
Apr 2 2019, 9:03 AM
alvinhochun committed R37:eff0c7010ac3: Fix wrong DPI when moving window across screens (authored by alvinhochun).
Fix wrong DPI when moving window across screens
Apr 2 2019, 8:19 AM
alvinhochun closed D20171: Fix wrong DPI when moving window across screens.
Apr 2 2019, 8:19 AM · Krita

Apr 1 2019

alvinhochun added a task to D20171: Fix wrong DPI when moving window across screens: T2299: Make the canvas behave in HiDPI mode.
Apr 1 2019, 3:44 PM · Krita
alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20171: Fix wrong DPI when moving window across screens.
Apr 1 2019, 3:44 PM · Krita: Next Features
alvinhochun requested review of D20171: Fix wrong DPI when moving window across screens.
Apr 1 2019, 3:30 PM · Krita

Mar 31 2019

alvinhochun committed R37:c06939163973: Fix gettext static binary download (authored by alvinhochun).
Fix gettext static binary download
Mar 31 2019, 5:09 PM
alvinhochun committed R37:7fcbda062fe4: Fix Windows build script targets (authored by alvinhochun).
Fix Windows build script targets
Mar 31 2019, 3:27 PM

Mar 28 2019

alvinhochun added a comment to T2299: Make the canvas behave in HiDPI mode.
Mar 28 2019, 6:11 PM · Krita: Next Features
alvinhochun added a task to D20097: Fix OpenGL canvas under fractional DPI scaling: T2299: Make the canvas behave in HiDPI mode.
Mar 28 2019, 5:41 PM · Krita
alvinhochun added a revision to T2299: Make the canvas behave in HiDPI mode: D20097: Fix OpenGL canvas under fractional DPI scaling.
Mar 28 2019, 5:41 PM · Krita: Next Features
alvinhochun requested review of D20097: Fix OpenGL canvas under fractional DPI scaling.
Mar 28 2019, 5:41 PM · Krita

Mar 27 2019

alvinhochun committed R37:8f022ec33007: Fix splash screen for some high DPI setup (authored by alvinhochun).
Fix splash screen for some high DPI setup
Mar 27 2019, 8:06 PM

Mar 26 2019

alvinhochun created P356 (An Untitled Masterwork) in the S1 KDE Community space.
Mar 26 2019, 12:48 PM
alvinhochun created P355 stack2line.py in the S1 KDE Community space.
Mar 26 2019, 12:21 PM · Krita
alvinhochun committed R37:b67e02041a28: Fix Intel OpenGL driver detection for newer drivers (authored by alvinhochun).
Fix Intel OpenGL driver detection for newer drivers
Mar 26 2019, 9:58 AM
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

That bug should be fixed with R37:331beffd5332.

Mar 26 2019, 9:34 AM · Krita
alvinhochun committed R37:331beffd5332: Fix Python scripting broken by new pyqt and sip (authored by alvinhochun).
Fix Python scripting broken by new pyqt and sip
Mar 26 2019, 9:30 AM
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

See https://bugs.kde.org/show_bug.cgi?id=405796#c4

Mar 26 2019, 8:08 AM · Krita
alvinhochun added a comment to D20023: CMake: Read PYQT_VERSION from PyQt5.QtCore.

After last night's test, I can say this is not the fix to the pyqt situation on Windows.

Mar 26 2019, 6:52 AM · Krita

Mar 16 2019

alvinhochun added a comment to D19807: Fix formatting and minor typos.

I'm a little skeptical about 'an hsv filter' as that would be verbalized as 'an hatchesvee filter', and we also talk about 'a human', 'a hatchet', 'a house', 'a hamlet' and not 'an human', 'an hatchet', 'an house'.

@rempt do you have an idea?

The English Wikipedia uses "an":

https://en.wikipedia.org/wiki/HSL_and_HSV#From_HSV

I think it's because it begins with /eɪtʃ/.

Mar 16 2019, 8:14 PM · Krita: Manual

Mar 14 2019

alvinhochun committed R37:5c108eac4ef5: Remove openssl requirement in ext_qt (authored by alvinhochun).
Remove openssl requirement in ext_qt
Mar 14 2019, 1:40 PM
alvinhochun added a reverting change for R37:0fc1a756ba73: Add openssl build step on OSX and windows: R37:5c108eac4ef5: Remove openssl requirement in ext_qt.
Mar 14 2019, 1:40 PM
alvinhochun added a comment to D15585: Add openssl download and build step to krita.

I see that you've already committed this but unfortunately it is just broken on Windows. Running config definitely isn't how one would be able to build openssl on Windows.

Mar 14 2019, 1:23 PM · Krita
alvinhochun added a comment to D19726: Setup for android(arm) build.

I agree you should make a separate define for use with OpenGL-ES-only environments. OpenGL ES is not limited to Android after all.

Mar 14 2019, 9:53 AM · Krita
alvinhochun added a comment to D18710: Update Windows installation methods.
  • Should I still remove Chocolatey, if it's very similar to Homebrew on Mac?
Mar 14 2019, 8:28 AM · Krita: Manual

Mar 7 2019

alvinhochun added a comment to D19592: Added Support For libheif in 3rdparty.

Though having the CMakeLists.txt doesn't mean they really support CMake build and probably nobody knows what would happen if you try to use it with the mingw-w64 native toolchain...

Mar 7 2019, 2:08 PM · Krita
alvinhochun added a comment to D19592: Added Support For libheif in 3rdparty.

Both libraries seems to contain a CMakeLists.txt file. If they do support CMake there is no reason to not prefer it over using the autotools build.

Mar 7 2019, 2:00 PM · Krita

Feb 16 2019

alvinhochun created P322 Ugly WIP rust code in the S1 KDE Community space.
Feb 16 2019, 6:59 PM · Krita

Feb 11 2019

alvinhochun added a comment to D18692: Fix resource locations in FAQ.

Does this make sense?

Feb 11 2019, 2:53 PM · Krita: Manual

Feb 4 2019

alvinhochun added a comment to D18710: Update Windows installation methods.

I would like to mention the Shell extension for KRA previews here. I notice that my Store-version--created files have a preview, and my other (older) files don't.

Is the shell extension bundled with the Store version, or are previews automatically saved for it? I'm happy to update the diff appropriately.

Feb 4 2019, 9:39 AM · Krita: Manual

Feb 3 2019

alvinhochun added a comment to D18692: Fix resource locations in FAQ.

See https://docs.microsoft.com/en-us/windows/uwp/porting/desktop-to-uwp-behind-the-scenes#file-system

Feb 3 2019, 6:10 PM · Krita: Manual

Jan 23 2019

alvinhochun added a comment to D18407: Port krita to use Quazip instead of KArchive, to support Zip64.
  • Can it be made to save as Zip64 only when the file doesn't fit in a typical zip file?

Not easily: we cannot predict exactly when a file will become bigger than 4 GiB from the size of the image in memory.

Jan 23 2019, 3:09 PM · Krita

Jan 21 2019

alvinhochun added a comment to D18407: Port krita to use Quazip instead of KArchive, to support Zip64.

A few things:

Jan 21 2019, 1:24 PM · Krita

Dec 13 2018

alvinhochun committed R37:b763b61ec551: Fix broken CMake command line (authored by alvinhochun).
Fix broken CMake command line
Dec 13 2018, 4:04 PM