Added Support For libheif in 3rdparty

Authored by sourabhboss on Mar 7 2019, 1:49 PM.


Group Reviewers

libheif is for support for HEIF file format decoder and encoder.
It depends on libde265.

Diff Detail

R37 Krita
No Linters Available
No Unit Test Coverage
Build Status
Buildable 9324
Build 9342: arc lint + arc unit
sourabhboss created this revision.Mar 7 2019, 1:49 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptMar 7 2019, 1:49 PM
Restricted Application added a project: Krita. · View Herald Transcript
sourabhboss requested review of this revision.Mar 7 2019, 1:49 PM
sourabhboss added a reviewer: dkazakov.
sourabhboss removed a subscriber: rempt.
rempt added inline comments.Mar 7 2019, 1:56 PM

It's probably necessary to guard this so these two are only available on Linux and macOS: Windows doesn't have the autoconf system, so if we want to have libheif on Windows, we would need to patch heif and de265 to have a cmake based build system. We do that for other 3rdparty deps.

Both libraries seems to contain a CMakeLists.txt file. If they do support CMake there is no reason to not prefer it over using the autotools build.

rempt added a comment.Mar 7 2019, 2:05 PM

They do now? Last time I checked, they didn't. Yes, in that case, the configure step should be done with CMake.

Though having the CMakeLists.txt doesn't mean they really support CMake build and probably nobody knows what would happen if you try to use it with the mingw-w64 native toolchain...

rempt added a comment.Mar 7 2019, 2:09 PM

The history seems to suggest it was mean for Windows, though maybe not for mingw...

  • Changes done
sourabhboss edited the summary of this revision. (Show Details)Mar 8 2019, 12:08 PM
rempt accepted this revision.Mar 11 2019, 2:10 PM
rempt added inline comments.

Why is this commented out?

This revision is now accepted and ready to land.Mar 11 2019, 2:10 PM