- Changes done
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
May 8 2020
May 8 2020
Mar 8 2019
Mar 8 2019
Mar 7 2019
Mar 7 2019
All Changes done
Mar 4 2019
Mar 4 2019
Feb 28 2019
Feb 28 2019
Which one is remaining in Selection Tools or I have to make for every tools at once.
Updated diff
Changes done
Jan 5 2019
Jan 5 2019
Oct 25 2018
Oct 25 2018
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
@elvisangelaccio i have used
KColorScheme::Window
instead of ::Selection then on NormalBackground color appears to be white
Oct 24 2018
Oct 24 2018
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Minor Changes done
It is reverting back on increasing the storage to 90% on current window (tested)
Oct 23 2018
Oct 23 2018
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Instead of hardcoded colors, ColorScheme is used
Oct 22 2018
Oct 22 2018
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
In D16353#347210, @ngraham wrote:Thanks. But this is still using a hardcoded color instead of the Negative color from the color scheme.
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
this-> code removed
if used space reduce it revert back
Oct 21 2018
Oct 21 2018
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
In D16353#346792, @pino wrote:Not sure why I was added as reviewer... anyway:
- no need to use this-> to call own class members, unless there is a conflict (which does not look like)
- please never hardcode colors! use KColorScheme instead
- it does not seem that the palette is reverted back when the space changes to less than the threshold
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Threshold set to 90%
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
My First Contribution
Oct 20 2018
Oct 20 2018
Oct 4 2018
Oct 4 2018
Oct 2 2018
Oct 2 2018
good job