Feed Advanced Search

Tue, Apr 7

schwarzer committed R883:1566156: translation update.
translation update
Tue, Apr 7, 9:46 PM
schwarzer committed R883:1566155: trnslation update.
trnslation update
Tue, Apr 7, 9:45 PM
schwarzer committed R883:1566154: fix translation.
fix translation
Tue, Apr 7, 9:30 PM
schwarzer committed R883:1566153: fix translation.
fix translation
Tue, Apr 7, 9:30 PM
schwarzer committed R883:1566152: fix translation.
fix translation
Tue, Apr 7, 9:22 PM
schwarzer committed R883:1566151: fix translation.
fix translation
Tue, Apr 7, 9:21 PM
schwarzer committed R883:1566150: change translation from "brennen" to "schreiben".
change translation from "brennen" to "schreiben"
Tue, Apr 7, 9:09 PM
schwarzer committed R883:1566149: change translation from "brennen" to "schreiben".
change translation from "brennen" to "schreiben"
Tue, Apr 7, 9:08 PM
schwarzer committed R883:1566147: Translation update.
Translation update
Tue, Apr 7, 8:13 PM
schwarzer committed R883:1566146: Translation update.
Translation update
Tue, Apr 7, 8:13 PM

Sun, Apr 5

schwarzer closed D28493: trunk: Night Color ergänzt und korrigiert.

Committed

Sun, Apr 5, 7:51 PM
schwarzer committed R883:1566030: backport of translation updated by Frank Steinmetzger.
backport of translation updated by Frank Steinmetzger
Sun, Apr 5, 7:29 PM
schwarzer committed R883:1566029: add user feedback translation.
add user feedback translation
Sun, Apr 5, 7:23 PM
schwarzer committed R883:1566028: translation update by Frank Steinmetzger.
translation update by Frank Steinmetzger
Sun, Apr 5, 7:22 PM
schwarzer committed R883:1565992: translation update.
translation update
Sun, Apr 5, 8:41 AM
schwarzer committed R883:1565991: translation update.
translation update
Sun, Apr 5, 8:33 AM

Sat, Apr 4

schwarzer committed R883:1565966: translation update.
translation update
Sat, Apr 4, 9:13 PM
schwarzer committed R883:1565965: translation update.
translation update
Sat, Apr 4, 9:12 PM
schwarzer committed R883:1565963: backport translation update.
backport translation update
Sat, Apr 4, 8:16 PM
schwarzer committed R883:1565962: update translations.
update translations
Sat, Apr 4, 8:15 PM
schwarzer committed R883:1565960: update translation.
update translation
Sat, Apr 4, 7:39 PM
schwarzer reopened D28493: trunk: Night Color ergänzt und korrigiert.
Sat, Apr 4, 12:14 PM

Fri, Apr 3

schwarzer added a comment to D28525: Fehlende Übersetzungen ergänzt und „Du“ konsequent groß geschrieben..

[...] und das KDE-Übersetzungs-Handbuch hatte die Großschreibung vorgeschlagen.

Fri, Apr 3, 8:56 AM
schwarzer added a comment to D28525: Fehlende Übersetzungen ergänzt und „Du“ konsequent groß geschrieben..

Generell finde ich es ja respektlos, wenn mich ein Computerprogramm duzt. Dann wenigstens groß, aber, wenn der Duden das sagt ………

Fri, Apr 3, 8:53 AM
schwarzer added a comment to D28493: trunk: Night Color ergänzt und korrigiert.
In D28493#640433, @felf wrote:

Ween du mir sagst, wie… das ist das erste Mal, dass ich bei Phabricator so weit gekommen bin. :)
(Und früher hab ich das nicht selbst gemacht.)

Fri, Apr 3, 7:38 AM
schwarzer added a comment to D28525: Fehlende Übersetzungen ergänzt und „Du“ konsequent groß geschrieben..

Was die Grossschreibung von "Du", "Dein", "Ihr" usw. angeht, sehe ich das wie der Duden. Das _kann_ man in Briefen tun aber ueberall sonst ist es unueblich.
Ist das hier arg gemischt? In dem Fall denke ich, sollten wir die Kleinschreibung bevorzugen.

Fri, Apr 3, 7:33 AM

Thu, Apr 2

schwarzer accepted D28493: trunk: Night Color ergänzt und korrigiert.

Jup. Danke. :)
Kannst du selbst einspielen?

Thu, Apr 2, 8:13 PM
schwarzer added inline comments to D28493: trunk: Night Color ergänzt und korrigiert.
Thu, Apr 2, 7:28 AM

Wed, Apr 1

schwarzer added a comment to D28493: trunk: Night Color ergänzt und korrigiert.

Ein paar Anmerkungen von mir ...

Wed, Apr 1, 10:02 PM

Wed, Mar 25

schwarzer added a comment to D28231: Bug 419174 Translation german spelling issues.

I cannot say anything about the soldier since I do not know how this is presented in the application. The rest looks good, thanks.

GCompris soldier.png:

https://github.com/gcompris/GCompris-data/blob/master/words/words/soldier.png

Wed, Mar 25, 8:43 AM · KDE Edu
schwarzer accepted D28231: Bug 419174 Translation german spelling issues.

I cannot say anything about the soldier since I do not know how this is presented in the application. The rest looks good, thanks.

Wed, Mar 25, 8:28 AM · KDE Edu

Aug 19 2019

schwarzer added a comment to D23268: add code documentation and minimal code smells improvement.

Thanks indeed. Just a note for future. Try to keep patches smaller. Separate them in e.g. whitespace changes, documentation changes and code changes. git add -p or git commit -p helps with that.
Reason: If you mix code changes with whitespace changes and then the code change turns out to be problematic, you cannot just revert the change without losing the whitespace fixes.

Aug 19 2019, 5:43 PM

Aug 15 2019

schwarzer added a reviewer for D23138: Simplify code a bit here to remove the duplication: dakon.
Aug 15 2019, 7:11 PM
schwarzer added a reviewer for D23139: base class function already does what we need: dakon.
Aug 15 2019, 7:10 PM
schwarzer closed D23041: Fix some compiler warnings.

Committed as 5f29c43e896e7865de7a6a7ee747f6ffc60f47dc

Aug 15 2019, 6:55 PM
schwarzer committed R363:98a2d86051f2: fix indentation (authored by schwarzer).
fix indentation
Aug 15 2019, 6:52 PM
schwarzer committed R363:5f29c43e896e: fix some compiler warnings (authored by schwarzer).
fix some compiler warnings
Aug 15 2019, 6:47 PM

Aug 14 2019

schwarzer requested review of D23139: base class function already does what we need.
Aug 14 2019, 12:13 AM
schwarzer requested review of D23138: Simplify code a bit here to remove the duplication.
Aug 14 2019, 12:01 AM

Aug 13 2019

schwarzer committed R363:b68b2fd98c01: do not shadow function name (authored by schwarzer).
do not shadow function name
Aug 13 2019, 11:41 PM
schwarzer added a comment to D23041: Fix some compiler warnings.

Any more complaints/suggestions? I do not know who would be a good assignee for print-manager since several people more or less sporadically work on it.

Aug 13 2019, 10:34 PM

Aug 9 2019

schwarzer updated the diff for D23041: Fix some compiler warnings.

My bad, this should now be the right diff.

Aug 9 2019, 5:21 PM
schwarzer added a comment to D23041: Fix some compiler warnings.

I think I updated to a new diff but it is not showing the new changes ... Any hint?

Aug 9 2019, 2:37 PM
schwarzer updated the diff for D23041: Fix some compiler warnings.

init member in header

Aug 9 2019, 2:31 PM
schwarzer added inline comments to D23041: Fix some compiler warnings.
Aug 9 2019, 2:30 PM
schwarzer requested review of D23041: Fix some compiler warnings.
Aug 9 2019, 12:23 PM

Jul 1 2019

schwarzer committed R883:1545456: translation update.
translation update
Jul 1 2019, 4:55 PM

Jun 26 2019

schwarzer committed R883:1545080: Fix casing.
Fix casing
Jun 26 2019, 10:17 PM

Jun 13 2019

schwarzer abandoned D21756: Replace QMessageBox by KMessageBox.

Committed in 1e656e0051f3919b02f8425632d47f9d332785ab
https://cgit.kde.org/kshisen.git/commit/?id=1e656e0051f3919b02f8425632d47f9d332785ab

Jun 13 2019, 10:11 PM · KDE Games
schwarzer committed R412:1e656e0051f3: Use KMessageBox instead of QMessageBox (authored by schwarzer).
Use KMessageBox instead of QMessageBox
Jun 13 2019, 9:49 PM
schwarzer added a comment to D21756: Replace QMessageBox by KMessageBox.

Yes, I re-read the KF5 porting notes and I guess the KFoo -> QFoo thingy was a misconception based on the deprecation of quite some the KDE 4 KFoo classes.
Thanks for your comments. :)

Jun 13 2019, 9:44 PM · KDE Games

Jun 12 2019

schwarzer added a comment to D21756: Replace QMessageBox by KMessageBox.

Hmm, that was exactly my thought when I saw these Krazy issues. I think to remember exactly the opposite suggestion from a few years ago where Krazy said, we should use the equivalent Qt classes. Am I remembering correctly?

Jun 12 2019, 8:53 AM · KDE Games

Jun 11 2019

schwarzer requested review of D21756: Replace QMessageBox by KMessageBox.
Jun 11 2019, 10:04 PM · KDE Games

Apr 26 2019

schwarzer added inline comments to D20802: Add a layer for showing the removed tiles of the game..
Apr 26 2019, 9:06 AM

Apr 15 2019

schwarzer committed R412:98fed5e8f176: update some best practices definitions (authored by schwarzer).
update some best practices definitions
Apr 15 2019, 10:49 AM

Apr 9 2019

schwarzer committed R883:1539452: fix typo (missed that one).
fix typo (missed that one)
Apr 9 2019, 10:02 AM
schwarzer committed R883:1539451: fix typo.
fix typo
Apr 9 2019, 8:50 AM
schwarzer committed R883:1539450: fix typo.
fix typo
Apr 9 2019, 8:49 AM

Apr 1 2019

schwarzer committed R883:1538772: fix typo.
fix typo
Apr 1 2019, 1:26 PM
schwarzer committed R883:1538771: fix typo.
fix typo
Apr 1 2019, 1:26 PM

Nov 14 2018

schwarzer committed R923:b1e519a16c14: bump version number (authored by schwarzer).
bump version number
Nov 14 2018, 6:41 PM

Jul 23 2018

schwarzer added a comment to D14219: Add a feature to hide translated files on the Project tab.

Thanks indeed. Very useful! :)

Jul 23 2018, 12:33 PM · Localization

Apr 26 2018

schwarzer added inline comments to D12459: [Icon KCM] Port to new design.
Apr 26 2018, 9:16 AM · Plasma
schwarzer added inline comments to D12459: [Icon KCM] Port to new design.
Apr 26 2018, 7:39 AM · Plasma
schwarzer updated subscribers of D12459: [Icon KCM] Port to new design.

@schwarzer I'm changing the catalog name to be more consistent with the other KCMs, is that an issue?

Apr 26 2018, 7:29 AM · Plasma

Apr 18 2018

schwarzer committed R883:1514205: Translation update.
Translation update
Apr 18 2018, 6:02 PM
schwarzer committed R883:1514204: Translation update.
Translation update
Apr 18 2018, 6:01 PM

Apr 4 2018

schwarzer added a comment to D11931: [kiriki] avoid memory leak.

Not sure if it's possible here bit might it be feasible to extent the scores class' c-tor and hang the object into the parent memory management hierarchy?

Apr 4 2018, 7:42 PM

Mar 29 2018

schwarzer added a comment to D11779: General Code clean-up.

Looks good to me. But wait a few more days in case others want to review as well.

Mar 29 2018, 1:05 PM

Mar 25 2018

schwarzer committed R883:1512850: Translation update.
Translation update
Mar 25 2018, 8:40 PM
schwarzer committed R883:1512849: Translation update.
Translation update
Mar 25 2018, 8:40 PM

Mar 24 2018

schwarzer committed R845:04bc16dd0486: fix typos in UI strings (authored by schwarzer).
fix typos in UI strings
Mar 24 2018, 1:50 AM
schwarzer closed D11561: fix typos in UI strings.
Mar 24 2018, 1:50 AM · Plasma
schwarzer added a comment to D11561: fix typos in UI strings.
In D11561#231670, @ivan wrote:

You can also switch to 'can't' as far as I'm concerned

Mar 24 2018, 1:45 AM · Plasma

Mar 21 2018

schwarzer added a reviewer for D11561: fix typos in UI strings: ivan.
Mar 21 2018, 8:19 PM · Plasma
schwarzer requested review of D11561: fix typos in UI strings.
Mar 21 2018, 8:17 PM · Plasma
schwarzer committed R883:1512660: Add missing file.
Add missing file
Mar 21 2018, 8:07 PM
schwarzer committed R883:1512659: Translation update.
Translation update
Mar 21 2018, 8:06 PM
schwarzer committed R883:1512658: Translation update..
Translation update.
Mar 21 2018, 7:58 PM
schwarzer committed R883:1512652: Translation update.
Translation update
Mar 21 2018, 7:01 PM
schwarzer committed R883:1512651: Translation update.
Translation update
Mar 21 2018, 7:00 PM

Mar 11 2018

schwarzer committed R883:1512147: Translation update.
Translation update
Mar 11 2018, 12:55 PM
schwarzer committed R883:1512146: Translation update.
Translation update
Mar 11 2018, 12:55 PM

Feb 17 2018

schwarzer committed R883:1510868: Translation update.
Translation update
Feb 17 2018, 10:13 AM
schwarzer committed R883:1510867: Translation update.
Translation update
Feb 17 2018, 10:13 AM
schwarzer committed R119:160f05b773d6: Fix typo in user-visible string (authored by schwarzer).
Fix typo in user-visible string
Feb 17 2018, 9:44 AM
schwarzer committed R462:8a94ee209754: Fix UI string (authored by schwarzer).
Fix UI string
Feb 17 2018, 9:42 AM
schwarzer committed R462:2648d596b5ef: Fix UI string (authored by schwarzer).
Fix UI string
Feb 17 2018, 9:14 AM

Feb 14 2018

schwarzer added a comment to D10517: Latte-Dock Update (Trunk).

Danke für die Arbeit. :)
Ein paar Nachfragen folgen.

Feb 14 2018, 9:12 PM

Feb 12 2018

schwarzer committed R456:874fa6e5c509: Update wiki URL (authored by schwarzer).
Update wiki URL
Feb 12 2018, 12:25 PM

Feb 11 2018

schwarzer committed R883:1510421: Translation update.
Translation update
Feb 11 2018, 9:56 PM
schwarzer committed R883:1510420: Translation update.
Translation update
Feb 11 2018, 9:55 PM

Feb 8 2018

schwarzer committed R74:1359a12e4c35: fix typos in README (authored by schwarzer).
fix typos in README
Feb 8 2018, 10:20 AM

Jan 17 2018

schwarzer committed R883:1508914: Translation fix: remove extra colon.
Translation fix: remove extra colon
Jan 17 2018, 7:44 PM
schwarzer committed R883:1508913: Translation fix: remove extra colon.
Translation fix: remove extra colon
Jan 17 2018, 7:43 PM

Jan 14 2018

schwarzer committed R412:a319eca9f2bf: Show error message to the user (authored by schwarzer).
Show error message to the user
Jan 14 2018, 10:40 PM
schwarzer closed D9805: Show error message to the user.
Jan 14 2018, 10:40 PM · KDE Games

Jan 11 2018

schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:51 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:49 PM · KDE Games

Jan 10 2018

schwarzer added a comment to D9805: Show error message to the user.
In D9805#189154, @aacid wrote:

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Jan 10 2018, 11:35 PM · KDE Games