sanjibanb (Sanjiban Bairagya)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 8 2015, 7:51 PM (158 w, 3 d)
Availability
Available

Recent Activity

Wed, Aug 29

sanjibanb accepted D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop.
Wed, Aug 29, 6:57 AM · KDE Edu, Marble

Jul 22 2018

sanjibanb accepted D13404: Make it possible to build Marble with KDE Android tooling.
Jul 22 2018, 10:12 PM · KDE Edu, Marble

Jul 15 2018

sanjibanb added a comment to D13404: Make it possible to build Marble with KDE Android tooling.

Cool thanks, I'll update this by 22nd July.

Jul 15 2018, 12:08 PM · KDE Edu, Marble

Jul 8 2018

sanjibanb added a comment to D13404: Make it possible to build Marble with KDE Android tooling.

I was just wondering if there is a way to test these changes locally?

Jul 8 2018, 12:16 AM · KDE Edu, Marble

Jan 6 2018

sanjibanb added a comment to T7680: Promo Sprint: Sign up.
Jan 6 2018, 1:19 AM · KDE Promo

Oct 7 2017

sanjibanb added a comment to T4703: Add a Splash Screen.

Just for info, I added a splash screen, as per https://phabricator.kde.org/D7805 . In case that is not how we intend the final splash screen to look like, we can brainstorm more and work on it, and then close this task when the screen looks done.

Oct 7 2017, 8:35 AM · Marble

Sep 23 2017

sanjibanb committed R34:dc0a67b36225: Remove unnecessary check (authored by sanjibanb).
Remove unnecessary check
Sep 23 2017, 9:37 PM

Sep 18 2017

sanjibanb committed R34:575c6aa78819: Use Torsten's 256x256 version of the png for the splash screen's icon to look… (authored by sanjibanb).
Use Torsten's 256x256 version of the png for the splash screen's icon to look…
Sep 18 2017, 5:51 PM
sanjibanb closed D7805: Add a splash screen to Marble Maps.

One more commit pushed to master: https://commits.kde.org/marble/575c6aa788192d58e71eea6ddd8db228ff854f2b.

Sep 18 2017, 5:47 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Note: The changes showing in the latest diff here does not include the previous changes, but only show the changes that have been made on top of the already committed changes.

Sep 18 2017, 5:38 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Should I push these changes to master in a different commit now?

Sep 18 2017, 5:35 PM · Marble
sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.
Sep 18 2017, 5:32 PM · Marble
sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.

Did a clean build after removing the existing build and export folder and recreating them.

Sep 18 2017, 5:31 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

I had adjusted the values to 256 in that line previously as well, and it was showing the icon in that manner. However, I just did a clean build again from scratch, and the icon looks good now. Maybe earlier it was using cached image from before somehow.

Sep 18 2017, 5:29 PM · Marble

Sep 15 2017

sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

I'm not sure if something.svg can be added to the splash.xml file as drawable/something, because I tried it, and the screen shows blank without any photo in the splash screen.

Sep 15 2017, 9:17 PM · Marble
sanjibanb closed D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Pushed to master: https://commits.kde.org/marble/d60718c0864f7686701ba45585a52ac45b2f79c0

Sep 15 2017, 9:14 PM · Marble
sanjibanb committed R34:d60718c0864f: Fix issue of pressing back-button always leading to closing the app instead of… (authored by sanjibanb).
Fix issue of pressing back-button always leading to closing the app instead of…
Sep 15 2017, 9:12 PM
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Added the 256x256 version of the png that was submitted to master a while back. Doesn't make a difference from earlier wrt the blur.

Sep 15 2017, 9:04 PM · Marble
sanjibanb reopened D7805: Add a splash screen to Marble Maps.

I'll update the diff in a few hours.

Sep 15 2017, 4:41 PM · Marble
sanjibanb added a comment to D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Does this look good enough to be accepted?

Sep 15 2017, 4:21 PM · Marble
sanjibanb committed R34:6b463af73689: Add a splash screen to Marble Maps (authored by sanjibanb).
Add a splash screen to Marble Maps
Sep 15 2017, 4:19 PM
sanjibanb closed D7805: Add a splash screen to Marble Maps.

Pushed to master: https://commits.kde.org/marble/6b463af73689b54af8f8573c7c3fa5d47f752727

Sep 15 2017, 4:18 PM · Marble
sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.

Updating diff so that it shows 100x100 icon now, to get rid of the blur.

Sep 15 2017, 4:06 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Splash screen of Google Maps looks something like this:

Sep 15 2017, 4:00 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Looks to me too that the logo has been scaled up. However, the blur becomes quite negligible if I show just 150x150 imo.

I think we should be okay with the above.

Sep 15 2017, 3:53 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Looks like the highest resolution of the Marble logo that we have at the moment is 192 x 192: https://github.com/KDE/marble/blob/master/data/android/drawable-xxxhdpi/marblelogo.png . We can reduce the size to 192x192 to get rid of the blur, in which case it would look something like this.

Looks good?

Sep 15 2017, 3:18 PM · Marble
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Screenshot of the current splash screen

Sep 15 2017, 11:20 AM · Marble
sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.

Increased the size of Marble logo in the splash screen to 256x256

Sep 15 2017, 11:13 AM · Marble
sanjibanb closed D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.

Pushed to master: https://commits.kde.org/marble/418d9fc56a368de709868499624b67b0214bfadb

Sep 15 2017, 6:17 AM · Marble
sanjibanb committed R34:418d9fc56a36: Make the bookmarks dialog responsive to touch everywhere in Marble Maps. (authored by sanjibanb).
Make the bookmarks dialog responsive to touch everywhere in Marble Maps.
Sep 15 2017, 6:16 AM

Sep 14 2017

sanjibanb added a comment to D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.

Cool, I think I can wait till the end of the day for Judit to verify this. If there are no concerns by then, I can push this commit tomorrow morning so that Judit can look into the changes after that.

Sep 14 2017, 6:12 PM · Marble
sanjibanb created D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.
Sep 14 2017, 1:06 PM · Marble
sanjibanb committed R34:dbdb53bca0b6: Clean code + fix indentation in MainScreen (authored by sanjibanb).
Clean code + fix indentation in MainScreen
Sep 14 2017, 12:53 PM
sanjibanb added a comment to D7805: Add a splash screen to Marble Maps.

Not the best splash screen I'd say. I'm just showing a small marble logo on a white background. Feel free to recommend better designs, if possible?

Sep 14 2017, 7:29 AM · Marble

Sep 13 2017

sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.
Sep 13 2017, 7:31 PM · Marble
sanjibanb updated the diff for D7805: Add a splash screen to Marble Maps.
Sep 13 2017, 7:25 PM · Marble
sanjibanb created D7805: Add a splash screen to Marble Maps.
Sep 13 2017, 4:59 PM · Marble

Sep 12 2017

sanjibanb created D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.
Sep 12 2017, 7:20 AM · Marble

Jun 20 2017

sanjibanb placed T4703: Add a Splash Screen up for grabs.

Keeping the task open so that others don't feel blocked to work on it as well.

Jun 20 2017, 4:19 PM · Marble

Jun 18 2017

sanjibanb claimed T4703: Add a Splash Screen.
Jun 18 2017, 6:38 PM · Marble
sanjibanb closed T1920: Change style of highways with restricted access as Resolved.
Jun 18 2017, 9:04 AM · Marble

Jun 15 2017

sanjibanb closed D2862: Current settings should be saved on killing app too (not only on closing app).

Pushed to master with commit https://commits.kde.org/marble/d00d4b8db4af30a6582b5df5dcc6f692cfb88d27

Jun 15 2017, 9:44 AM · Marble
sanjibanb committed R34:d00d4b8db4af: Save settings when user kills the Marble Maps app in Android (authored by sanjibanb).
Save settings when user kills the Marble Maps app in Android
Jun 15 2017, 9:18 AM

Jun 13 2017

sanjibanb updated the diff for D2862: Current settings should be saved on killing app too (not only on closing app).

Makes sense. I modified the patch so that it only saves settings in suspended and inactive states, but not load them during any state change, and verified that it still resolves the issue.

Jun 13 2017, 8:39 PM · Marble

May 26 2017

sanjibanb updated the diff for D2862: Current settings should be saved on killing app too (not only on closing app).

Updating diff to latest code.

May 26 2017, 3:31 AM · Marble
sanjibanb added reviewers for D1259: Allow to assign a z-Order to files: rahn, kossebau.
May 26 2017, 3:15 AM · Marble
sanjibanb removed a reviewer for D1259: Allow to assign a z-Order to files: rahn.
May 26 2017, 3:05 AM · Marble

Feb 20 2017

sanjibanb committed R34:3f99bc3b7e9f: Fix spelling "unites" -> "units" (authored by sanjibanb).
Fix spelling "unites" -> "units"
Feb 20 2017, 10:25 PM

Sep 27 2016

sanjibanb closed D2864: Remove overlap between route-editor button and bookmark button.

Pushed with commit http://commits.kde.org/marble/cc8406238d29477478c0ade0672123d510bc5050

Sep 27 2016, 5:23 AM · Marble
sanjibanb committed R34:cc8406238d29: Remove overlap between route-editor button and bookmark button (authored by sanjibanb).
Remove overlap between route-editor button and bookmark button
Sep 27 2016, 5:21 AM

Sep 26 2016

sanjibanb added reviewers for D2864: Remove overlap between route-editor button and bookmark button: nienhueser, rahn, kossebau.
Sep 26 2016, 10:36 PM · Marble
sanjibanb updated the diff for D2862: Current settings should be saved on killing app too (not only on closing app).

Add braces

Sep 26 2016, 8:54 PM · Marble
sanjibanb added reviewers for D2862: Current settings should be saved on killing app too (not only on closing app): nienhueser, rahn, kossebau.
Sep 26 2016, 8:43 PM · Marble
sanjibanb closed D2861: When user opens app and lands on a portion of map which contains his current position, make position marker visible.

Pushed with commit http://commits.kde.org/marble/4e862bbfc4bbe432ecc981e5a5008ad59a7adb27

Sep 26 2016, 8:25 PM · Marble
sanjibanb committed R34:4e862bbfc4bb: When user opens app and lands on a portion of map which contains user's current… (authored by sanjibanb).
When user opens app and lands on a portion of map which contains user's current…
Sep 26 2016, 8:25 PM
sanjibanb updated D2861: When user opens app and lands on a portion of map which contains his current position, make position marker visible.
Sep 26 2016, 8:04 PM · Marble
sanjibanb added reviewers for D2861: When user opens app and lands on a portion of map which contains his current position, make position marker visible: nienhueser, rahn, kossebau.
Sep 26 2016, 7:56 PM · Marble
sanjibanb committed R34:220ce8f3c112: Correct indentation (authored by sanjibanb).
Correct indentation
Sep 26 2016, 7:45 PM
sanjibanb committed R34:b9e355c87a99: Center on current position when application starts, if no coordinates were… (authored by sanjibanb).
Center on current position when application starts, if no coordinates were…
Sep 26 2016, 5:06 PM
sanjibanb closed D2855: Center on current position when application starts, if no coordinates were saved from before.

Pushed with http://commits.kde.org/marble/b9e355c87a995ee751d75f5c941479a2b51e9fa5

Sep 26 2016, 5:05 PM · Marble
sanjibanb updated the diff for D2855: Center on current position when application starts, if no coordinates were saved from before.
Sep 26 2016, 12:18 PM · Marble
sanjibanb updated subscribers of D2855: Center on current position when application starts, if no coordinates were saved from before.
Sep 26 2016, 9:30 AM · Marble
sanjibanb retitled D2855: Center on current position when application starts, if no coordinates were saved from before from to Center on current position on application start.
Sep 26 2016, 9:28 AM · Marble

Sep 24 2016

sanjibanb committed R34:37fc703d3108: Revert "Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h}" (authored by sanjibanb).
Revert "Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h}"
Sep 24 2016, 7:35 PM
sanjibanb added a reverting change for R34:1368ec36ded8: Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h}: R34:37fc703d3108: Revert "Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h}".
Sep 24 2016, 7:35 PM
sanjibanb committed R34:1368ec36ded8: Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h} (authored by sanjibanb).
Kml_scaleTagHandler{.cpp, .h} -> KmlScaleTagHandler{.cpp, .h}
Sep 24 2016, 7:29 PM
sanjibanb committed R34:a8f0f4b72ff2: Allow implicit linking to qtnetwork for build to work even without webkit (authored by sanjibanb).
Allow implicit linking to qtnetwork for build to work even without webkit
Sep 24 2016, 6:30 PM

Sep 10 2016

sanjibanb committed R34:d30d0f5003d7: Added a cmake warning to CMakeLists.text that warns about the qt5 branch being… (authored by sanjibanb).
Added a cmake warning to CMakeLists.text that warns about the qt5 branch being…
Sep 10 2016, 4:02 AM

Aug 14 2016

sanjibanb closed D2439: Render aeroway apron areas.

Thanks. Pushed.

Aug 14 2016, 8:26 AM · Marble
sanjibanb committed R34:147e58f103dd: Render aeroway apron areas (authored by sanjibanb).
Render aeroway apron areas
Aug 14 2016, 8:25 AM
sanjibanb updated the diff for D2439: Render aeroway apron areas.
Aug 14 2016, 8:09 AM · Marble
sanjibanb added inline comments to D2439: Render aeroway apron areas.
Aug 14 2016, 8:08 AM · Marble

Aug 13 2016

sanjibanb added reviewers for D2439: Render aeroway apron areas: nienhueser, rahn.
Aug 13 2016, 10:07 PM · Marble
sanjibanb closed D2432: Highways do not need icons, so remove it altogether.

Pushed

Aug 13 2016, 7:32 AM · Marble
sanjibanb committed R34:04a1e23c2a21: Highways do not need icons, so remove them altogether (authored by sanjibanb).
Highways do not need icons, so remove them altogether
Aug 13 2016, 7:31 AM
sanjibanb added reviewers for D2432: Highways do not need icons, so remove it altogether: nienhueser, rahn.
Aug 13 2016, 6:04 AM · Marble

Aug 11 2016

sanjibanb committed R34:dc4bf4b2b7b1: Fix typo (authored by sanjibanb).
Fix typo
Aug 11 2016, 8:24 PM
sanjibanb committed R34:bcf1f53b0621: Render aeroway taxiways (authored by sanjibanb).
Render aeroway taxiways
Aug 11 2016, 7:17 PM

Aug 8 2016

sanjibanb closed T3345: Airport Runway Rendering as Resolved.

Task is completed with commit https://phabricator.kde.org/rMARBLEf4ae0754dead3039f4663b664dda64301faad0ec

Aug 8 2016, 7:48 PM · Marble
sanjibanb claimed T3345: Airport Runway Rendering.
Aug 8 2016, 7:47 PM · Marble
sanjibanb committed R34:f4ae0754dead: Add a visual category for aeroway runways, extract and render them in Vector OSM (authored by sanjibanb).
Add a visual category for aeroway runways, extract and render them in Vector OSM
Aug 8 2016, 7:38 PM
sanjibanb closed D2368: Add a visual category for aeroway runways, extract and render them in Vector OSM.

Pushed

Aug 8 2016, 7:37 PM · Marble
sanjibanb added reviewers for D2368: Add a visual category for aeroway runways, extract and render them in Vector OSM: nienhueser, rahn.
Aug 8 2016, 7:24 AM · Marble

Aug 7 2016

sanjibanb committed R34:9cf50760efce: Separate the amenity and shop details in the Android version's placemark dialog (authored by sanjibanb).
Separate the amenity and shop details in the Android version's placemark dialog
Aug 7 2016, 12:11 AM

Aug 6 2016

sanjibanb closed D2315: Show Shop info, or if not present, amenity info, in the placemark dialog in the Android version.

Yeah, I think so too. I will make two separate sections soon (one for amenities, and other for shop or other information). Pushing this for now.

Aug 6 2016, 12:11 PM · Marble
sanjibanb committed R34:5752f751d64f: Show Shop info, or if not present, amenity info, in the placemark dialog in… (authored by sanjibanb).
Show Shop info, or if not present, amenity info, in the placemark dialog in…
Aug 6 2016, 12:08 PM

Jul 30 2016

sanjibanb added reviewers for D2315: Show Shop info, or if not present, amenity info, in the placemark dialog in the Android version: nienhueser, rahn.
Jul 30 2016, 5:17 PM · Marble
sanjibanb closed D2311: In Desktop version's OSM popup, for clothes shops, show which clothes they sell as well.

Pushed

Jul 30 2016, 5:16 AM · Marble
sanjibanb committed R34:a7ff38fe01b9: For clothes shops, show which clothes they sell as well, in the Desktop… (authored by sanjibanb).
For clothes shops, show which clothes they sell as well, in the Desktop…
Jul 30 2016, 5:10 AM
sanjibanb updated the diff for D2311: In Desktop version's OSM popup, for clothes shops, show which clothes they sell as well.

Add empty-string check for ele

Jul 30 2016, 4:33 AM · Marble
sanjibanb added reviewers for D2311: In Desktop version's OSM popup, for clothes shops, show which clothes they sell as well: nienhueser, rahn.
Jul 30 2016, 4:29 AM · Marble

Jul 28 2016

sanjibanb committed R34:b73527b1f6e5: Show elevation of peaks in the placemark dialog in the Android version and in… (authored by sanjibanb).
Show elevation of peaks in the placemark dialog in the Android version and in…
Jul 28 2016, 8:07 PM

Jul 25 2016

sanjibanb committed R34:f82e3a66842a: Move categoryName() out of declarative/Placemark.cpp into GeoDataFeature.cpp (authored by sanjibanb).
Move categoryName() out of declarative/Placemark.cpp into GeoDataFeature.cpp
Jul 25 2016, 6:17 PM
sanjibanb closed D2280: Move categoryName() out of declarative/Placemark.cpp into GeoDataFeature.cpp.

Thanks. Pushed :)

Jul 25 2016, 6:15 PM · Marble
sanjibanb added reviewers for D2280: Move categoryName() out of declarative/Placemark.cpp into GeoDataFeature.cpp: nienhueser, rahn.
Jul 25 2016, 6:13 AM · Marble

Jul 24 2016

sanjibanb closed D2249: Make a special dedicated popup for OpenStreetMap data in the Desktop version.

Pushed. Commit for remaining tweaking issues coming up soon.

Jul 24 2016, 1:26 PM · Marble
sanjibanb committed R34:4213c996dba3: Make a special dedicated popup for OpenStreetMap data in the Desktop version (authored by sanjibanb).
Make a special dedicated popup for OpenStreetMap data in the Desktop version
Jul 24 2016, 1:25 PM
sanjibanb updated the diff for D2249: Make a special dedicated popup for OpenStreetMap data in the Desktop version.

Follow convention

Jul 24 2016, 9:02 AM · Marble
sanjibanb updated the diff for D2249: Make a special dedicated popup for OpenStreetMap data in the Desktop version.

Fix issues from the previous revision.

Jul 24 2016, 9:00 AM · Marble
sanjibanb updated the diff for D2249: Make a special dedicated popup for OpenStreetMap data in the Desktop version.

Add svg showing the amenity type, on the top-right corner of the popup

Jul 24 2016, 8:02 AM · Marble