- User Since
- Sep 8 2015, 7:51 PM (232 w, 4 d)
Nov 12 2019
Oct 31 2019
Oct 30 2019
Jul 4 2019
Apr 24 2019
Nov 13 2018
Aug 29 2018
Jul 22 2018
Jul 15 2018
Cool thanks, I'll update this by 22nd July.
Jul 8 2018
I was just wondering if there is a way to test these changes locally?
Jan 6 2018
Oct 7 2017
Just for info, I added a splash screen, as per https://phabricator.kde.org/D7805 . In case that is not how we intend the final splash screen to look like, we can brainstorm more and work on it, and then close this task when the screen looks done.
Sep 23 2017
Sep 18 2017
One more commit pushed to master: https://commits.kde.org/marble/575c6aa788192d58e71eea6ddd8db228ff854f2b.
Note: The changes showing in the latest diff here does not include the previous changes, but only show the changes that have been made on top of the already committed changes.
Should I push these changes to master in a different commit now?
Did a clean build after removing the existing build and export folder and recreating them.
I had adjusted the values to 256 in that line previously as well, and it was showing the icon in that manner. However, I just did a clean build again from scratch, and the icon looks good now. Maybe earlier it was using cached image from before somehow.
Sep 15 2017
I'm not sure if something.svg can be added to the splash.xml file as drawable/something, because I tried it, and the screen shows blank without any photo in the splash screen.
Pushed to master: https://commits.kde.org/marble/d60718c0864f7686701ba45585a52ac45b2f79c0
Added the 256x256 version of the png that was submitted to master a while back. Doesn't make a difference from earlier wrt the blur.
I'll update the diff in a few hours.
Does this look good enough to be accepted?
Pushed to master: https://commits.kde.org/marble/6b463af73689b54af8f8573c7c3fa5d47f752727
Updating diff so that it shows 100x100 icon now, to get rid of the blur.
Splash screen of Google Maps looks something like this:
Looks to me too that the logo has been scaled up. However, the blur becomes quite negligible if I show just 150x150 imo.I think we should be okay with the above.
Looks like the highest resolution of the Marble logo that we have at the moment is 192 x 192: https://github.com/KDE/marble/blob/master/data/android/drawable-xxxhdpi/marblelogo.png . We can reduce the size to 192x192 to get rid of the blur, in which case it would look something like this.Looks good?
Screenshot of the current splash screen
Increased the size of Marble logo in the splash screen to 256x256
Pushed to master: https://commits.kde.org/marble/418d9fc56a368de709868499624b67b0214bfadb
Sep 14 2017
Cool, I think I can wait till the end of the day for Judit to verify this. If there are no concerns by then, I can push this commit tomorrow morning so that Judit can look into the changes after that.
Not the best splash screen I'd say. I'm just showing a small marble logo on a white background. Feel free to recommend better designs, if possible?
Sep 13 2017
Sep 12 2017
Jun 20 2017
Keeping the task open so that others don't feel blocked to work on it as well.
Jun 18 2017
Jun 15 2017
Pushed to master with commit https://commits.kde.org/marble/d00d4b8db4af30a6582b5df5dcc6f692cfb88d27
Jun 13 2017
Makes sense. I modified the patch so that it only saves settings in suspended and inactive states, but not load them during any state change, and verified that it still resolves the issue.
May 26 2017
Updating diff to latest code.
Feb 20 2017
Sep 27 2016
Pushed with commit http://commits.kde.org/marble/cc8406238d29477478c0ade0672123d510bc5050
Sep 26 2016
Pushed with commit http://commits.kde.org/marble/4e862bbfc4bbe432ecc981e5a5008ad59a7adb27
Sep 24 2016
Sep 10 2016
Aug 14 2016
Aug 13 2016
Aug 11 2016
Aug 8 2016
Task is completed with commit https://phabricator.kde.org/rMARBLEf4ae0754dead3039f4663b664dda64301faad0ec
Aug 7 2016
Aug 6 2016
Yeah, I think so too. I will make two separate sections soon (one for amenities, and other for shop or other information). Pushing this for now.
Jul 30 2016
Add empty-string check for ele