Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios
ClosedPublic

Authored by sanjibanb on Sep 14 2017, 1:06 PM.

Details

Reviewers
rahn
Group Reviewers
Marble
Summary

All the code logic that has been written under the onClosing: scope is not even considered, if we use Kirigami.ApplicationWindow . Using Kirigami.AbstractApplicationWindow instead to fix the same.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
sanjibanb created this revision.Sep 14 2017, 1:06 PM
rahn added a subscriber: rahn.Sep 14 2017, 5:06 PM
rahn added a subscriber: juditbartha.

Looks fine to me. Maybe Judit can confirm this patch?

Looks fine to me, great to see it being improved!

Does this look good enough to be accepted?

rahn accepted this revision.Sep 15 2017, 4:32 PM

Please commit.

This revision is now accepted and ready to land.Sep 15 2017, 4:32 PM