Differential D16866

Include a comment to the desktop file
ClosedPublic
Actions

Authored by apol on Nov 13 2018, 3:40 PM.

Details

Reviewers
kossebau
sanjibanb
Group Reviewers
Marble
Commits
R34:bc32ed4ef08d: Include a comment to the desktop file
Summary

Otherwise the appstream file won't have a summary and appstream complains.

CCBUG: 400431

Diff Detail

Repository
R34 Marble
Branch
Applications/18.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4907
Build 4925: arc lint + arc unit
apol created this revision.Nov 13 2018, 3:40 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptNov 13 2018, 3:40 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
apol requested review of this revision.Nov 13 2018, 3:40 PM
sanjibanb accepted this revision as: sanjibanb.Nov 13 2018, 7:17 PM
This revision is now accepted and ready to land.Nov 13 2018, 7:17 PM
apol closed this revision.Nov 21 2018, 2:49 AM
rikmills added a subscriber: rikmills.Nov 22 2018, 12:52 AM

I think this is needed in 18.12 branch as well?

Without it, the latest change in kpackage master means the appstream data xml file is not getting generated, and hence a packaging error on that going missing.

apol added subscribers: aacid, ltoscano.Nov 22 2018, 1:05 AM

I'm fine with backporting to 18.12, it would mean there will be a new string altogether.

You'll be getting a packaging error now because you were ignoring the appstream error this was producing after all.

Ideas @ltoscano or @aacid?

rikmills removed a subscriber: rikmills.Nov 22 2018, 1:15 AM
aacid added a comment.Nov 22 2018, 10:26 PM

https://community.kde.org/Schedules/Applications/18.12_Release_Schedule says " Bugfixes needing user visible text changes need approval from kde-i18n-doc@kde.org "

ltoscano added a subscriber: kde-i18n-doc.Nov 22 2018, 10:44 PM

Translators, what do you think about this request for a string exception for Applications/18.12?

Developers, is there an alternative to this change, apart from reverting https://phabricator.kde.org/D16867 in Frameworks?

lueck added a subscriber: lueck.Nov 23 2018, 5:48 AM
In D16866#364478, @ltoscano wrote:

Translators, what do you think about this request for a string exception for Applications/18.12?

backporting to 18.12 is OK for the german team

yurchor added a subscriber: yurchor.Nov 23 2018, 6:22 AM
In D16866#364478, @ltoscano wrote:

Translators, what do you think about this request for a string exception for Applications/18.12?

No objections to backporting from Ukrainian team.

adrianchavesfernandez added a subscriber: adrianchavesfernandez.EditedNov 23 2018, 3:56 PM
In D16866#364478, @ltoscano wrote:

Translators, what do you think about this request for a string exception for Applications/18.12?

No objection from gl.

Revision Contents
Changeset List

Diff 45417

View Options

src/plasma/wallpapers/worldmap/metadata.desktop

Loading...