Make it possible to build Marble with KDE Android tooling
ClosedPublic

Authored by apol on Jun 7 2018, 12:30 PM.

Details

Summary

It will allow to have it built by the CI and appear on
binary-factory.kde.org.

Depends on D13403

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jun 7 2018, 12:30 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptJun 7 2018, 12:30 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
apol requested review of this revision.Jun 7 2018, 12:30 PM
apol added a comment.Jun 7 2018, 12:32 PM

I intentionally left the old logic so it doesn't break your work-flow but it should allow to remove quite some code.

Also I didn't really understand what's going on with these python scripts.

apol added a comment.Jul 4 2018, 3:04 PM

Can I please have a review?

I was just wondering if there is a way to test these changes locally?

src/apps/marble-maps/package/AndroidManifest.xml
22

Not too important, but can we change it from "Marble" to "MarbleMaps"? This would help distinguish it as the Android app and not the Desktop version.

Making similar changes in marble-maps/CMakeLists.txt as well would help retain this consistency.

apol added a comment.Jul 12 2018, 2:41 PM

I was just wondering if there is a way to test these changes locally?

Sure!
https://community.kde.org/Android/Environment_via_Container

src/apps/marble-maps/package/AndroidManifest.xml
22

It's the target name. I really don't mind what we call it. Just needs to be the same as passed to add_executable.

Cool thanks, I'll update this by 22nd July.

sanjibanb accepted this revision as: sanjibanb.Jul 22 2018, 10:12 PM
This revision is now accepted and ready to land.Jul 22 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.