It will allow to have it built by the CI and appear on
binary-factory.kde.org.
Depends on D13403
sanjibanb |
Marble |
It will allow to have it built by the CI and appear on
binary-factory.kde.org.
Depends on D13403
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I intentionally left the old logic so it doesn't break your work-flow but it should allow to remove quite some code.
Also I didn't really understand what's going on with these python scripts.
I was just wondering if there is a way to test these changes locally?
src/apps/marble-maps/package/AndroidManifest.xml | ||
---|---|---|
22 | Not too important, but can we change it from "Marble" to "MarbleMaps"? This would help distinguish it as the Android app and not the Desktop version. Making similar changes in marble-maps/CMakeLists.txt as well would help retain this consistency. |
I was just wondering if there is a way to test these changes locally?
Sure!
https://community.kde.org/Android/Environment_via_Container
src/apps/marble-maps/package/AndroidManifest.xml | ||
---|---|---|
22 | It's the target name. I really don't mind what we call it. Just needs to be the same as passed to add_executable. |