Differential D19330

fix failing DMS-String parsing on windows
ClosedPublic
Actions

Authored by mkoller on Feb 26 2019, 10:30 AM.

Details

Reviewers
rahn
nienhueser
sanjibanb
kossebau
Group Reviewers
Marble: General
Commits
R34:bf90ef0232b6: fix failing DMS-String parsing on windows
Summary

This patch marks unicode strings so that the compiler (on windows) can correctly use them.

Without the patch, ~6000 tests failed for the TestGeoDataCoordinates,
with the patch zero.

Test Plan

tested on windows and Linux

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Feb 26 2019, 10:30 AM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptFeb 26 2019, 10:30 AM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
mkoller requested review of this revision.Feb 26 2019, 10:30 AM
kossebau resigned from this revision.Jul 4 2019, 1:59 PM

Currently no time for Marble, so resigning.

sanjibanb accepted this revision as: sanjibanb.Jul 4 2019, 2:50 PM
This revision is now accepted and ready to land.Jul 4 2019, 2:50 PM
Closed by commit R34:bf90ef0232b6: fix failing DMS-String parsing on windows (authored by mkoller). · Explain WhyJul 22 2019, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62263

View Options

src/lib/marble/geodata/data/LonLatParser.cpp

Loading...