Render aeroway apron areas
ClosedPublic
Actions

Authored by sanjibanb on Aug 13 2016, 10:07 PM.

Details

Reviewers

nienhueser
rahn

Diff Detail

Repository

R34 Marble

Lint

Lint Skipped

Unit

Unit Tests Skipped

sanjibanb updated this revision to Diff 5899.Aug 13 2016, 10:07 PM

sanjibanb retitled this revision from to Render aeroway apron areas.

sanjibanb updated this object.

sanjibanb edited the test plan for this revision. (Show Details)

sanjibanb added reviewers: nienhueser, rahn.

sanjibanb set the repository for this revision to R34 Marble.

sanjibanb added a project: Marble.

sanjibanb added a subscriber: Marble.

Looks good, but rendering-wise I'd prefer to render highways on top of it (i.e. add an appropriate entry in StyleBuilder::renderOrder() that places it below of highways).

src/lib/marble/StyleBuilder.cpp
673	I'd render it like osm-carto without an outline. Changing the last parameter to false should accomplish that.

sanjibanb marked an inline comment as done.Aug 14 2016, 8:08 AM

sanjibanb added inline comments.

src/lib/marble/StyleBuilder.cpp
673	Okay. Changed that and made the outline color Qt::transparent as well.

sanjibanb updated this revision to Diff 5903.Aug 14 2016, 8:09 AM

sanjibanb edited edge metadata.

sanjibanb marked an inline comment as done.

Please push.

This revision is now accepted and ready to land.Aug 14 2016, 8:23 AM

Thanks. Pushed.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/marble/PlacemarkLayout.cpp (1 line)
M			src/lib/marble/StyleBuilder.cpp (6 lines)
M			src/lib/marble/geodata/data/GeoDataFeature.h (1 line)
M			src/lib/marble/geodata/data/GeoDataFeature_p.h (1 line)
M			src/lib/marble/osm/OsmPresetLibrary.cpp (1 line)
M			src/plugins/runner/local-osm-search/DatabaseQuery.cpp (2 lines)
M			src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp (1 line)
M			src/plugins/runner/local-osm-search/OsmPlacemark.h (1 line)