Differential D7779

Make the bookmarks dialog responsive to touch everywhere in Marble Maps
ClosedPublic
Actions

Authored by sanjibanb on Sep 12 2017, 7:20 AM.

Details

Reviewers
juditbartha
rahn
Group Reviewers
Marble
Summary

When we tap on the Search field in the app, if nothing is written in that field then the bookmarks dialog show up. If the number of bookmarks is <= 6, then the far-lower part of the dialog does nothing on being tapped. Made that portion choose the last item from the bookmarks list in that case.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
sanjibanb created this revision.Sep 12 2017, 7:20 AM
rahn accepted this revision.Sep 14 2017, 5:17 PM
rahn added a reviewer: juditbartha.
rahn added a subscriber: juditbartha.
rahn added a subscriber: rahn.

Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)

This revision is now accepted and ready to land.Sep 14 2017, 5:18 PM
sanjibanb added a comment.Sep 14 2017, 6:12 PM

Cool, I think I can wait till the end of the day for Judit to verify this. If there are no concerns by then, I can push this commit tomorrow morning so that Judit can look into the changes after that.

Revision Contents
Changeset List

PathPackages
Msrc/apps/marble-maps/Search.qml (18 lines)

Diff 19434

View Options

src/apps/marble-maps/Search.qml

Loading...