Include all accounts in channel list
Needs ReviewPublic

Authored by olivierjg on Sat, May 9, 10:46 PM.

Details

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27059
Build 27077: arc lint + arc unit
olivierjg requested review of this revision.Sat, May 9, 10:46 PM
olivierjg created this revision.
mlaurent requested changes to this revision.Sun, May 10, 7:57 AM

Hi,
As told you previously yes if it's configurable but no it's not.
For the moment with this patch we can't have configure show it as previously.

Currently when we logout an account we can't see other account,
We can't change status for specific account.
We can't know in which account we search channel or create channel etc.

Regards.

This revision now requires changes to proceed.Sun, May 10, 7:57 AM

As told you previously yes if it's configurable but no it's not.
For the moment with this patch we can't have configure show it as previously.

I'm not really interesting in abstracting/copying as needed to do that and maintaining the result. If this isn't wanted for the UI I'll just throw it in a branch for personal use.

Currently when we logout an account we can't see other account,

I don't understand this.

We can't change status for specific account.

Yes, we can.

We can't know in which account we search channel or create channel etc.

This is the same as before. I'm thinking of maybe bolding the current account/channel for added clarity though.

There are other UI improvements that can continue to make this work better of course, but I think it's better to add this which is already quite usable and build on it from there.

mwolff added a subscriber: mwolff.Thu, May 14, 2:40 PM

I've been using this for 24 hours now.

Indeed there's the issue that if someone talks to me in another account than the one that's visible on screen, and I miss the notification, then I'll never see it.
I'm used to "Unread on top" which means I never need to scroll down to find unread channels, but this tree view makes that necessary again.
Without this patch, the buttons did show that information.

There's also a small regression: after I mark a channel as read [and it moves back down, due to the "unread on top" option], the tree will mark another channel as current. At that point the actual current channel (the one shown in the message list) is different from the one selected in the tree, which is very confusing.

I think this is a great step forwards. the only thing that's missing is a joined "unread" category on top. right now, one has to scroll a lot to find unread/pinged channels in other accounts, when a large account (like our kdab one) is sitting on top

src/core/model/rocketchataccountmodel.cpp
137

this looks odd with dark color schemes - maybe no flag at all when nothing is there?

personally I would even prefer no icons here at all and just use the same kind of (1) markers we have for channels to show the unreads and alert status?

olivierjg updated this revision to Diff 83117.Fri, May 22, 3:58 PM

Keep the current channel selected