Feed Advanced Search

Yesterday

mwolff updated the diff for D7921: Reuse the same data when inReplyTo and References are equal.

depend on new KMime

Fri, Sep 22, 7:16 PM · KDE PIM
mwolff updated the diff for D7920: Add KMime::Ident::fromIdent.

bumb PIM_VERSION

Fri, Sep 22, 7:16 PM · KDE PIM
mwolff committed R165:fc8db03b57f2: Introduce MimeTypeChecker::hasWantedMimeTypes (authored by mwolff).
Introduce MimeTypeChecker::hasWantedMimeTypes
Fri, Sep 22, 7:12 PM
mwolff closed D7916: Introduce MimeTypeChecker::hasWantedMimeTypes.
Fri, Sep 22, 7:12 PM · KDE PIM
mwolff added a comment to D7916: Introduce MimeTypeChecker::hasWantedMimeTypes.

Done, I presume you'll merge that into master?

Fri, Sep 22, 7:12 PM · KDE PIM
mwolff added a comment to D7921: Reuse the same data when inReplyTo and References are equal.

do I need to change anything in the CMakeLists.txt to ensure the up2date kmime is found? or are these repos all implicitly depending on each other anyways?

Fri, Sep 22, 11:55 AM · KDE PIM
mwolff added a comment to D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

And btw: I'm in favor of the concept, i.e. to use canonical paths everywhere. I've run into issues myself, but I wonder why I'm not seeing the issue you are referencing here. My paths are also containing symlinks. It sounds to me like you are solving a fringe case (i.e. changing paths after the fact). I'm all for handling this gracefully, but to ensure it won't break in the future, we will need a unit test. That will also show us what actually is broken.

Fri, Sep 22, 11:23 AM · KDevelop
mwolff added a comment to D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

please write a unit test

Fri, Sep 22, 11:09 AM · KDevelop

Thu, Sep 21

mwolff added a comment to D7916: Introduce MimeTypeChecker::hasWantedMimeTypes.

what branch is "stable"? 1.9?

Thu, Sep 21, 3:54 PM · KDE PIM
mwolff created D7921: Reuse the same data when inReplyTo and References are equal.
Thu, Sep 21, 3:28 PM · KDE PIM
mwolff created D7920: Add KMime::Ident::fromIdent.
Thu, Sep 21, 3:27 PM · KDE PIM
mwolff created D7916: Introduce MimeTypeChecker::hasWantedMimeTypes.
Thu, Sep 21, 2:54 PM · KDE PIM
mwolff committed R32:f6e3d8b92402: Prefer the first available compiler as default compiler (authored by mwolff).
Prefer the first available compiler as default compiler
Thu, Sep 21, 12:53 PM
mwolff committed R32:ea3cb5a898f1: Workaround parse errors due to missing implementation of __has_include (authored by mwolff).
Workaround parse errors due to missing implementation of __has_include
Thu, Sep 21, 12:46 PM
mwolff committed R32:bbc57107abc9: Dump defines file when KDEV_CLANG_DISPLAY_DEFINES is set (authored by mwolff).
Dump defines file when KDEV_CLANG_DISPLAY_DEFINES is set
Thu, Sep 21, 12:46 PM
mwolff accepted D7879: [KConfigGroup] reserve() more and add some C++11.

ah ok, and since we don't have a proper byte array view yet, there's nothing you can do (which is sad here!)

Thu, Sep 21, 8:39 AM · Frameworks

Wed, Sep 20

mwolff committed R223:ec795473fa64: Make compile with strict iterators (authored by mwolff).
Make compile with strict iterators
Wed, Sep 20, 2:35 PM
mwolff committed R223:9d0cc7528ff8: Make compile with strict iterators (authored by mwolff).
Make compile with strict iterators
Wed, Sep 20, 2:35 PM
mwolff committed R365:a18179354bc3: Use vkrause's libkolab fork, upstream doesn't compile (authored by mwolff).
Use vkrause's libkolab fork, upstream doesn't compile
Wed, Sep 20, 8:59 AM
mwolff added a comment to D7876: Append project compiler arguments after arguments from build system anddisable warning as error.

+1 if this improves the situation, but in general I was suspecting such issues while reviewing the initial changeset. I suspect we'll see more issues in the future, and I have no clear idea on how to handle that :(

Wed, Sep 20, 7:47 AM

Tue, Sep 19

mwolff added a comment to T7040: Drop KFilePlacesModel fork.

I think the grouping should be moved upstream into the model, too and then be used for file open dialogs to make that visually more similar to what dolphin shows.

Tue, Sep 19, 5:11 PM · Frameworks, Dolphin
mwolff requested changes to D7879: [KConfigGroup] reserve() more and add some C++11.

it would probably be a good idea to rewrite KConfigGroupPrivate::serializeList to not take a QVariantList, but rather to use a streaming API. I.e. instead of:

Tue, Sep 19, 3:21 PM · Frameworks

Mon, Sep 18

mwolff added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

The difference you describe between cmake server mode vs. no server mode once again shows that you have not yet fully grasped what's going on here and that this patch as it stands is not the right fix. Find out why the cmake server mode degrades the performance, than fix that. You say:

Mon, Sep 18, 1:13 PM · KDevelop

Thu, Sep 14

mwolff accepted D7799: Type Alias Template fix.

thanks, lgtm - do you have commit rights?

Thu, Sep 14, 11:05 AM · KDevelop

Wed, Sep 13

mwolff accepted D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

ok, let's try this out :) What Could Possibly Go Wrong?

Wed, Sep 13, 7:30 PM
mwolff requested changes to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

could we get a unit test? but otherwise lgtm, minus the one issue I found (sorry :P)

Wed, Sep 13, 1:30 PM
mwolff requested changes to D7799: Type Alias Template fix.

overall lgtm, I'd also like to see some unit test coverage please

Wed, Sep 13, 1:24 PM · KDevelop
mwolff requested changes to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.
Wed, Sep 13, 8:15 AM

Tue, Sep 12

mwolff requested changes to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.
Tue, Sep 12, 3:37 PM
mwolff committed R45:7415a12b10d3: Add .travis.yml file to create AppImage via Travis CI (authored by mwolff).
Add .travis.yml file to create AppImage via Travis CI
Tue, Sep 12, 1:41 PM
mwolff committed R45:2696ad5ff157: Use -x instead of which to check for heaptrack_gui availability (authored by mwolff).
Use -x instead of which to check for heaptrack_gui availability
Tue, Sep 12, 1:41 PM
mwolff committed R45:48a67258dca0: Load the heaptrack_gui/_print that belongs to this version of heaptrack (authored by mwolff).
Load the heaptrack_gui/_print that belongs to this version of heaptrack
Tue, Sep 12, 1:41 PM
mwolff committed R45:0c639981e58f: Fix typo: occurrances -> occurrences (authored by mwolff).
Fix typo: occurrances -> occurrences
Tue, Sep 12, 11:51 AM
mwolff committed R45:95c3dacfef27: Add `heaptrack --analyze` to open heaptrack_gui or heaptrack_print (authored by mwolff).
Add `heaptrack --analyze` to open heaptrack_gui or heaptrack_print
Tue, Sep 12, 11:51 AM

Tue, Sep 5

mwolff committed R165:e48a4dac8a97: Fix "Session destroyed while still in pool" assertions (authored by mwolff).
Fix "Session destroyed while still in pool" assertions
Tue, Sep 5, 9:19 AM

Fri, Sep 1

mwolff committed R32:5c66f82d291e: projectmanagerview: Add Cut command into the context menu (authored by aspotashev).
projectmanagerview: Add Cut command into the context menu
Fri, Sep 1, 11:03 AM
mwolff closed D1955: projectmanagerview: Add Cut command into the context menu by committing R32:5c66f82d291e: projectmanagerview: Add Cut command into the context menu (authored by aspotashev).
Fri, Sep 1, 11:03 AM
mwolff accepted D1955: projectmanagerview: Add Cut command into the context menu.

sorry for the long delay, has this not been merged yet? I'll try to do this now

Fri, Sep 1, 10:48 AM

Thu, Aug 31

mwolff committed R206:a3f4edbab45b: Make it possible to mark a folder explicitly as sender folder (authored by mwolff).
Make it possible to mark a folder explicitly as sender folder
Thu, Aug 31, 1:06 PM
mwolff closed D7627: Make it possible to mark a folder explicitly as sender folder by committing R206:a3f4edbab45b: Make it possible to mark a folder explicitly as sender folder.
Thu, Aug 31, 1:06 PM · KDE PIM
mwolff created D7627: Make it possible to mark a folder explicitly as sender folder.
Thu, Aug 31, 12:56 PM · KDE PIM
mwolff committed R45:f0a682550118: Use check_symbol_exists() to check if cfree() is available (authored by mwolff).
Use check_symbol_exists() to check if cfree() is available
Thu, Aug 31, 7:57 AM
mwolff closed D7621: Use check_symbol_exists() to check if cfree() is available (v2) by committing R45:f0a682550118: Use check_symbol_exists() to check if cfree() is available.
Thu, Aug 31, 7:57 AM · Heaptrack
mwolff abandoned D6405: Use check_symbol_exists() to check if cfree() is available.

abandoning since https://phabricator.kde.org/D7621 got landed

Thu, Aug 31, 7:57 AM · Heaptrack
mwolff commandeered D6405: Use check_symbol_exists() to check if cfree() is available.

taking over to close

Thu, Aug 31, 7:57 AM · Heaptrack
mwolff accepted D7621: Use check_symbol_exists() to check if cfree() is available (v2).

thanks, I'll fix this up and merge this

Thu, Aug 31, 7:51 AM · Heaptrack

Tue, Aug 29

mwolff committed R45:38f69da19998: Explicitly hide zero-cost rows in the top proxy (authored by mwolff).
Explicitly hide zero-cost rows in the top proxy
Tue, Aug 29, 2:21 PM

Sun, Aug 27

mwolff added a comment to D6405: Use check_symbol_exists() to check if cfree() is available.

Please also add a link to https://bugs.kde.org/show_bug.cgi?id=383889

Sun, Aug 27, 8:44 PM · Heaptrack
mwolff requested changes to D6405: Use check_symbol_exists() to check if cfree() is available.
Sun, Aug 27, 8:35 PM · Heaptrack
mwolff accepted D7530: KIO: Task should be used in QVector, not QList..
Sun, Aug 27, 8:34 PM
mwolff accepted D7529: KIO: fix long-standing memory leak on exit..

lgtm, despite the delete this: https://isocpp.org/wiki/faq/freestore-mgmt#delete-this, esp. if you have proper unit tests and ran it through valgrind

Sun, Aug 27, 8:33 PM · Frameworks
mwolff added a comment to D7527: Add mimetype filtering capabilities to KUrlCompletion.

Almost perfect ;-)

Sun, Aug 27, 8:23 PM · Frameworks
mwolff committed R241:1a92575c73d2: Add mimetype filtering capabilities to KUrlCompletion (authored by mwolff).
Add mimetype filtering capabilities to KUrlCompletion
Sun, Aug 27, 8:23 PM
mwolff closed D7527: Add mimetype filtering capabilities to KUrlCompletion by committing R241:1a92575c73d2: Add mimetype filtering capabilities to KUrlCompletion.
Sun, Aug 27, 8:23 PM · Frameworks

Aug 24 2017

mwolff added a comment to D7527: Add mimetype filtering capabilities to KUrlCompletion.

Note that the test passes, but I noticed that the KURLCOMPLETION_LOCAL_KIO branch is not covered by unit tests. Setting it even shows that the test is then broken (even without this patch).

Aug 24 2017, 8:45 PM · Frameworks
mwolff created D7527: Add mimetype filtering capabilities to KUrlCompletion.
Aug 24 2017, 8:43 PM · Frameworks

Aug 8 2017

mwolff requested changes to D7129: Make parsing phpfunctions.php a proper parse job.

you need to wait for the job to finish, before running the other job. so just adding the document is not enough. I also don't understand why this is directly related to D7128? The change you are doing here is within a running parse job already, so D7128 on its own should be fine?

Aug 8 2017, 10:52 PM
mwolff committed R32:48a80f885b5c: remove dead code (authored by mwolff).
remove dead code
Aug 8 2017, 5:11 PM
mwolff committed R32:bf183ce7a405: Cleanup implementation of CleanupThread (authored by mwolff).
Cleanup implementation of CleanupThread
Aug 8 2017, 5:11 PM
mwolff committed R32:83806b265b18: Show all KTextEditor view bars in a central location (authored by mwolff).
Show all KTextEditor view bars in a central location
Aug 8 2017, 5:09 PM
mwolff committed R32:2e395709921b: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Aug 8 2017, 5:09 PM
mwolff committed R32:2d04564d564c: HTML-escape diagnostic description before showing it in a tooltip (authored by mwolff).
HTML-escape diagnostic description before showing it in a tooltip
Aug 8 2017, 5:09 PM
mwolff committed R32:9db2e709e00d: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Aug 8 2017, 5:09 PM
mwolff committed R32:c8180003ba1f: Fix project tree state not being saved (authored by bevendorff).
Fix project tree state not being saved
Aug 8 2017, 5:09 PM
mwolff committed R32:2fcaccd624d4: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Aug 8 2017, 5:09 PM
mwolff committed R32:9e440fc3f5ac: Trim identifiers before triggering rename action (authored by mwolff).
Trim identifiers before triggering rename action
Aug 8 2017, 5:09 PM
mwolff committed R32:6739aacb337e: Cleanup code, mark function as const. (authored by mwolff).
Cleanup code, mark function as const.
Aug 8 2017, 5:09 PM
mwolff committed R32:587972c81924: Remove useless code (authored by mwolff).
Remove useless code
Aug 8 2017, 5:09 PM
mwolff committed R32:0ed19a87cef4: Keyboard shortcuts for Uses in Code Browser (authored by dporobic).
Keyboard shortcuts for Uses in Code Browser
Aug 8 2017, 5:09 PM
mwolff committed R32:bc7a8cac87a3: Add :vsplit and :split support in kdevelop (authored by head7).
Add :vsplit and :split support in kdevelop
Aug 8 2017, 5:08 PM
mwolff committed R32:1c523ba69239: Merge branch '5.1' (authored by mwolff).
Merge branch '5.1'
Aug 8 2017, 5:08 PM
mwolff committed R32:ccf0c0a8896e: Merge branch '5.0' into 5.1 (authored by mwolff).
Merge branch '5.0' into 5.1
Aug 8 2017, 5:08 PM
mwolff committed R32:e200edb151f1: Silence runtime warnings about missing methods (authored by mwolff).
Silence runtime warnings about missing methods
Aug 8 2017, 5:08 PM
mwolff committed R32:00de613bcb0f: Pass KTextEditor::MainWindow to text views created from TextDocuments (authored by mwolff).
Pass KTextEditor::MainWindow to text views created from TextDocuments
Aug 8 2017, 5:08 PM
mwolff committed R32:46a720a58f91: Share code instead of duplicating it (authored by mwolff).
Share code instead of duplicating it
Aug 8 2017, 5:05 PM
mwolff committed R32:5da01380d622: Don't ever return empty icon names, return "none" instead as fallback. (authored by mwolff).
Don't ever return empty icon names, return "none" instead as fallback.
Aug 8 2017, 5:05 PM
mwolff committed R32:ba119d5cb58a: remove dead code (authored by mwolff).
remove dead code
Aug 8 2017, 5:05 PM
mwolff committed R32:11d3516ac32b: Add newline after project name in expanded project file quickopen widget (authored by mwolff).
Add newline after project name in expanded project file quickopen widget
Aug 8 2017, 5:05 PM
mwolff committed R32:081eaf541f93: Cleanup code: introduce anon namespace and local for filtered item. (authored by mwolff).
Cleanup code: introduce anon namespace and local for filtered item.
Aug 8 2017, 5:05 PM
mwolff committed R32:b2e63240ee3b: Also apply per-project branch colorization to duchain quickopen items. (authored by mwolff).
Also apply per-project branch colorization to duchain quickopen items.
Aug 8 2017, 5:05 PM
mwolff committed R32:1c4e0a7e037d: Remove dead code (authored by mwolff).
Remove dead code
Aug 8 2017, 5:05 PM
mwolff committed R32:ab97b036b604: Prettify displaying of file paths for duchain items in quickopen. (authored by mwolff).
Prettify displaying of file paths for duchain items in quickopen.
Aug 8 2017, 5:05 PM
mwolff committed R32:7cc40647ba89: Add per-project branch colorization to quick open. (authored by mwolff).
Add per-project branch colorization to quick open.
Aug 8 2017, 5:05 PM
mwolff committed R32:d28d5179632b: Update PWD env var when setting working directory on execute jobs. (authored by mwolff).
Update PWD env var when setting working directory on execute jobs.
Aug 8 2017, 5:05 PM
mwolff committed R32:54113eb4ed97: Navigate to use when clicking anywhere in a use report line (authored by mwolff).
Navigate to use when clicking anywhere in a use report line
Aug 8 2017, 5:05 PM
mwolff committed R32:5a937c0564be: Remove dead code (authored by mwolff).
Remove dead code
Aug 8 2017, 5:05 PM
mwolff committed R32:3be78943ead9: Optimize QHash usage for topcontext refcounting in the DUChain (authored by mwolff).
Optimize QHash usage for topcontext refcounting in the DUChain
Aug 8 2017, 5:05 PM
mwolff committed R32:8c46e8e76585: Release the background parser lock while creating parse jobs. (authored by mwolff).
Release the background parser lock while creating parse jobs.
Aug 8 2017, 5:05 PM
mwolff committed R32:e1ff9fd724e7: Use range-based-for here now. (authored by mwolff).
Use range-based-for here now.
Aug 8 2017, 5:05 PM
mwolff committed R32:7a05e2313194: Make const explicit here, it was implicitly const before though (authored by mwolff).
Make const explicit here, it was implicitly const before though
Aug 8 2017, 5:05 PM
mwolff committed R32:dedcb931355c: Separate finding the next document to parse and creating a job for it. (authored by mwolff).
Separate finding the next document to parse and creating a job for it.
Aug 8 2017, 5:05 PM
mwolff committed R32:6c03e7f01041: Hoist code snippet out into its own little method (authored by mwolff).
Hoist code snippet out into its own little method
Aug 8 2017, 5:05 PM
mwolff committed R32:b993c09128e0: Hoist checks out of loops. (authored by mwolff).
Hoist checks out of loops.
Aug 8 2017, 5:05 PM
mwolff committed R32:7e8af89e7d70: Cleanup the code structure even further. (authored by mwolff).
Cleanup the code structure even further.
Aug 8 2017, 5:05 PM
mwolff committed R32:ad9622923b91: Further simplify the code now that we really only handle a single job. (authored by mwolff).
Further simplify the code now that we really only handle a single job.
Aug 8 2017, 5:04 PM
mwolff committed R32:af242fe3ea11: Don't reference destroyed data in lambda run in background thread. (authored by mwolff).
Don't reference destroyed data in lambda run in background thread.
Aug 8 2017, 5:04 PM
mwolff committed R32:338dd63aa806: Remove dead code (authored by mwolff).
Remove dead code
Aug 8 2017, 5:04 PM
mwolff committed R32:1e7327a49983: Cleanup code to explicitly mark we stop the loop after the first job. (authored by mwolff).
Cleanup code to explicitly mark we stop the loop after the first job.
Aug 8 2017, 5:04 PM
mwolff committed R32:c4cf0fa8859d: Introduce priority and documentsForPriority locals for better readability (authored by mwolff).
Introduce priority and documentsForPriority locals for better readability
Aug 8 2017, 5:04 PM
mwolff committed R32:54506df4eb5d: Cleanup code, mostly minor stuff and moving stuff around a bit. (authored by mwolff).
Cleanup code, mostly minor stuff and moving stuff around a bit.
Aug 8 2017, 5:04 PM