Set the DPR value of the corresponding widget on the pixmap and
scale the sizes manually. This ensures we don't get blurry pixmaps.
Additionally ensure we don't resize the pixmap in ShowImageWidget
more than needed. We should only scale when we zoom.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
here's how it looks like with animated gifs now, the delegate is nice and sharp but the dialog is blocky but functional. QMovie lacks a DPR-setter, so there's no way for us to fix the dialog afaik, unless we do what the delegate does (extract frames on by one)
@mwolff showimagewidgettest seems to be failing because of this change (if I revert it the test passes):
********* Start testing of ShowImageWidgetTest ********* Config: Using QtTest library 5.14.2, Qt 5.14.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.5.0) PASS : ShowImageWidgetTest::initTestCase() XPASS : ShowImageWidgetTest::shouldHaveDefaultValues() QCOMPARE(mLabel->pixmap()->size(), pixmapSize) returned TRUE unexpectedly. Loc: [/home/shantanu/dev/kde/ruqola/src/widgets/dialogs/autotests/showimagewidgettest.cpp(63)] PASS : ShowImageWidgetTest::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 24ms ********* Finished testing of ShowImageWidgetTest *********
