flherne (Francis Herne)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 10 2016, 10:44 AM (170 w, 3 d)
Availability
Available

Recent Activity

Mar 4 2019

flherne added a comment to D19457: Resurrect kdev-java.

Nice work!

Mar 4 2019, 3:03 AM · KDevelop

Jan 14 2019

flherne committed R53:a2baaeb7f87f: Merge branch '5.3' (authored by flherne).
Merge branch '5.3'
Jan 14 2019, 2:22 PM

Jan 10 2019

flherne committed R53:cabf41fb18ad: Fix crash when finding context inside annotated assigments. (authored by flherne).
Fix crash when finding context inside annotated assigments.
Jan 10 2019, 3:06 PM

Jan 8 2019

flherne accepted D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

On further consideration, I think I was wrong about this, sorry.

Jan 8 2019, 12:27 PM · KDevelop

Dec 29 2018

flherne requested changes to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

I'm opposed to the concept of this patch.

Dec 29 2018, 8:21 PM · KDevelop

Dec 18 2018

flherne committed R32:df225e7795cc: [clang-tidy] Fix context-menu crash for files not in a project (authored by flherne).
[clang-tidy] Fix context-menu crash for files not in a project
Dec 18 2018, 2:16 PM

Dec 3 2018

flherne added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

Please no.

Dec 3 2018, 10:10 PM · Frameworks, Kate

Dec 2 2018

flherne added a comment to D17278: Meson plugin: First working version.

It's quite easy to accidentally start repeated configure jobs, in which case the second one fails - e.g. by clicking "Apply" and then "Ok" in the project settings.

Dec 2 2018, 1:01 AM · Documentation, KDevelop

Dec 1 2018

flherne added inline comments to D17278: Meson plugin: First working version.
Dec 1 2018, 10:00 PM · Documentation, KDevelop

Nov 30 2018

flherne added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 12:18 PM · KDevelop
flherne added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 12:15 PM · KDevelop

Nov 20 2018

flherne added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.

@rjvbb : If you generate a compile_commands.json manually or with some tool, the best option for KDevelop (as I mentioned in that email) is to import it as a "CMake" project.

Nov 20 2018, 11:29 AM · KDevelop

Oct 28 2018

flherne accepted D16499: Bump min ECM/KF5 dep version to 5.18.

+1, as on IRC.

Oct 28 2018, 9:53 PM · KDevelop
flherne added a comment to D16495: Bump min dep versions of Qt & KF to 5.7 & 5.28.

Debian Stretch (current stable release) has Qt 5.7 and KF 5.28. Next stable release isn't until mid-2019.

Oct 28 2018, 9:16 PM · KDevelop
flherne added a comment to D8950: Remove source code of unused CVS support plugin..

A year seems long enough. The code's in git if anyone wants it, there's no point advertising a feature that's unusable and not maintained.

Oct 28 2018, 1:10 PM
flherne committed R32:0fc8dddfc8f6: Remove unmaintained and buggy CVS plugin (authored by flherne).
Remove unmaintained and buggy CVS plugin
Oct 28 2018, 1:07 PM

Oct 10 2018

flherne committed R53:d619a731dbcd: Improve support for 'with' statements. (authored by flherne).
Improve support for 'with' statements.
Oct 10 2018, 12:03 AM
flherne closed D16085: Improve support for 'with' statements..
Oct 10 2018, 12:03 AM · KDevelop

Oct 9 2018

flherne requested review of D16085: Improve support for 'with' statements..
Oct 9 2018, 5:36 PM · KDevelop

Sep 29 2018

flherne committed R53:d169b27eda6a: Bump supported Python version to 3.8 (authored by flherne).
Bump supported Python version to 3.8
Sep 29 2018, 5:06 PM

Sep 28 2018

flherne accepted D15743: Fix removal of external scripts.

The QSet include is redundant now.

Sep 28 2018, 2:42 PM · KDevelop
flherne requested changes to D15743: Fix removal of external scripts.

This looks good to me overall, but see a few inline comments.

Sep 28 2018, 11:34 AM · KDevelop

Mar 20 2018

flherne committed R53:864d2d70965e: Ensure that codestyle.py always returns something on stdout to unlock m_mutex. (authored by fviard).
Ensure that codestyle.py always returns something on stdout to unlock m_mutex.
Mar 20 2018, 12:08 AM
flherne closed D11474: Fixes #392031 - Ensure that codestyle.py always return something on stdout to unlock m_mutex..
Mar 20 2018, 12:08 AM

Feb 14 2018

flherne committed R53:bccaa0fa3dbb: Update conversionGenerator.py to match output file. (authored by flherne).
Update conversionGenerator.py to match output file.
Feb 14 2018, 5:46 PM

Jan 26 2018

flherne committed R53:3d92bc8cf4d2: Add `text/x-python3` to mimetypes. (authored by flherne).
Add `text/x-python3` to mimetypes.
Jan 26 2018, 10:35 AM

Jan 25 2018

flherne committed R53:ec8c1c43e380: Fix crash with contexts opened in the baseclass list of a class definition. (authored by flherne).
Fix crash with contexts opened in the baseclass list of a class definition.
Jan 25 2018, 12:45 PM

Nov 28 2017

flherne requested changes to D9016: remove global statics.
Nov 28 2017, 10:36 PM

Nov 27 2017

flherne committed R53:a77c34391991: Avoid build spam from CMake 3.10+ (authored by flherne).
Avoid build spam from CMake 3.10+
Nov 27 2017, 11:25 PM
flherne requested changes to D9016: remove global statics.

This version deadlocks KDevelop immediately when opening a Python project. Several threads are waiting on cacheMutex.

Nov 27 2017, 11:23 PM
flherne requested changes to D9016: remove global statics.

This is definitely nicer; I remember being a bit puzzled by Helper being a class, and the inscrutable static-var problems are a nuisance.

Nov 27 2017, 1:19 PM

Nov 23 2017

flherne committed R32:d1d19bada7be: CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES (authored by flherne).
CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES
Nov 23 2017, 11:44 AM
flherne closed D8951: CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES.
Nov 23 2017, 11:44 AM
flherne committed R32:9e9ddb6fcae8: CMake: Explicity use old behaviour for automoc of generated files. (authored by flherne).
CMake: Explicity use old behaviour for automoc of generated files.
Nov 23 2017, 11:11 AM
flherne committed R32:26fe4c7e8784: Use 'rm -f' on tempfile, in case 'rm' is aliased to 'rm -i'. (authored by Lars DIECKOW <lars.dieckow@googlemail.com>).
Use 'rm -f' on tempfile, in case 'rm' is aliased to 'rm -i'.
Nov 23 2017, 12:53 AM

Nov 22 2017

flherne added a comment to D8950: Remove source code of unused CVS support plugin..

It may be that it's simply missed a couple of years of VCS API changes, and nothing's fundamentally broken. Even in that case, it would need someone vaguely familiar with CVS to test it properly.

Nov 22 2017, 10:29 PM
flherne added a comment to D8950: Remove source code of unused CVS support plugin..

I've tried that (and I believe @kfunk did also).

Nov 22 2017, 10:24 PM
flherne added a comment to D8950: Remove source code of unused CVS support plugin..

The test isn't being built or executed at all currently.

Nov 22 2017, 3:35 PM
flherne added a comment to D8950: Remove source code of unused CVS support plugin..

Hm, there's a test, which surely ought to fail if the plugin isn't loaded, but doesn't appear in the CI's list of failing tests.

Nov 22 2017, 3:16 PM
flherne created D8951: CMakeLists.txt: Append KF5 macros to CMAKE_AUTOMOC_MACRO_NAMES.
Nov 22 2017, 3:11 PM
flherne created D8950: Remove source code of unused CVS support plugin..
Nov 22 2017, 3:07 PM
flherne accepted D8929: Fix progress widget on bottom bar not being shown in some sessions.

Thanks! Works here.

Nov 22 2017, 10:09 AM

Nov 17 2017

flherne added a comment to D8857: work around clang bug 35333: don't crash when switching git branches.

This might also fix https://bugs.kde.org/show_bug.cgi?id=372686 ?

Nov 17 2017, 12:28 AM

Oct 8 2017

flherne updated subscribers of D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer.

@arichardson had a previous patch on similar lines: https://git.reviewboard.kde.org/r/126156/

Oct 8 2017, 11:51 PM · KDevelop
flherne created D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods..
Oct 8 2017, 3:27 PM

Oct 6 2017

flherne added a comment to D8158: KDevelop: decorate patch version string in development builds.

Yeah, I'd find this useful in principle. I don't always remember exactly when I last built/installed my system copy, which can be inconvenient when looking to see which recent commits might be responsible for a problem.

Oct 6 2017, 1:04 PM · KDevelop

Sep 30 2017

flherne committed R53:cbe2a6671a6c: Merge branch '5.2' (authored by flherne).
Merge branch '5.2'
Sep 30 2017, 12:59 AM

Sep 29 2017

flherne committed R53:331cdf07fa10: Add note on using latest CPython to README.packagers (authored by flherne).
Add note on using latest CPython to README.packagers
Sep 29 2017, 1:44 PM

Sep 28 2017

flherne committed R53:f0e5d2e47dcd: Avoid dereferencing null pointer. (authored by flherne).
Avoid dereferencing null pointer.
Sep 28 2017, 4:35 PM
flherne committed R53:ca1051be6efc: Don't add uses for magicmethods of builtin classes. (authored by flherne).
Don't add uses for magicmethods of builtin classes.
Sep 28 2017, 2:15 PM

Sep 22 2017

flherne added a comment to D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

That problem exists with the current 5.2 branch (encountered by me, confirmed by frinring), so it's probably not caused by your patch.

Sep 22 2017, 11:42 PM · KDevelop

Sep 21 2017

flherne committed R32:ac0ef9f39b49: Remove extra parens (authored by flherne).
Remove extra parens
Sep 21 2017, 1:51 PM
flherne committed R53:836545d195e1: Parser: Normalize exception before reading values (authored by flherne).
Parser: Normalize exception before reading values
Sep 21 2017, 12:12 PM
flherne closed D7908: Parser: Normalize exception before reading values.

https://cgit.kde.org/kdev-python.git/commit/?id=836545d195e14c0df7e753726f7b5faecaa3e454

Sep 21 2017, 12:11 PM
flherne created D7908: Parser: Normalize exception before reading values.
Sep 21 2017, 10:07 AM

Sep 20 2017

flherne committed R53:bce58932c07d: Remove some unused includes (authored by flherne).
Remove some unused includes
Sep 20 2017, 4:02 PM

Sep 18 2017

flherne committed R53:9169fc200de6: Move RangeFixVisitor into its own files. (authored by flherne).
Move RangeFixVisitor into its own files.
Sep 18 2017, 11:57 PM
flherne committed R32:ae0976f79c3e: Set progress for CMakeServerImportJob (authored by flherne).
Set progress for CMakeServerImportJob
Sep 18 2017, 12:37 AM
flherne closed D7866: Set progress for CMakeServerImportJobs.
Sep 18 2017, 12:37 AM

Sep 17 2017

flherne created D7866: Set progress for CMakeServerImportJobs.
Sep 17 2017, 10:09 PM

Sep 16 2017

flherne committed R53:b1190c10f1bf: Remove declaration of `fileHeaderHack`, and a previously-unused typedef. (authored by flherne).
Remove declaration of `fileHeaderHack`, and a previously-unused typedef.
Sep 16 2017, 12:54 AM
flherne committed R53:6831ff34eed2: Remove 'custom file headers' feature. (authored by flherne).
Remove 'custom file headers' feature.
Sep 16 2017, 12:54 AM

Sep 13 2017

flherne closed D7791: Open context for lambdas in ContextBuilder.
Sep 13 2017, 12:57 AM
flherne added a comment to D7791: Open context for lambdas in ContextBuilder.

https://cgit.kde.org/kdev-python.git/commit/?id=d42f13080fbadf3d9afbe5516bed4fe4507f6203

Sep 13 2017, 12:56 AM
flherne committed R53:2e761862776c: Visit default argument values for lambdas in DeclarationBuilder (authored by flherne).
Visit default argument values for lambdas in DeclarationBuilder
Sep 13 2017, 12:56 AM
flherne committed R53:d42f13080fba: Open context for lambdas in ContextBuilder (authored by flherne).
Open context for lambdas in ContextBuilder
Sep 13 2017, 12:41 AM

Sep 12 2017

flherne created D7791: Open context for lambdas in ContextBuilder.
Sep 12 2017, 11:55 PM

Sep 9 2017

flherne added a reviewer for D7751: Add Rspamd support to KMail antispam: KDE PIM: KMail.
Sep 9 2017, 10:35 PM · KDE PIM: KMail, KDE PIM

Sep 6 2017

flherne committed R53:8387eb97001f: Have getDocumentationFile() return an IndexedString. (authored by flherne).
Have getDocumentationFile() return an IndexedString.
Sep 6 2017, 10:28 AM
flherne committed R32:4abe80c5387a: Merge branch '5.2' (authored by flherne).
Merge branch '5.2'
Sep 6 2017, 8:37 AM

Sep 5 2017

flherne committed R32:e92d8f0f853f: TypeRepository: Bail out of comparing to types with no loaded factory. (authored by kfunk).
TypeRepository: Bail out of comparing to types with no loaded factory.
Sep 5 2017, 11:44 PM

Sep 2 2017

flherne committed R230:5e82f4a5a3e1: Add myself (flherne) to relicensecheck.pl (authored by flherne).
Add myself (flherne) to relicensecheck.pl
Sep 2 2017, 11:29 PM

Sep 1 2017

flherne committed R53:c110f52b7294: Merge branch '5.2' (authored by flherne).
Merge branch '5.2'
Sep 1 2017, 8:34 PM
flherne closed D7643: Remove some unneeded parameters.

Couldn't reproduce a crash even after reparsing tens of thousands of files, so I'm arbitrarily blaming it on a cache problem (declarations created before b553d75e might have weird ranges). Do complain if it breaks...

Sep 1 2017, 7:53 PM
flherne committed R53:3d0c33fdcdbd: Switch to just one openDeclaration overload. (authored by flherne).
Switch to just one openDeclaration overload.
Sep 1 2017, 7:48 PM
flherne committed R53:6f51ddef1ce9: Remove `range` parameter from eventuallyReopenDeclaration (authored by flherne).
Remove `range` parameter from eventuallyReopenDeclaration
Sep 1 2017, 7:48 PM
flherne committed R53:683668774d55: Remove `originalAst` parameter from visitVariableDeclaration (authored by flherne).
Remove `originalAst` parameter from visitVariableDeclaration
Sep 1 2017, 7:48 PM
flherne committed R53:b2ab76f45c2a: Remove `range` parameter from openDeclaration overload. (authored by flherne).
Remove `range` parameter from openDeclaration overload.
Sep 1 2017, 7:48 PM
flherne added a comment to D7643: Remove some unneeded parameters.

I did some more testing and it crashed...not sure why yet :-/

Sep 1 2017, 3:49 PM
flherne closed D6949: Rewrite declarationForName().

https://cgit.kde.org/kdev-python.git/commit/?id=1a7d3c139ab7b4ab439d757a95a5d7d83575f801

Sep 1 2017, 2:37 PM
flherne updated the test plan for D7643: Remove some unneeded parameters.
Sep 1 2017, 2:31 PM
flherne created D7643: Remove some unneeded parameters.
Sep 1 2017, 2:30 PM

Aug 31 2017

flherne committed R53:5d1b605479c5: [cmake] Tweaks to Python version usage. (authored by flherne).
[cmake] Tweaks to Python version usage.
Aug 31 2017, 3:22 PM
flherne committed R53:96bcde045302: Remove unused KDEVPYTHON_VERSION defines (authored by flherne).
Remove unused KDEVPYTHON_VERSION defines
Aug 31 2017, 2:47 PM
flherne committed R53:0167fd2e35f9: Get 'str' type from f-strings. (authored by flherne).
Get 'str' type from f-strings.
Aug 31 2017, 2:07 AM
flherne committed R53:b553d75e4df8: Find generator variables without fake early declarations (authored by flherne).
Find generator variables without fake early declarations
Aug 31 2017, 1:23 AM
flherne closed D7593: Find generator variables without fake early declarations by committing R53:b553d75e4df8: Find generator variables without fake early declarations.
Aug 31 2017, 1:23 AM

Aug 29 2017

flherne committed R53:8f7a93997b14: Rainbow-color lambda parameters and comprehension variables. (authored by flherne).
Rainbow-color lambda parameters and comprehension variables.
Aug 29 2017, 5:04 PM
flherne committed R53:a39fefadcd34: Avoid creating duplicate declarations for lambda parameters. (authored by flherne).
Avoid creating duplicate declarations for lambda parameters.
Aug 29 2017, 4:28 PM
flherne committed R53:26562ee30182: Merge branch 'master' into 5.2 (authored by flherne).
Merge branch 'master' into 5.2
Aug 29 2017, 4:28 PM

Aug 28 2017

flherne created D7593: Find generator variables without fake early declarations.
Aug 28 2017, 9:49 PM
flherne committed R53:c92ed7d5ef5e: Merge branch '5.1' (authored by flherne).
Merge branch '5.1'
Aug 28 2017, 8:50 PM
flherne committed R32:0f101e4c1802: Also print the raw string (authored by flherne).
Also print the raw string
Aug 28 2017, 10:56 AM
flherne committed R32:0d053e2311be: Uncomment a qCDebug() line. (authored by flherne).
Uncomment a qCDebug() line.
Aug 28 2017, 10:55 AM
flherne committed R53:19544d5f1eaf: Remove keyword checks in UseBuilder::visitName() (authored by flherne).
Remove keyword checks in UseBuilder::visitName()
Aug 28 2017, 10:23 AM

Aug 24 2017

flherne committed R53:b001504c7693: Update Django project template to 1.11 (authored by romainferrec).
Update Django project template to 1.11
Aug 24 2017, 5:21 PM

Aug 23 2017

flherne added a comment to T6854: Modernizing Kontact look.

[KMail user, not VDG person].

Aug 23 2017, 5:40 PM · VDG, KDE PIM

Aug 8 2017

flherne committed R32:396dda6a4340: Normalize line endings when creating ParseJob from background file. (authored by flherne).
Normalize line endings when creating ParseJob from background file.
Aug 8 2017, 5:13 PM
flherne committed R32:dd3fc9b64246: Revert "Simplify the checks for supported compiler warning flags" (authored by flherne).
Revert "Simplify the checks for supported compiler warning flags"
Aug 8 2017, 5:11 PM
flherne added a reverting change for R32:26918c8c3afe: Simplify the checks for supported compiler warning flags: R32:dd3fc9b64246: Revert "Simplify the checks for supported compiler warning flags".
Aug 8 2017, 5:11 PM