arichardson (Alex Richardson)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 12:24 AM (239 w, 2 d)
Availability
Available

Recent Activity

Sep 26 2019

arichardson added a comment to T11753: Get plain Qt in shape to be usable by KDE stuff on Windows.

I originally tried to make the qt5 version installed by homebrew usable for KDE frameworks (e.g. find syntax files etc.) Currently you have to manually create symlinks in $HOME to /use/local/ to allow applications to find stuff. See https://github.com/KDE-mac/homebrew-kde/blob/master/tools/do-caveats.sh

Sep 26 2019, 10:03 PM

Aug 5 2019

arichardson committed R487:909a65177ceb: Use a proper CMake find module for libcanberra instead of pkg_check_modules (authored by arichardson).
Use a proper CMake find module for libcanberra instead of pkg_check_modules
Aug 5 2019, 12:12 PM

Jun 8 2019

arichardson committed R457:ceaff5549038: Use 64K as the maximum number of array entries (authored by arichardson).
Use 64K as the maximum number of array entries
Jun 8 2019, 3:45 PM

Jan 8 2019

arichardson added a comment to D4716: Add some more directives to MIPS assembler highlighting.

Sorry, was busy with other stuff so completely forgot about this. I'll update this soon.

Jan 8 2019, 7:42 PM · Kate, Frameworks

Oct 23 2018

arichardson accepted D16379: Do not ignore translations that are the same as the original.

Makes sense, I didn't think about multiple languages being set when I wrote that code.

Oct 23 2018, 6:20 AM

Sep 19 2018

arichardson accepted D15602: Fix absolute library paths on mac.

Looks good to me.

Sep 19 2018, 11:02 PM
arichardson accepted D15603: Patch files in binary mode.
Sep 19 2018, 11:00 PM

Sep 14 2018

arichardson accepted D15501: Modernise traverse by using scandir.

LGTM

Sep 14 2018, 11:20 AM
arichardson added a comment to D15500: Port QtSDK support to unix.

I haven't tried the QtSDK parts yet, but the blacklist seems to work.

Sep 14 2018, 10:21 AM

Sep 13 2018

arichardson accepted D15479: fix for macOS.

I can confirm that this fixes the build for me.

Sep 13 2018, 1:57 PM · Frameworks
arichardson committed R877:2b6289dc21b3: Fix djvu build on macos (authored by arichardson).
Fix djvu build on macos
Sep 13 2018, 12:25 PM
arichardson closed D15446: Fix djvu build on macos.
Sep 13 2018, 12:25 PM
arichardson closed D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).
Sep 13 2018, 12:25 PM
arichardson committed R877:566d28057b07: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW) (authored by arichardson).
Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW)
Sep 13 2018, 12:25 PM
arichardson committed R877:f918099dc32a: Fix build of libnettle on MacOS (authored by arichardson).
Fix build of libnettle on MacOS
Sep 13 2018, 12:25 PM
arichardson committed R877:ceaa54ab74c8: Fix aqbanking build on macos (authored by arichardson).
Fix aqbanking build on macos
Sep 13 2018, 12:25 PM
arichardson committed R138:8b645e085786: Revert "Fix build of libopensp if the user has CLICOLOR set in the environment" (authored by arichardson).
Revert "Fix build of libopensp if the user has CLICOLOR set in the environment"
Sep 13 2018, 12:16 PM
arichardson added a reverting change for R138:1ab92d2eb1a1: Fix build of libopensp if the user has CLICOLOR set in the environment: R138:8b645e085786: Revert "Fix build of libopensp if the user has CLICOLOR set in the environment".
Sep 13 2018, 12:16 PM
arichardson committed R138:dcd340d8e8a6: Add missing return True (authored by arichardson).
Add missing return True
Sep 13 2018, 12:06 PM
arichardson committed R138:397b0c440fcc: Add type hints for CraftCore.* (authored by arichardson).
Add type hints for CraftCore.*
Sep 13 2018, 12:06 PM
arichardson committed R138:17617ec16eab: dylibbundler: Correctly handle changes to the library id (authored by arichardson).
dylibbundler: Correctly handle changes to the library id
Sep 13 2018, 12:05 PM
arichardson committed R138:5d70634a9014: Return early if dylibbundler fails (authored by arichardson).
Return early if dylibbundler fails
Sep 13 2018, 12:05 PM
arichardson committed R138:a60e8eb8f4b3: dylib bundler: Ensure files libraries are writable before changing them (authored by arichardson).
dylib bundler: Ensure files libraries are writable before changing them
Sep 13 2018, 12:05 PM
arichardson committed R138:1ab92d2eb1a1: Fix build of libopensp if the user has CLICOLOR set in the environment (authored by arichardson).
Fix build of libopensp if the user has CLICOLOR set in the environment
Sep 13 2018, 12:05 PM
arichardson committed R138:1d935e924556: Craft bits for D15469 (authored by arichardson).
Craft bits for D15469
Sep 13 2018, 12:05 PM
arichardson closed D15471: Craft bits for D15469.
Sep 13 2018, 12:05 PM
arichardson updated the diff for D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).

Fix name

Sep 13 2018, 11:58 AM
arichardson updated the diff for D15471: Craft bits for D15469.

Pick a name that shows that it is a boolean

Sep 13 2018, 11:57 AM
arichardson updated the diff for D15446: Fix djvu build on macos.

Add missing newline

Sep 13 2018, 10:49 AM
arichardson updated the diff for D15446: Fix djvu build on macos.

Build using autotools on non-Windows systems since that is the supported way.

Sep 13 2018, 10:48 AM
arichardson updated the diff for D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).

fix

Sep 13 2018, 10:30 AM
arichardson updated the diff for D15471: Craft bits for D15469.

Better approach

Sep 13 2018, 10:27 AM
arichardson added a comment to D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).

Ah yes of course I didn't think about that. How about self.subinfo.options.configure.defaultAutoreconfIncludes = False? So far the only thing that was necessary is to not add the default include path.

Sep 13 2018, 9:49 AM
arichardson added a comment to D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).

I have needed this for 3 packages now (libunistring, libtasn1 and aqbanking). Do we really need to override the project aclocal files with the ones from the craftroot? According to the mailing list message prefix/share/aclocal will be searched automatically.

Sep 13 2018, 9:34 AM
arichardson added a dependent revision for D15471: Craft bits for D15469: D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).
Sep 13 2018, 9:07 AM
arichardson added a dependency for D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW): D15471: Craft bits for D15469.
Sep 13 2018, 9:07 AM
arichardson requested review of D15471: Craft bits for D15469.
Sep 13 2018, 9:07 AM
arichardson requested review of D15469: Update libunistring to 0.9.10 and fix build on macOS (and maybe also MinGW).
Sep 13 2018, 8:44 AM

Sep 12 2018

arichardson added a comment to D15446: Fix djvu build on macos.

I guess the other option is to just use the autotools build for linux/mac?

Sep 12 2018, 10:06 AM
arichardson added a comment to D15446: Fix djvu build on macos.

I found https://github.com/acmepjz/djvulibre with cmake build system, should we be using that instead?

Sep 12 2018, 8:38 AM
arichardson requested review of D15446: Fix djvu build on macos.
Sep 12 2018, 8:36 AM

Sep 11 2018

arichardson committed R138:2bfddb6ba775: Also run the dylib fixup code on Contents/Frameworks after macdeployqt (authored by arichardson).
Also run the dylib fixup code on Contents/Frameworks after macdeployqt
Sep 11 2018, 8:36 AM
arichardson committed R877:e6e8aa4d4e80: Add libjpeg-turbo 1.5.3 (authored by arichardson).
Add libjpeg-turbo 1.5.3
Sep 11 2018, 8:21 AM
arichardson committed R877:6c29083c3563: Add gpgme to kwallet deps (authored by arichardson).
Add gpgme to kwallet deps
Sep 11 2018, 8:21 AM

Sep 10 2018

arichardson committed R138:4ad8b7927581: mac: Use a different approach to avoid using headers from /usr/local (authored by arichardson).
mac: Use a different approach to avoid using headers from /usr/local
Sep 10 2018, 9:04 PM
arichardson closed D15401: mac: Use a different approach to avoid using headers from /usr/local.
Sep 10 2018, 9:04 PM
arichardson updated the diff for D15401: mac: Use a different approach to avoid using headers from /usr/local.

Fix typo in comment

Sep 10 2018, 11:25 AM
arichardson requested review of D15401: mac: Use a different approach to avoid using headers from /usr/local.
Sep 10 2018, 11:23 AM
arichardson committed R138:ae8d2151df55: Don't link against symbols that only exist on newer macOS versions (authored by arichardson).
Don't link against symbols that only exist on newer macOS versions
Sep 10 2018, 7:41 AM
arichardson closed D15374: Don't link against symbols that only exist on newer macOS versions.
Sep 10 2018, 7:41 AM

Sep 9 2018

arichardson added a comment to D15374: Don't link against symbols that only exist on newer macOS versions.

According to http://doc.qt.io/qt-5/supported-platforms.html the minimum version is 10.11 so this should be fine.
As long as we update this version whenever Qt doesn't build keeping it in sync shouldn't be too difficult.
I also don't think it would be a problem if the minimum supported macos version for other software is lower than the Qt minimum.

Sep 9 2018, 8:27 PM
arichardson requested review of D15374: Don't link against symbols that only exist on newer macOS versions.
Sep 9 2018, 12:11 PM

Sep 5 2018

arichardson closed D15116: Make MacOS package creation work with plugins.

Committed to master as commits R138:862353272ad0653e18c745a27c65e39719a635e0 to R138:0d768777eef749c562ee294227ef9d1b3f93bd1c

Sep 5 2018, 2:15 PM
arichardson committed R138:0d768777eef7: Remove macdylibbundler dependency (authored by arichardson).
Remove macdylibbundler dependency
Sep 5 2018, 2:15 PM
arichardson committed R138:bbe429795064: Add a drop link to /Applications in the .dmg file (authored by arichardson).
Add a drop link to /Applications in the .dmg file
Sep 5 2018, 2:15 PM
arichardson committed R138:98ffe6810d44: MacDylibBundler: Handle already bundled libs with relative paths (authored by arichardson).
MacDylibBundler: Handle already bundled libs with relative paths
Sep 5 2018, 2:15 PM
arichardson committed R138:bbe330889e63: Move the dylib bundling code into a separate class (authored by arichardson).
Move the dylib bundling code into a separate class
Sep 5 2018, 2:15 PM
arichardson committed R138:d6cedc16cabf: Reimplement macdylibbundler in python as part of MacDMGPackager (authored by arichardson).
Reimplement macdylibbundler in python as part of MacDMGPackager
Sep 5 2018, 2:15 PM
arichardson committed R138:c2b801763fb2: MacDMG: Fix absolute paths in plugins (authored by arichardson).
MacDMG: Fix absolute paths in plugins
Sep 5 2018, 2:15 PM
arichardson committed R138:862353272ad0: MacDMGPackager: Validate that plugins don't depend on absolute paths (authored by arichardson).
MacDMGPackager: Validate that plugins don't depend on absolute paths
Sep 5 2018, 2:15 PM

Sep 4 2018

arichardson committed R138:c43a29fc6e01: Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS (authored by arichardson).
Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS
Sep 4 2018, 10:21 AM
arichardson closed D15120: Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS.
Sep 4 2018, 10:21 AM

Sep 3 2018

arichardson added a reviewer for D15120: Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS: Craft.
Sep 3 2018, 4:47 PM
arichardson added reviewers for D15120: Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS: vonreth, kfunk.
Sep 3 2018, 4:47 PM
arichardson committed R877:196091872d66: Build dolphin without kdelibs4support (authored by arichardson).
Build dolphin without kdelibs4support
Sep 3 2018, 4:44 PM
arichardson closed D15244: Build dolphin without kdelibs4support.
Sep 3 2018, 4:44 PM
arichardson requested review of D15244: Build dolphin without kdelibs4support.
Sep 3 2018, 2:31 PM
arichardson committed R877:c15fbea6947f: Build LLVM for the host and not for X86 (authored by arichardson).
Build LLVM for the host and not for X86
Sep 3 2018, 2:29 PM
arichardson committed R877:3e88b57c5379: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS (authored by arichardson).
Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS
Sep 3 2018, 2:29 PM
arichardson closed D15235: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS.
Sep 3 2018, 2:29 PM
arichardson committed R877:e820c87e11b6: Fix glib build on MacOS (authored by arichardson).
Fix glib build on MacOS
Sep 3 2018, 2:28 PM
arichardson closed D15079: Fix glib build on MacOS.
Sep 3 2018, 2:28 PM
arichardson added a comment to D15235: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS.

did you by accident invert the before and after value?

Sep 3 2018, 12:17 PM
arichardson requested review of D15235: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS.
Sep 3 2018, 10:05 AM
arichardson added a comment to D15079: Fix glib build on MacOS.

Ping?

Sep 3 2018, 10:04 AM

Aug 28 2018

arichardson added a comment to D15116: Make MacOS package creation work with plugins.

Hardcoding would again make testing harder, but we might just add a patch to use the relative path to qappDir/…./share as a fallback, or maybe we can even detect whether we are in a bundle or in a build root?

It should be easy to detect whether we are in a bundle or not. I can also check if the current executable is below qtpaths --install-prefix and if so add $(qtpaths --install-prefix)/share.

Aug 28 2018, 2:05 PM
arichardson added a comment to D15116: Make MacOS package creation work with plugins.

ok then the main question is, do we need to deploy extra libs? they should already be in the image, and removing this functionality would simplify the code?

Initially I've used MacDylibBundler to pull in libs from packages installed via Brew. Nowadays we built (almost?) everything ourselves using Craft, right? There might still be some libs which need to be pulled into the .app, though, if it's not tracked by Craft... But I honestly do not know the current state of affairs re. Craft on macOS...

I noticed it pulled in at least libgit2.dylib and editorconfig.dylib from homebrew.

The one thing that is missing for any application to work on MacOS is the ability to override QStandardPaths::GenericDataLocation. The app bundle seems to work because it bundles all of share/ into Contents/Resources but if I try to run the kate.app created by craft in ~/kde/Applications it doesn't find anything.
I can (almost) get it to work by removing kate.app/Contents/Resources and turning that into a symlink to ~/kde/share. If I do that kate works fine when launched from the console ./Applications/KDE/kate.app/Contents/MacOS/kate foo.txt but if I double click on the .app or use open -a all icons are missing and lots of stuff is broken.

Hm are you using our qt build, we apply https://github.com/KDE/craft-blueprints-kde/commit/f7513dc802ee29db1c61dc6e3f9f4e729b418a4a

Aug 28 2018, 1:22 PM
arichardson added a comment to D15116: Make MacOS package creation work with plugins.

ok then the main question is, do we need to deploy extra libs? they should already be in the image, and removing this functionality would simplify the code?

Initially I've used MacDylibBundler to pull in libs from packages installed via Brew. Nowadays we built (almost?) everything ourselves using Craft, right? There might still be some libs which need to be pulled into the .app, though, if it's not tracked by Craft... But I honestly do not know the current state of affairs re. Craft on macOS...

Aug 28 2018, 12:54 PM
arichardson committed R138:b9207effc1e5: Fix order of aclocal includes (authored by arichardson).
Fix order of aclocal includes
Aug 28 2018, 12:41 PM
arichardson closed D15119: Fix order of aclocal includes.
Aug 28 2018, 12:41 PM
arichardson committed R138:84867eab0bb5: Add type hint for CraftCore.log (authored by arichardson).
Add type hint for CraftCore.log
Aug 28 2018, 12:41 PM
arichardson committed R138:d16eac8edff8: Update Qt version CraftSettings.ini.template to 5.11.1 (authored by arichardson).
Update Qt version CraftSettings.ini.template to 5.11.1
Aug 28 2018, 12:41 PM
arichardson closed D15118: Update Qt version CraftSettings.ini.template to 5.11.1.
Aug 28 2018, 12:41 PM
arichardson requested review of D15120: Compile with `-isysroot $(xcrun --sdk-path) when building on MacOS.
Aug 28 2018, 11:20 AM
arichardson requested review of D15119: Fix order of aclocal includes.
Aug 28 2018, 11:19 AM
arichardson requested review of D15118: Update Qt version CraftSettings.ini.template to 5.11.1.
Aug 28 2018, 11:18 AM
arichardson added inline comments to D15116: Make MacOS package creation work with plugins.
Aug 28 2018, 11:14 AM
arichardson added a comment to D15116: Make MacOS package creation work with plugins.

Aug 28 2018, 10:06 AM
arichardson requested review of D15116: Make MacOS package creation work with plugins.
Aug 28 2018, 10:05 AM

Aug 25 2018

arichardson updated the diff for D15079: Fix glib build on MacOS.
Aug 25 2018, 1:06 PM
arichardson committed R138:ea1053caaf76: craftenv.sh: use python3 (after version check) if python3.6 isn't found (authored by arichardson).
craftenv.sh: use python3 (after version check) if python3.6 isn't found
Aug 25 2018, 12:39 PM
arichardson closed D15075: craftenv.sh: use python3 (after version check) if python3.6 isn't found.
Aug 25 2018, 12:39 PM
arichardson requested review of D15079: Fix glib build on MacOS.
Aug 25 2018, 12:36 PM
arichardson updated the diff for D15075: craftenv.sh: use python3 (after version check) if python3.6 isn't found.

Remove debug echo

Aug 25 2018, 11:07 AM
arichardson requested review of D15075: craftenv.sh: use python3 (after version check) if python3.6 isn't found.
Aug 25 2018, 11:06 AM

Aug 10 2018

arichardson accepted D14722: KPluginMetaData: convert empty string to empty stringlist..

LGTM

Aug 10 2018, 10:01 AM · Frameworks

Jul 31 2018

arichardson added a comment to D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too.

+1 LGTM. Thanks!

Jul 31 2018, 9:27 AM · Plasma

Jul 28 2018

arichardson added a comment to D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too.

Does this mean for Qt < 5.12 (or .13?) pressing open in kwrite will select the cwd again?

Jul 28 2018, 12:46 PM · Plasma

Apr 8 2018

arichardson committed R135:cc064e81c6ed: KDEPlatformFileDialog: Fix initial directory selection for remote files (authored by arichardson).
KDEPlatformFileDialog: Fix initial directory selection for remote files
Apr 8 2018, 2:06 PM
arichardson added a comment to D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.
In D4193#242444, @fvogt wrote:

What about Plasma/5.12? It has a minimum of Qt 5.9 as well.

Apr 8 2018, 12:56 PM · Plasma