KTextEditor: File menu: Put Save, Print and Export in submenus
Needs ReviewPublic

Authored by gregormi on Sat, Nov 24, 3:36 PM.

Details

Reviewers
None
Group Reviewers
Kate
KDevelop
Summary

With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.

This is the corresponding patch for Kate: https://phabricator.kde.org/D17138 (screenshots and general discussion are there)

NOTE: I assume that dependent applications like KWrite and KDevelop must be adapted, too. So, a broader discussion is expected.

Diff Detail

Repository
R39 KTextEditor
Branch
arcpatch-D17137
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5321
Build 5339: arc lint + arc unit
gregormi created this revision.Sat, Nov 24, 3:36 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSat, Nov 24, 3:36 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Sat, Nov 24, 3:36 PM
gregormi retitled this revision from File menu: Put Save, Print and Export in submenus With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before. This is the corresponding patch for Kate: TODO (screenshots are there)... to File menu: Put Save, Print and Export in submenus.Sat, Nov 24, 3:37 PM
gregormi edited the summary of this revision. (Show Details)
gregormi updated this revision to Diff 46132.Sat, Nov 24, 3:47 PM

rebase on master

gregormi edited the summary of this revision. (Show Details)Sat, Nov 24, 3:51 PM
gregormi added a reviewer: Kate.
gregormi edited the summary of this revision. (Show Details)Sat, Nov 24, 5:18 PM
gregormi added a reviewer: KDevelop.
gregormi retitled this revision from File menu: Put Save, Print and Export in submenus to KTextEditor: File menu: Put Save, Print and Export in submenus.Sat, Dec 1, 8:26 PM

Hm, is this really a good idea? Right now, the File menu is rather flat, which is a good thing imo. Do we really want to move Save operations into a "Save Variants" sub menu?

Please no.

File -> Save is one of the most universal menu entries, found in nearly every program that *has* a set of menus. Print is nearly as common.

This breaks a user assumption that's been ingrained across virtually all GUI software for decades, and makes common operations more cumbersome (although I assume many users prefer the shortcuts), for the sake of a few lines in the menu.

@cullmann You did not seem to have strong objections to this. Can you comment on this here again?

I think grouping these not that often used things is ok.
I would keep "save as" toplevel.
One thing to clarify: How do we get the "Save All" of Kate inside the file_save2 menu? I assume we should name the menu better and reuse that name inside kateui.rc.

Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended.

Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

+1 for leaving Save As on top level.

Just for reference the File menu of the current master on my screen :)

As for me, at least all the Close actions could be moved into a submenu.

For:

Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended.

Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

> I think if we use the new sub-menu in kateui.rc and we have a old ktexteditor, we will have a submenu with just one entry until you get a more up-to-date KTextEditor.

But as normally the frameworks are more up-to-date then the application, the only thing normal users should see is a submenu with the KTextEditor stuff inside and the save all toplevel.

Btw., I think the menus do lack the *_merge markers.

ngraham added a subscriber: ngraham.Sun, Dec 9, 5:26 PM

In terms of the submenu text, I just noticed that we already have "Find Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close variants" for consistency. We can decide later whether we want to keep that style.