KTextEditor: File menu: Put Save, Print and Export in submenus
Needs ReviewPublic

Authored by gregormi on Nov 24 2018, 3:36 PM.

Details

Reviewers
mwolff
Group Reviewers
Kate
KDevelop
Summary

With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.

This is the corresponding patch for Kate: https://phabricator.kde.org/D17138 (screenshots and general discussion are there)

NOTE: I assume that dependent applications like KWrite and KDevelop must be adapted, too. So, a broader discussion is expected.

Diff Detail

Repository
R39 KTextEditor
Branch
arcpatch-D17137
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7037
Build 7055: arc lint + arc unit
gregormi created this revision.Nov 24 2018, 3:36 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 24 2018, 3:36 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Nov 24 2018, 3:36 PM
gregormi retitled this revision from File menu: Put Save, Print and Export in submenus With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before. This is the corresponding patch for Kate: TODO (screenshots are there)... to File menu: Put Save, Print and Export in submenus.Nov 24 2018, 3:37 PM
gregormi edited the summary of this revision. (Show Details)
gregormi updated this revision to Diff 46132.Nov 24 2018, 3:47 PM

rebase on master

gregormi edited the summary of this revision. (Show Details)Nov 24 2018, 3:51 PM
gregormi added a reviewer: Kate.
gregormi edited the summary of this revision. (Show Details)Nov 24 2018, 5:18 PM
gregormi added a reviewer: KDevelop.
gregormi retitled this revision from File menu: Put Save, Print and Export in submenus to KTextEditor: File menu: Put Save, Print and Export in submenus.Dec 1 2018, 8:26 PM

Hm, is this really a good idea? Right now, the File menu is rather flat, which is a good thing imo. Do we really want to move Save operations into a "Save Variants" sub menu?

Please no.

File -> Save is one of the most universal menu entries, found in nearly every program that *has* a set of menus. Print is nearly as common.

This breaks a user assumption that's been ingrained across virtually all GUI software for decades, and makes common operations more cumbersome (although I assume many users prefer the shortcuts), for the sake of a few lines in the menu.

@cullmann You did not seem to have strong objections to this. Can you comment on this here again?

I think grouping these not that often used things is ok.
I would keep "save as" toplevel.
One thing to clarify: How do we get the "Save All" of Kate inside the file_save2 menu? I assume we should name the menu better and reuse that name inside kateui.rc.

Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended.

Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

+1 for leaving Save As on top level.

Just for reference the File menu of the current master on my screen :)

As for me, at least all the Close actions could be moved into a submenu.

For:

Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended.

Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

> I think if we use the new sub-menu in kateui.rc and we have a old ktexteditor, we will have a submenu with just one entry until you get a more up-to-date KTextEditor.

But as normally the frameworks are more up-to-date then the application, the only thing normal users should see is a submenu with the KTextEditor stuff inside and the save all toplevel.

Btw., I think the menus do lack the *_merge markers.

ngraham added a subscriber: ngraham.Dec 9 2018, 5:26 PM

In terms of the submenu text, I just noticed that we already have "Find Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close variants" for consistency. We can decide later whether we want to keep that style.

If there are no further comments, would proceed with:

  • Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants'
  • Introduce "Print and Export" submenu
  • Introduce "Close Variants" while leaving the 'Ctrl+W' Close on top-level

If there are no further comments, would proceed with:

  • Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants'
  • Introduce "Print and Export" submenu
  • Introduce "Close Variants" while leaving the 'Ctrl+W' Close on top-level

Sounds sane to me!

For me, too.

anthonyfieroni added inline comments.
src/data/katepart5ui.rc
2

Increase version

gregormi updated this revision to Diff 49369.Jan 13 2019, 2:03 AM
  • Move "Save As..." out of the submenu
gregormi marked an inline comment as done.Jan 13 2019, 2:07 AM

This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138):

gregormi added a comment.EditedJan 13 2019, 2:15 AM

What I wonder: during the work with the .rc menu files I noticed that even the menu in Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal?

Lookin' pretty good!

Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic.

I may like it if these "Variant-Action" could be avoided and merged with one of the "Normal-Action", but guess that will find someone too progressive/uncommon and I'm not sure if that is technically possible by Qt.
What? Well, e.g hovering "Save As..." offer entries from "Save Variants" but click on it still do "Save As..."

mwolff resigned from this revision.Sun, Jan 27, 7:25 PM