dkurz (Denis Kurz)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 12 2016, 9:38 AM (145 w, 3 d)
Availability
Available

Recent Activity

Nov 2 2018

dkurz added a comment to D16509: Eventviews: associate calendar color to remoteID rather than ID..

assuming DAV actually supports that.

Nov 2 2018, 11:49 AM

Nov 1 2018

dkurz added a comment to D16601: Replace Q_FOREACH and foreach by the range based for statement.

Replacing Q_FOREACH with range-based for actually might change performance, in case the data structure detaches. Basically, Q_FOREACH creates a const copy of the container and iterates over that, so no detaching happens.

Nov 1 2018, 9:54 PM · KDE PIM
dkurz committed R165:85228a598284: Express intent to compare model columns more directly (authored by dkurz).
Express intent to compare model columns more directly
Nov 1 2018, 9:01 PM
dkurz closed D16590: Express intent to compare model columns more directly.
Nov 1 2018, 9:01 PM · KDE PIM
dkurz committed R165:562c3904742e: Modernize object declarations and initializations (authored by dkurz).
Modernize object declarations and initializations
Nov 1 2018, 3:05 PM
dkurz closed D16556: Modernize object declarations and initializations.
Nov 1 2018, 3:05 PM · KDE PIM
dkurz requested review of D16590: Express intent to compare model columns more directly.
Nov 1 2018, 3:01 PM · KDE PIM
dkurz added inline comments to D16556: Modernize object declarations and initializations.
Nov 1 2018, 2:58 PM · KDE PIM
dkurz updated the diff for D16556: Modernize object declarations and initializations.

Use parens for non-default ctor calls with explicit type

Nov 1 2018, 2:54 PM · KDE PIM
dkurz committed R165:1e665877b228: Move construction of ExpectedSignal where it belongs (authored by dkurz).
Move construction of ExpectedSignal where it belongs
Nov 1 2018, 2:24 PM
dkurz closed D16555: Move construction of ExpectedSignal where it belongs.
Nov 1 2018, 2:24 PM · KDE PIM
dkurz added inline comments to D16555: Move construction of ExpectedSignal where it belongs.
Nov 1 2018, 2:18 PM · KDE PIM
dkurz updated the diff for D16555: Move construction of ExpectedSignal where it belongs.

Pass by cref instead of values in ctors

Nov 1 2018, 2:15 PM · KDE PIM
dkurz added a comment to D16555: Move construction of ExpectedSignal where it belongs.

I also fixed the initialization order of ExpectedSignal's members.

Nov 1 2018, 2:09 PM · KDE PIM
dkurz updated the diff for D16555: Move construction of ExpectedSignal where it belongs.

Added seven consts

Nov 1 2018, 2:07 PM · KDE PIM
dkurz added inline comments to D16556: Modernize object declarations and initializations.
Nov 1 2018, 1:49 PM · KDE PIM
dkurz committed R165:1f10dad8682b: Fix unused-object warnings (authored by dkurz).
Fix unused-object warnings
Nov 1 2018, 1:41 PM
dkurz closed D16559: Fix unused-object warnings.
Nov 1 2018, 1:41 PM · KDE PIM
dkurz added a comment to D16559: Fix unused-object warnings.

arcanist complains that this Diff has not been accepted. In general, should I wait for positive feedback from the same reviewer after all requested changes from this reviewer have been fixed and accepted by another reviewer?

Nov 1 2018, 12:53 PM · KDE PIM
dkurz committed R165:438f1aa09d45: Move non-optional ModelSpy dependency to ctor (authored by dkurz).
Move non-optional ModelSpy dependency to ctor
Nov 1 2018, 12:47 PM
dkurz closed D16557: Move non-optional ModelSpy dependency to ctor.
Nov 1 2018, 12:47 PM · KDE PIM
dkurz committed R165:62ede760272f: Fix some comment typos (authored by dkurz).
Fix some comment typos
Nov 1 2018, 12:46 PM
dkurz closed D16558: Fix some comment typos.
Nov 1 2018, 12:46 PM · KDE PIM
dkurz added a comment to D16557: Move non-optional ModelSpy dependency to ctor.

Would you mind changing that, since you are touching the tests?

Nov 1 2018, 12:45 PM · KDE PIM
dkurz updated the diff for D16559: Fix unused-object warnings.

Removed Q_UNUSED(argv) from Windows build

Nov 1 2018, 11:30 AM · KDE PIM

Oct 31 2018

dkurz requested review of D16559: Fix unused-object warnings.
Oct 31 2018, 9:00 PM · KDE PIM
dkurz requested review of D16558: Fix some comment typos.
Oct 31 2018, 8:59 PM · KDE PIM
dkurz requested review of D16557: Move non-optional ModelSpy dependency to ctor.
Oct 31 2018, 8:59 PM · KDE PIM
dkurz requested review of D16556: Modernize object declarations and initializations.
Oct 31 2018, 8:57 PM · KDE PIM
dkurz requested review of D16555: Move construction of ExpectedSignal where it belongs.
Oct 31 2018, 8:55 PM · KDE PIM
dkurz added a comment to T648: [Akonadi] Properly isolate all Identity unit-tests.

I'm currently playing around with some tests, so how well are existing tests isolated overall? Is it just the identity tests that mess with my actual configuration? Where would I find those tests? I'd like to avoid running them.

Oct 31 2018, 6:33 PM · KDE PIM
dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

It's that time of the year again: Why does KDE PIM have its own versioning scheme? We know there are reasons to just stick to the KDE Applications versioning scheme, but to this day, no one gave a reason not to.

Oct 31 2018, 5:54 PM · KDE PIM
dkurz added a comment to D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent.

If it is just factoring, you can ship it. If not, I'd like to be sure not to miss anything in the change.

Oct 31 2018, 11:37 AM
dkurz accepted D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent.

I just discovered by accident that I was named reviewer for the first time. Didn't see it coming!

Oct 31 2018, 11:33 AM

Oct 27 2018

dkurz added a member for KDE PIM: Junior Jobs: dkurz.
Oct 27 2018, 5:36 PM

Oct 11 2018

dkurz committed R78:10056772fd32: Fix keyboard editting of start/end times of VTODOs (authored by dkurz).
Fix keyboard editting of start/end times of VTODOs
Oct 11 2018, 9:27 PM
dkurz closed D16114: Fix keyboard editting of start/end times of VTODOs.
Oct 11 2018, 9:27 PM · KDE PIM
dkurz committed R165:9d83f0752828: Fix KOrg category color customization crash (authored by dkurz).
Fix KOrg category color customization crash
Oct 11 2018, 9:24 PM
dkurz closed D16051: Fix KOrg category color customization crash.
Oct 11 2018, 9:24 PM · KDE PIM
dkurz closed D16088: Fix color inconsistency for unset categories..
Oct 11 2018, 9:22 PM · KDE PIM
dkurz committed R76:0b12580c8e84: Fix color inconsistency for unset categories. (authored by dkurz).
Fix color inconsistency for unset categories.
Oct 11 2018, 9:22 PM
dkurz committed R76:41a1d204064f: Factor out coloring from AgendaItem::paintEvent. (authored by dkurz).
Factor out coloring from AgendaItem::paintEvent.
Oct 11 2018, 9:20 PM
dkurz closed D16089: Factor out coloring from AgendaItem::paintEvent..
Oct 11 2018, 9:20 PM · KDE PIM
dkurz updated the diff for D16051: Fix KOrg category color customization crash.
  • Increase Akonadi DB scheme version
Oct 11 2018, 9:15 PM · KDE PIM
dkurz added a comment to T9429: [Akonadi Console] DB Console improvements.

Discoverability trumps ;-)

Oct 11 2018, 2:58 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 10 2018

dkurz added a comment to D16114: Fix keyboard editting of start/end times of VTODOs.

Err... can I already push this to Applications/18.08? We are currently in the short period between 18.08.2 tagging and release. No idea if pushing now would have any consequences.

Oct 10 2018, 8:29 PM · KDE PIM
dkurz added a comment to D16114: Fix keyboard editting of start/end times of VTODOs.
void KTimeComboBox::timeChanged (const QTime & time) [signal]
    Signal if the time has been changed either manually by the user or programatically.
 
void KTimeComboBox::timeEdited (const QTime & time) [signal]
    Signal if the time is being manually edited by the user.

to me that reads as if timeEdited isn't needed if you are using timeChanged. but .. heck, what do I know?

Oct 10 2018, 8:27 PM · KDE PIM
dkurz requested review of D16114: Fix keyboard editting of start/end times of VTODOs.
Oct 10 2018, 7:46 PM · KDE PIM
dkurz added a comment to D16089: Factor out coloring from AgendaItem::paintEvent..

Forgetting consts in a Diff that is motivated by added consts. Nice! ;-) I added them.

Oct 10 2018, 9:38 AM · KDE PIM
dkurz updated the diff for D16089: Factor out coloring from AgendaItem::paintEvent..
  • Add missing const qualifiers
Oct 10 2018, 9:36 AM · KDE PIM

Oct 9 2018

dkurz requested review of D16089: Factor out coloring from AgendaItem::paintEvent..
Oct 9 2018, 8:26 PM · KDE PIM
dkurz requested review of D16088: Fix color inconsistency for unset categories..
Oct 9 2018, 8:18 PM · KDE PIM
dkurz added a task to D16013: Rewrite the painting of an month item: T9420: [KOrganizer] Improve event display.
Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM
dkurz added a revision to T9420: [KOrganizer] Improve event display: D16013: Rewrite the painting of an month item.
Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM
dkurz added a comment to D16013: Rewrite the painting of an month item.

Another thing I just noticed: You use border width 1 unconditionally, when it was 2 unconditionally before.

Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 8 2018

dkurz requested review of D16051: Fix KOrg category color customization crash.
Oct 8 2018, 8:07 PM · KDE PIM
dkurz added a comment to D16013: Rewrite the painting of an month item.

The margin helps to immediately grasp that the event starts/ends on that day, just like the radius. I think there should be a margin iff there is a radius.

Oct 8 2018, 6:56 PM · KDE PIM: Junior Jobs, KDE PIM

Jul 22 2018

dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

Added 5.8.3 to the [1] products from my last comment by hand; deactivated all versions of those products that are not 5.7.3, 5.8.3, git, unspecified or enterprise.

Jul 22 2018, 7:38 PM · KDE PIM

Jun 19 2018

dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

@tillschafer approached me today: He wanted to report a bug for kmail2-5.8.2, but the version was missing. I added that version for all PIM products (I could think of [1]), and additionally a mix of versions 5.7.0, 5.7.2, 5.7.3, 5.8.0 and 5.8.1 for each product. Someone added some versions for some products, but not systematically at all. Some had 5.7.1, 5.7.3 and 5.8.1 set, while others had 5.7.0, 5.7.1, 5.7.2 and 5.8.1, and so on.

Jun 19 2018, 3:00 PM · KDE PIM

Jun 18 2018

dkurz added a comment to T630: [Akonadi] Foreign payload.

The first proposed approach is just an External Payload without the need to cache the local file, but referencing it directly, right? So in other words, can External Payloads be viewed as Foreign Payloads + caching of the actual payload in a file?

Jun 18 2018, 8:21 AM · KDE PIM

Jun 15 2018

dkurz added a comment to T639: [Akonadi] Notification Payloads.

The move from Backlog to Done means that this is finished, and Monitors do not need the extra roundtrip to retrieve the changed Item, right? Was it just not closed by accident?

Jun 15 2018, 2:01 PM · KDE PIM (Applications 18.08 (master))

Feb 26 2018

dkurz added a reviewer for D10644: Add location hint for Parts' toolbars: mlaurent.
Feb 26 2018, 3:14 PM · KDE PIM

Feb 22 2018

dkurz added a member for KDE PIM: dkurz.
Feb 22 2018, 7:04 PM

Feb 18 2018

dkurz requested review of D10644: Add location hint for Parts' toolbars.
Feb 18 2018, 7:58 PM · KDE PIM

Feb 17 2018

dkurz added a comment to T7891: Separate concerns of IncidenceTreeModel.

A solution for the multiple-instances-of-the-same-UID problem might be this: For every UID, there is a unique model index. However, we add a way to ask them for their containing calendars/collections. For example, we could add some ContainingCollections role, or an additional column, that reports a vector of collections. A view could then decide to

  • display an array of symbols/colored rectangles, one for each collection that contains the task, and
  • report conflicting information in multiple instances of the same event (e.g., the same task in two calendars, but with different parent tasks) in some way.
Feb 17 2018, 6:59 AM · KDE PIM
dkurz added a comment to T7891: Separate concerns of IncidenceTreeModel.

I fought my way through some messagelist code yesterday, mostly model(_h)?.* and item(_h)?.* I think they solve (many problems at once and) some of the problems that IncidenceTreeModel solves, too, but totally differently. I have a vague design in mind right now that might be used by both, but before I continue working it out any further, I have a few questions.

Feb 17 2018, 6:51 AM · KDE PIM

Feb 13 2018

dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

The problem of kmail being equipped with new versions automatically instead of kmail2... would that have to do with the fact that it is "kmail" in the repo-metadata repo?

Feb 13 2018, 10:38 AM · KDE PIM

Feb 10 2018

dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

I removed 5.7.3 (where applicable) and added 5.7.2 (where sensible) for: Akonadi, akregator, kaddressbook, kcalcore, kcalutils, kcontacts, kholidays, kimap, kmail, kmail2, kmailtransport, kmbox, kmime, knotes, kontact, korgac (added 5.7.1, too), korganizer, ktnef, syndication.

Feb 10 2018, 10:25 AM · KDE PIM
dkurz added a comment to T2373: Make sure Bugzilla versions of our products are updated.

I'm afraid someone's currently doing a suboptimal job at this. After the 5.7.1 release, I noticed that 5.7.1 was added to "kmail" (sic!) in Bugzilla, but not to "kmail2". Now I think that some more products should have been equipped with 5.7.1, too.

Feb 10 2018, 10:09 AM · KDE PIM

Feb 5 2018

dkurz added a comment to T7891: Separate concerns of IncidenceTreeModel.

I think the best approch sofar is to use pointers to incidentence and not using the UUID at all on the code.

Feb 5 2018, 1:30 PM · KDE PIM
dkurz added a comment to T7891: Separate concerns of IncidenceTreeModel.

For everyone except @dvratil: Dan's comment is referring to my following thoughts:

Feb 5 2018, 1:21 PM · KDE PIM
dkurz added a comment to T7891: Separate concerns of IncidenceTreeModel.

Akonadi can't change the UID (if you meen the UUID from ical), cause this is needed to be exactly the same when you do meeting etc. where you send eventes around.

Feb 5 2018, 12:57 PM · KDE PIM
dkurz created T7891: Separate concerns of IncidenceTreeModel.
Feb 5 2018, 11:27 AM · KDE PIM
dkurz added a comment to D10255: Prevent infinite recursion in messagelist.

Now that I reread my comments, they sound more aggressive than I intended them to.

Feb 5 2018, 9:01 AM · KDE PIM

Feb 4 2018

dkurz added a comment to D10255: Prevent infinite recursion in messagelist.

I just wanted to have a quick look at the message threading code to see if it might possibly introduce cycles. It is roughly from model.cpp:2067 to model.cpp:3361, 1300 lines of untested, untestable, deeply nested code with 13 FIXME comments in it, right?

Feb 4 2018, 8:55 PM · KDE PIM
dkurz added a comment to D10255: Prevent infinite recursion in messagelist.

How can a check *after* the recursive call resolve an infinite recursion? To prevent those, we have to treat base cases *before* the recursive call. Otoh, it seemed to help in your case. I'm quite curious how that's possible...

Feb 4 2018, 8:37 PM · KDE PIM
dkurz committed R78:c1f5f6929122: Fix use-after-free (authored by dkurz).
Fix use-after-free
Feb 4 2018, 8:12 PM
dkurz closed D7591: Fix use-after-free.
Feb 4 2018, 8:12 PM · KDE PIM

Feb 2 2018

dkurz added a comment to D7591: Fix use-after-free.

Err... no, sorry for the delay. I finally found some time to spare on KDE again, but it's too late for 5.6.1 now, I'm afraid. We are some days clear of 17.12.2 tagging, so is it OK to push this to Applications/17.12? I rebased to that branch and re-tested today, of course.

Feb 2 2018, 7:34 AM · KDE PIM

Aug 28 2017

dkurz created D7591: Fix use-after-free.
Aug 28 2017, 8:11 PM · KDE PIM

Aug 26 2017

dkurz closed D7111: Create QMenu on the stack.
Aug 26 2017, 12:49 PM · KDE PIM
dkurz committed R206:934b6a015722: Avoid QMenu heap allocation (authored by dkurz).
Avoid QMenu heap allocation
Aug 26 2017, 12:47 PM
dkurz committed R78:64b85dade4f5: Remove obsolete load method (authored by dkurz).
Remove obsolete load method
Aug 26 2017, 9:51 AM
dkurz closed D7552: Remove obsolete load method by committing R78:64b85dade4f5: Remove obsolete load method.
Aug 26 2017, 9:51 AM · KDE PIM

Aug 25 2017

dkurz created D7552: Remove obsolete load method.
Aug 25 2017, 11:13 PM · KDE PIM
dkurz committed R78:b807715001e8: Prevent tag name vs gid confusion (authored by dkurz).
Prevent tag name vs gid confusion
Aug 25 2017, 10:48 PM
dkurz closed D7548: Prevent tag name vs gid confusion by committing R78:b807715001e8: Prevent tag name vs gid confusion.
Aug 25 2017, 10:48 PM · KDE PIM
dkurz committed R78:add5866a57d0: Remove unused getter method (authored by dkurz).
Remove unused getter method
Aug 25 2017, 10:43 PM
dkurz closed D7550: Remove unused getter method by committing R78:add5866a57d0: Remove unused getter method.
Aug 25 2017, 10:43 PM · KDE PIM
dkurz committed R78:931ac9fbe6cb: Remove unused EditorItemManager methods (authored by dkurz).
Remove unused EditorItemManager methods
Aug 25 2017, 10:39 PM
dkurz closed D7549: Remove unused EditorItemManager methods by committing R78:931ac9fbe6cb: Remove unused EditorItemManager methods.
Aug 25 2017, 10:39 PM · KDE PIM
dkurz committed R78:8cdc303b0ed7: Fix wrong API comment (authored by dkurz).
Fix wrong API comment
Aug 25 2017, 10:39 PM
dkurz closed D7551: Fix wrong API comment by committing R78:8cdc303b0ed7: Fix wrong API comment.
Aug 25 2017, 10:39 PM · KDE PIM
dkurz created D7551: Fix wrong API comment.
Aug 25 2017, 9:59 PM · KDE PIM
dkurz created D7550: Remove unused getter method.
Aug 25 2017, 9:58 PM · KDE PIM
dkurz created D7549: Remove unused EditorItemManager methods.
Aug 25 2017, 9:57 PM · KDE PIM
dkurz added a comment to D7548: Prevent tag name vs gid confusion.

And of course, yay for the Tag docs! That's much more text than I expected

Aug 25 2017, 9:36 PM · KDE PIM
dkurz added a comment to D7548: Prevent tag name vs gid confusion.

I created an event in KOrganizer, gave it a bunch of categories and saved it. Then I edited the event, changed some parts and added some more categories and I did not see any GID-named categories being created. Did I miss some steps?

Aug 25 2017, 9:35 PM · KDE PIM
dkurz created D7548: Prevent tag name vs gid confusion.
Aug 25 2017, 9:06 PM · KDE PIM

Aug 24 2017

dkurz added inline comments to D7501: Korganizer can use CollectionColorAttributes for calendar colors.
Aug 24 2017, 6:59 AM · KDE PIM