The paintEvent method is already quite long, and calculating colors
inline prohibits a lot of const uses. This commit factors it out into
easily comprehensible small new methods, also making it more obvious
where to look for agenda item coloring for future changes.
Details
Details
- Reviewers
dvratil - Group Reviewers
KDE PIM - Commits
- R76:41a1d204064f: Factor out coloring from AgendaItem::paintEvent.
I tried all color settings for Agenda View and could not
find different behavior with or without patch -- just as expected, as
is a refactoring patch
Diff Detail
Diff Detail
- Repository
- R76 PIM: Event Views
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/agenda/agendaitem.h | ||
---|---|---|
282 | Those look like they could all be const methods? |
Comment Actions
Forgetting consts in a Diff that is motivated by added consts. Nice! ;-) I added them.
Comment Actions
Sorry for the delay, I had a hard time matching your changes in the logic to the original code :) looks good though. Thanks.