Replace Q_FOREACH and foreach by the range based for statement
AbandonedPublic
Actions

Authored by ognarb on Nov 1 2018, 9:38 PM.

Details

Reviewers

None

Group Reviewers

Summary

Replace each Q_FOREACH and foreach by the range based for statement from the c++ 11 standard . Shouldn't change anything performance wise. But it's now persistent across the repository.

Test Plan

Compile and run.

Diff Detail

Repository

R76 PIM: Event Views

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4459
Build 4477: arc lint + arc unit

ognarb created this revision.Nov 1 2018, 9:38 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 1 2018, 9:38 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

ognarb requested review of this revision.Nov 1 2018, 9:38 PM

Harbormaster completed remote builds in B4459: Diff 44675.Nov 1 2018, 9:38 PM

ognarb edited the summary of this revision. (Show Details)Nov 1 2018, 9:40 PM

ognarb added a reviewer: KDE PIM.

Replacing Q_FOREACH with range-based for actually might change performance, in case the data structure detaches. Basically, Q_FOREACH creates a const copy of the container and iterates over that, so no detaching happens.

Since you did not use a single qAsConst, you might be interested in https://www.kdab.com/goodbye-q_foreach/. OTOH, not using it is sometimes correct, e.g. if you iterate over an already const container or if you are extra careful that no detaching happens in the body (which might change in the future, though).

In D16601#352479, @dkurz wrote:

Replacing Q_FOREACH with range-based for actually might change performance, in case the data structure detaches. Basically, Q_FOREACH creates a const copy of the container and iterates over that, so no detaching happens.

Since you did not use a single qAsConst, you might be interested in https://www.kdab.com/goodbye-q_foreach/. OTOH, not using it is sometimes correct, e.g. if you iterate over an already const container or if you are extra careful that no detaching happens in the body (which might change in the future, though).

Interesting I will make change :D

I rewrote two times this patch with each time a smaller subset of change, and i had some strange segfault. Probably because of qt Ptr.

Revision Contents
Changeset List

			Path	Packages
M			src/agenda/agenda.cpp (14 lines)
M			src/agenda/agendaview.cpp (24 lines)
M			src/agenda/timelabels.cpp (2 lines)
M			src/agenda/timelabelszone.cpp (4 lines)
M			src/agenda/viewcalendar.cpp (2 lines)
M			src/eventview.cpp (2 lines)
M			src/month/monthitem.cpp (4 lines)
M			src/month/monthscene.cpp (4 lines)
M			src/month/monthview.cpp (6 lines)
M			src/multiagenda/multiagendaview.cpp (44 lines)
M			src/timeline/timelineview.cpp (2 lines)
M			src/timeline/timelineview_p.cpp (2 lines)
M			src/todo/incidencetreemodel.cpp (16 lines)
M			src/todo/todomodel.cpp (2 lines)
M			src/todo/todoview.cpp (8 lines)
M			src/todo/todoviewview.cpp (2 lines)
M			src/viewerapp/mainwindow.cpp (2 lines)
M			src/whatsnext/whatsnextview.cpp (10 lines)

Commit	Tree	Parents	Author	Summary	Date
fa556b45277f	7ba9f21fc698	04d78daf8b33	Carl Schwan	Replace Q_FOREACH and foreach by the range based for statement (Show More…)	Nov 1 2018, 9:36 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44675	04d78da		Nov 1 2018, 9:38 PM	★	★

Replace Q_FOREACH and foreach by the range based for statementAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 44675

src/agenda/agenda.cpp

src/agenda/agendaview.cpp

src/agenda/timelabels.cpp

src/agenda/timelabelszone.cpp

src/agenda/viewcalendar.cpp

src/eventview.cpp

src/month/monthitem.cpp

src/month/monthscene.cpp

src/month/monthview.cpp

src/multiagenda/multiagendaview.cpp

src/timeline/timelineview.cpp

src/timeline/timelineview_p.cpp

src/todo/incidencetreemodel.cpp

src/todo/todomodel.cpp

src/todo/todoview.cpp

src/todo/todoviewview.cpp

src/viewerapp/mainwindow.cpp

src/whatsnext/whatsnextview.cpp

Replace Q_FOREACH and foreach by the range based for statement
AbandonedPublic
Actions

Revision Contents
Changeset List