Create QMenu on the stack
ClosedPublic

Authored by dkurz on Aug 3 2017, 7:13 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM: KMail

Diff Detail

Repository
R206 KMail
Lint
Lint Skipped
Unit
Unit Tests Skipped
dkurz created this revision.Aug 3 2017, 7:13 PM
Restricted Application added a subscriber: KDE PIM. ยท View Herald TranscriptAug 3 2017, 7:13 PM

Why ? improvement ?

dkurz added a comment.Aug 4 2017, 11:07 AM

The reasoning is the same as in D7107. Additionally, we can see here how it simplifies memory management and prevents memory leaks: In line 2756, we had to remember to delete menu before we return. We can easily forget that, and now get it for free.

dvratil accepted this revision.Aug 26 2017, 9:18 AM
This revision is now accepted and ready to land.Aug 26 2017, 9:18 AM
dkurz closed this revision.Aug 26 2017, 12:49 PM