Fix color inconsistency for unset categories.
ClosedPublic

Authored by dkurz on Oct 9 2018, 8:18 PM.

Details

Summary

KOrganizer's preference dialog states that the color for unset
categories is only used on the categories-color-only setting. However,
this is currently not true for Month View, where in each of the mixed
settings (category-border, resource-fill, or vice versa) the
unset-category color is also used. With this patch, Month View considers
the unset-category color only in the category-only setting, just like
Agenda View.

BUG: 382185
FIXED-IN: 5.9.3

Test Plan

By testing all four combinations for coloring frame and fill
a month item, I confirmed Bug 382185: the color for items with no
categories is used in CategoryOnly as well as in mixed settings (i.e.,
all settings but ResourceOnly). After applying this patch, I tested them
again and confirmed that the unset-category color is only used in
CategoryOnly, while in mixed settings, the resource color is used instead,
making it consistent to Agenda View and the settings dialog.

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkurz created this revision.Oct 9 2018, 8:18 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 9 2018, 8:18 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dkurz requested review of this revision.Oct 9 2018, 8:18 PM
dvratil accepted this revision.Oct 11 2018, 12:47 PM
dvratil added a subscriber: dvratil.

Looks good, thanks!

This revision is now accepted and ready to land.Oct 11 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.