Differential D7591

Fix use-after-free
ClosedPublic
Actions

Authored by dkurz on Aug 28 2017, 8:11 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R78:c1f5f6929122: Fix use-after-free
Summary

We now detect if IncidenceAttachment is deleted while the
AttachmentEditDialog is shown. There were three potential crashes
(deletion of item; access to mAttachmentView; call checkDirtyStatus);
the first of them actually was met in the wild in Bug 356053. Fixing
only the deletion of item led to the other two.

BUG: 356053
FIXED-IN: 5.6.1

Test Plan

Compiled; repeated the steps described in Bug 356053. The crash
happens without the patch; doesn't happen with the patch.

Diff Detail

Repository
R78 PIM: Incidence Editor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkurz created this revision.Aug 28 2017, 8:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 28 2017, 8:11 PM
dvratil accepted this revision.Sep 3 2017, 2:09 PM
This revision is now accepted and ready to land.Sep 3 2017, 2:09 PM
winterz added a subscriber: winterz.Oct 14 2017, 6:13 PM

was this committed yet?

dkurz added a comment.Feb 2 2018, 7:34 AM

Err... no, sorry for the delay. I finally found some time to spare on KDE again, but it's too late for 5.6.1 now, I'm afraid. We are some days clear of 17.12.2 tagging, so is it OK to push this to Applications/17.12? I rebased to that branch and re-tested today, of course.

winterz added a comment.Feb 2 2018, 11:07 PM

well, Dan already approved it. So sure.

Closed by commit R78:c1f5f6929122: Fix use-after-free (authored by dkurz). · Explain WhyFeb 4 2018, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/incidenceattachment.cpp (18 lines)

Diff 26528

View Options

src/incidenceattachment.cpp

Loading...