Details
Details
- Reviewers
mlaurent dvratil - Group Reviewers
KDE PIM - Commits
- R165:1f10dad8682b: Fix unused-object warnings
Diff Detail
Diff Detail
- Repository
- R165 Akonadi
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/agentbase/agentbase.cpp | ||
|---|---|---|
| 908 | argv is used in windows > put it in #else | |
| src/agentbase/agentbase.cpp | ||
|---|---|---|
| 908 | This is OK the way it is: this is a special code for Windows, so it's ifdefed correctly. | |
Comment Actions
arcanist complains that this Diff has not been accepted. In general, should I wait for positive feedback from the same reviewer after all requested changes from this reviewer have been fixed and accepted by another reviewer?
| src/agentbase/agentbase.cpp | ||
|---|---|---|
| 908 | It is now, after I moved Q_UNUSED(argv) to the else branch. Laurent was right about this. | |
Comment Actions
In thin particular case it's OK to merge now - you fixed what Laurent asked for and there's hardly anything else in this patch to complain about :-)
| src/agentbase/agentbase.cpp | ||
|---|---|---|
| 908 | Ah, sorry: I haven't noticed the comment was for a previous revision and though Laurent wanted you to swap the ifdef logic. | |