Create Task
Maniphest T13940

Port KPty away from QProcess::setupChildProcess
Open, Needs TriagePublic
Actions

Description

It was removed in favor of setChildProcessModifier()

https://codereview.qt-project.org/c/qt/qtbase/+/292539

ahmadsamir added a subscriber: ahmadsamir.Apr 10 2021, 2:13 PM

This looks like it should be in "Waiting of KF6 branching"? because indeed, in Qt6 setupChildPorcess() is gone, and in Qt5 setChildProcessModifier() doesn't exist.

And Qt docs doesn't mention this at all...

yenchihsuan added a comment.Aug 16 2021, 6:58 AM

I noticed kprocess uses #if QT_DEPRECATED_SINCE(5, 13) for compiling different code depending on the Qt version [1]. I think a similar technique can be applied to kpty?

[1] https://invent.kde.org/frameworks/kcoreaddons/-/blob/master/src/lib/io/kprocess.h#L324

dfaure moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.Nov 2 2021, 4:52 PM
dfaure added a subscriber: dfaure.

Like Ahmad said :)

yenchihsuan added a comment.Dec 28 2021, 6:25 PM

Seems already done, thanks Ahmad!

ahmadsamir moved this task from Waiting on KF6 Branching to Done on the KF6 board.Dec 28 2021, 7:46 PM