Port KFileItemActionPlugin usage to KPluginLoader
Open, Needs TriagePublic

Description

This needs changes in places that provide and consume FileItemActionPlugins:

Check for "KonqPopupMenu/Plugin" or "KFileItemAction/Plugin"

Offending providers:

  • Akregator plugin in Konqueror
  • KDE Connect
  • kactivitymanagerd in kio-extras
  • Choqok
  • Konsole

Offending consumer:

  • Dolphin
  • Folderview

Notifications also provides them but only through KFileItemActions::addActionsToMenu

dfaure added a subscriber: dfaure.Nov 24 2019, 10:42 PM

Doesn't Dolphin support both mechanisms already?

Dolphin uses KFileItemActions from KIO, so it indeed supports both ways

nicolasfella updated the task description. (Show Details)Nov 25 2019, 3:15 PM
alex added a subscriber: alex.Apr 19 2021, 6:04 AM

Dolphin uses the KFileItemAction/Plugin service type to get the list of available plugins/services in the settings page. Not sure if that is considered a blocker, I'd say it is waiting for KF6 branching ;)

But I generally think the logic to enable/disable plugins should be provided by KIO (where that config is already read).

alex updated the task description. (Show Details)Apr 19 2021, 6:42 AM
alex added a comment.Apr 19 2021, 6:51 AM

@nicolasfella In T12256 we agreed that removing the KonqPopupMenu/Plugin is currently a no-goal. Consequently the most of the offending providers are using the desktop files which is considered a valid usage. I would appreciate if you could share your thoughts on T12256#254055.

(I replied in T12256, the last comment here is no longer applicable, desktop files for plugins are being phased out)

alex updated the task description. (Show Details)May 3 2021, 10:17 AM
alex moved this task from Backlog to Done on the KF6 board.

Moving this to done then. The dolphin parts are only compatibility logic and the folderview usage has been ported.

alex claimed this task.May 7 2021, 10:06 AM