Differential D29371

KMainWindow: remove doc paragraph about KGlobal::ref usage
AbandonedPublic
Actions

Authored by dfaure on May 2 2020, 9:00 PM.

Details

Reviewers
davidedmundson
dvratil
Group Reviewers
Frameworks
Summary

There's no sign of KGlobal (obviously, it's been moved to kdelibs4support)
or any other similar code in KMainWindow, so remove the outdated paragraph
from the documentation.

Diff Detail

Repository
R263 KXmlGui
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26250
Build 26268: arc lint + arc unit
dvratil created this revision.May 2 2020, 9:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 2 2020, 9:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dvratil requested review of this revision.May 2 2020, 9:00 PM
davidedmundson accepted this revision.May 2 2020, 10:16 PM
This revision is now accepted and ready to land.May 2 2020, 10:16 PM
dfaure requested changes to this revision.May 2 2020, 11:11 PM

Please don't remove this, but port it to QEventLoopLocker.

This revision now requires changes to proceed.May 2 2020, 11:11 PM
dfaure added a comment.May 3 2020, 8:17 AM

src/kmainwindow_p.h:59: QEventLoopLocker locker; so the refcounting effect is the same as documented, just with a different "backend".

dfaure commandeered this revision.Apr 14 2021, 9:04 AM
dfaure edited reviewers, added: dvratil; removed: dfaure.
This revision is now accepted and ready to land.Apr 14 2021, 9:04 AM
dfaure abandoned this revision.Apr 14 2021, 9:04 AM

This has been done meanwhile.

Revision Contents
Changeset List

PathPackages
Msrc/kmainwindow.h (4 lines)

Diff 81763

View Options

src/kmainwindow.h

Loading...