In D29810#674815, @dfaure wrote:This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jun 7 2020
Jun 7 2020
Jun 6 2020
Jun 6 2020
In D29814#674730, @dfaure wrote:This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?"
In D29809#674721, @dfaure wrote:The changes you mention don't appear in phabricator.
I suggest amending your commit locally (so there's only one) and then
arc diff HEAD~
Remove contamination from another patch made by the last upload
Really commit the last changes
Jun 4 2020
Jun 4 2020
Polished the style as requested
Renamed the socketpath variable to s_socketpath, and make it static as requested
May 27 2020
May 27 2020
In D29814#674013, @dfaure wrote:I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??
Also, it sounds like a null check might be enough.
jpalecek added a reviewer for D29809: Don't invoke qstring localized stuff in critical section: dfaure.
Change remove_if and copy to copy_if, per suggestion
May 24 2020
May 24 2020
jpalecek added a dependent revision for D29810: Don't use the setenv function after fork: D29814: Fix segfault on no restart args.
Edited the commit msg, also prune the dependencies I want to abandon
Change the code a bit for readability
(edited the commit msg)
jpalecek added a comment to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..
In D29808#673157, @sandsmark wrote:It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.
I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up.
I assume this is for performance reasons, but a tiny microbenchmark showing that it is actually faster would be nice.
May 17 2020
May 17 2020
In D29811#672534, @davidedmundson wrote:Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths.
jpalecek added a reviewer for D29809: Don't invoke qstring localized stuff in critical section: Frameworks.
jpalecek added a dependent revision for D29813: t/minimize-allocations-in-crash-handler: D29814: Fix segfault on no restart args.
jpalecek added a dependent revision for D29812: t/handle-errors-from-socket: D29813: t/minimize-allocations-in-crash-handler.
jpalecek added a dependent revision for D29811: t/simplify-sending-data-through-socket: D29812: t/handle-errors-from-socket.
jpalecek added a dependent revision for D29810: Don't use the setenv function after fork: D29811: t/simplify-sending-data-through-socket.
jpalecek added a dependent revision for D29809: Don't invoke qstring localized stuff in critical section: D29810: Don't use the setenv function after fork.
May 15 2020
May 15 2020
May 11 2020
May 11 2020
jpalecek updated the diff for D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
Move the client deregistering code from SensorBrowserModel to HostInfo
jpalecek added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
jpalecek added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
jpalecek added a comment to D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully.
Could this be committed please?
@davidedmundson Can you please have a look at this?
Mar 18 2020
Mar 18 2020
In D27924#628197, @davidedmundson wrote:Not performing any action till the next call makes sense, kinda like the delay in the first call after a swapBuffers(), but even so surely the order of events remains the same and we realloc before usage? It doesn't seem to make sense to me.
Mar 8 2020
Mar 8 2020
Sep 3 2019
Sep 3 2019
Sep 2 2019
Sep 2 2019
jpalecek added reviewers for D23595: Speed up sending request to ksysguardd: Plasma, davidedmundson.
Aug 31 2019
Aug 31 2019
BTW it is even possible to load session from older kopete using the old code, see this patch in Debian. That would provide the users a seamless experience on upgrades.
Thoughts:
jpalecek set the repository for D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors() to R120 Plasma Workspace.
jpalecek requested review of D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors().
jpalecek set the repository for D23593: Don't accept duplicated sensor names from ksysguardd to R120 Plasma Workspace.
jpalecek added a reviewer for D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully: davidedmundson.
jpalecek requested review of D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully.
Aug 9 2019
Aug 9 2019
Mar 4 2019
Mar 4 2019
jpalecek updated the summary of D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
jpalecek added inline comments to D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
jpalecek updated the test plan for D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
jpalecek updated the test plan for D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Jan 22 2019
Jan 22 2019
jpalecek added a reviewer for D18444: Fix crashes and freezes when Bonjour contact comes on/offLine: Kopete.
Apr 13 2018
Apr 13 2018
In D8673#245716, @davidedmundson wrote:Thanks, do you have commit access?
I finally got round to this. So:
Nov 6 2017
Nov 6 2017
In D8673#164830, @davidedmundson wrote:Do the sockets need closing in the destructor?
Oct 25 2017
Oct 25 2017
jpalecek updated the diff for D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Recreated the diff usign arc (on branch Plasma/5.10)
Oct 22 2017
Oct 22 2017
jpalecek added a comment to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
In D8356#157952, @graesslin wrote:Could you please upload the patch in git-format against a git branch? I just wanted to pull it in,but it failed with:
error: kwin-5.10.5.orig/plugins/platforms/x11/standalone/x11_platform.cpp: does not exist in index Patch Failed! Usage Exception: Unable to apply patch!
jpalecek updated the summary of D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Oct 18 2017
Oct 18 2017
jpalecek updated the diff for D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
By reviewers' demand:
jpalecek added a comment to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
In D8356#156920, @graesslin wrote:Thanks for putting this on phab! Looks good to me, I like the idea with disabling KCrash.
jpalecek added inline comments to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.