Don't invoke qstring localized stuff in critical section
Needs ReviewPublic

Authored by jpalecek on Sun, May 17, 5:52 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Summary

Move the DrKonqi socket name generation out of the signal handler, since it can freeze while locking QTextCodec mutexes

Signed-off-by: Jiří Paleček <jpalecek@web.de>

Diff Detail

Repository
R285 KCrash
Branch
for-upstream
Lint
Lint OK
Unit
No Unit Test Coverage
jpalecek created this revision.Sun, May 17, 5:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, May 17, 5:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jpalecek requested review of this revision.Sun, May 17, 5:52 PM
jpalecek retitled this revision from t/dont-invoke-qstring-localized-stuff-in-critical-section to Don't invoke QString localized stuff in critical section.Sun, May 17, 7:37 PM
jpalecek edited the summary of this revision. (Show Details)
jpalecek updated this revision to Diff 83136.Sun, May 24, 1:24 AM
jpalecek retitled this revision from Don't invoke QString localized stuff in critical section to Don't invoke qstring localized stuff in critical section.
jpalecek edited the summary of this revision. (Show Details)

(edited the commit msg)

Makes sense; just two minor things.

src/kcrash.cpp
95

prepend static, it's only used in this file.

662

It would be more consistent with the other global vars to name it s_socketpath
(and outside the KCrash namespace)