jpalecek (Jiří Paleček)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 18 2017, 12:11 PM (153 w, 4 d)
Availability
Available

Recent Activity

Jun 7 2020

jpalecek added a comment to D29810: Don't use the setenv function after fork.
Jun 7 2020, 4:11 PM · Frameworks

Jun 6 2020

jpalecek added a comment to D29814: Fix segfault on no restart args.

This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?"

Jun 6 2020, 9:38 PM · Frameworks
jpalecek added a comment to D29809: Don't invoke qstring localized stuff in critical section.

The changes you mention don't appear in phabricator.

I suggest amending your commit locally (so there's only one) and then

arc diff HEAD~
Jun 6 2020, 2:23 PM · Frameworks
jpalecek updated the diff for D29814: Fix segfault on no restart args.

Remove contamination from another patch made by the last upload

Jun 6 2020, 1:43 PM · Frameworks
jpalecek updated the diff for D29809: Don't invoke qstring localized stuff in critical section.

Really commit the last changes

Jun 6 2020, 1:42 PM · Frameworks

Jun 4 2020

jpalecek updated the diff for D29814: Fix segfault on no restart args.

Polished the style as requested

Jun 4 2020, 8:03 PM · Frameworks
jpalecek updated the diff for D29809: Don't invoke qstring localized stuff in critical section.

Renamed the socketpath variable to s_socketpath, and make it static as requested

Jun 4 2020, 8:00 PM · Frameworks

May 27 2020

jpalecek added a comment to D29814: Fix segfault on no restart args.

I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??

Also, it sounds like a null check might be enough.

May 27 2020, 10:22 PM · Frameworks
jpalecek added a reviewer for D29809: Don't invoke qstring localized stuff in critical section: dfaure.
May 27 2020, 12:27 AM · Frameworks
jpalecek added a reviewer for D29810: Don't use the setenv function after fork: dfaure.
May 27 2020, 12:26 AM · Frameworks
jpalecek added a reviewer for D29814: Fix segfault on no restart args: dfaure.
May 27 2020, 12:26 AM · Frameworks
jpalecek added inline comments to D29810: Don't use the setenv function after fork.
May 27 2020, 12:25 AM · Frameworks
jpalecek updated the diff for D29810: Don't use the setenv function after fork.

Change remove_if and copy to copy_if, per suggestion

May 27 2020, 12:20 AM · Frameworks

May 24 2020

jpalecek added inline comments to D29810: Don't use the setenv function after fork.
May 24 2020, 1:31 AM · Frameworks
jpalecek abandoned D29811: t/simplify-sending-data-through-socket.
May 24 2020, 1:29 AM · Frameworks
jpalecek abandoned D29812: t/handle-errors-from-socket.
May 24 2020, 1:29 AM · Frameworks
jpalecek abandoned D29813: t/minimize-allocations-in-crash-handler.
May 24 2020, 1:29 AM · Frameworks
jpalecek added a dependent revision for D29810: Don't use the setenv function after fork: D29814: Fix segfault on no restart args.
May 24 2020, 1:27 AM · Frameworks
jpalecek updated the diff for D29814: Fix segfault on no restart args.

Edited the commit msg, also prune the dependencies I want to abandon

May 24 2020, 1:27 AM · Frameworks
jpalecek updated the diff for D29810: Don't use the setenv function after fork.

Change the code a bit for readability

May 24 2020, 1:26 AM · Frameworks
jpalecek updated the diff for D29809: Don't invoke qstring localized stuff in critical section.

(edited the commit msg)

May 24 2020, 1:24 AM · Frameworks
jpalecek added a comment to D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files..

It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.

I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up.

I assume this is for performance reasons, but a tiny microbenchmark showing that it is actually faster would be nice.

May 24 2020, 12:44 AM · Plasma

May 17 2020

jpalecek added inline comments to D29810: Don't use the setenv function after fork.
May 17 2020, 11:01 PM · Frameworks
jpalecek updated the summary of D29809: Don't invoke qstring localized stuff in critical section.
May 17 2020, 7:37 PM · Frameworks
jpalecek updated the summary of D29810: Don't use the setenv function after fork.
May 17 2020, 7:36 PM · Frameworks
jpalecek added a comment to D29811: t/simplify-sending-data-through-socket.

Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths.

May 17 2020, 7:31 PM · Frameworks
jpalecek added a reviewer for D29811: t/simplify-sending-data-through-socket: Frameworks.
May 17 2020, 6:21 PM · Frameworks
jpalecek added a reviewer for D29814: Fix segfault on no restart args: Frameworks.
May 17 2020, 6:03 PM · Frameworks
jpalecek added a reviewer for D29810: Don't use the setenv function after fork: Frameworks.
May 17 2020, 5:58 PM · Frameworks
jpalecek added a reviewer for D29809: Don't invoke qstring localized stuff in critical section: Frameworks.
May 17 2020, 5:54 PM · Frameworks
jpalecek added a dependent revision for D29813: t/minimize-allocations-in-crash-handler: D29814: Fix segfault on no restart args.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29814: Fix segfault on no restart args.
May 17 2020, 5:52 PM · Frameworks
jpalecek added a dependent revision for D29812: t/handle-errors-from-socket: D29813: t/minimize-allocations-in-crash-handler.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29813: t/minimize-allocations-in-crash-handler.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29812: t/handle-errors-from-socket.
May 17 2020, 5:52 PM · Frameworks
jpalecek added a dependent revision for D29811: t/simplify-sending-data-through-socket: D29812: t/handle-errors-from-socket.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29811: t/simplify-sending-data-through-socket.
May 17 2020, 5:52 PM · Frameworks
jpalecek added a dependent revision for D29810: Don't use the setenv function after fork: D29811: t/simplify-sending-data-through-socket.
May 17 2020, 5:52 PM · Frameworks
jpalecek added a dependent revision for D29809: Don't invoke qstring localized stuff in critical section: D29810: Don't use the setenv function after fork.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29810: Don't use the setenv function after fork.
May 17 2020, 5:52 PM · Frameworks
jpalecek requested review of D29809: Don't invoke qstring localized stuff in critical section.
May 17 2020, 5:52 PM · Frameworks

May 15 2020

jpalecek requested review of D29780: Detach sensor shell agent from terminal.
May 15 2020, 3:45 PM · Plasma

May 11 2020

jpalecek updated the diff for D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.

Move the client deregistering code from SensorBrowserModel to HostInfo

May 11 2020, 4:45 PM · Plasma
jpalecek added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
May 11 2020, 2:40 PM · Plasma
jpalecek added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
May 11 2020, 1:14 PM · Plasma
jpalecek requested review of D29618: Fix case fallback warning.
May 11 2020, 1:55 AM · Plasma
jpalecek requested review of D29617: Renice all threads of a multithreaded process.
May 11 2020, 1:53 AM · Plasma
jpalecek requested review of D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
May 11 2020, 1:46 AM · Plasma
jpalecek requested review of D29615: Nice all threads of multithreaded programs.
May 11 2020, 1:45 AM · Plasma
jpalecek added a comment to D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully.

Could this be committed please?

May 11 2020, 1:15 AM · Plasma
jpalecek added a comment to D23704: Allow tmpfs in ksysguard disk space monitor.

@davidedmundson Can you please have a look at this?

May 11 2020, 1:07 AM · Plasma
jpalecek added a reviewer for D23704: Allow tmpfs in ksysguard disk space monitor: davidedmundson.
May 11 2020, 1:06 AM · Plasma

Mar 18 2020

jpalecek added a comment to D27924: Tentative fix for bug 372305.

Not performing any action till the next call makes sense, kinda like the delay in the first call after a swapBuffers(), but even so surely the order of events remains the same and we realloc before usage? It doesn't seem to make sense to me.

Mar 18 2020, 3:04 PM · KWin

Mar 8 2020

jpalecek updated the summary of D27924: Tentative fix for bug 372305.
Mar 8 2020, 3:05 AM · KWin
jpalecek added reviewers for D27924: Tentative fix for bug 372305: davidedmundson, KWin.
Mar 8 2020, 2:45 AM · KWin
jpalecek requested review of D27924: Tentative fix for bug 372305.
Mar 8 2020, 1:33 AM · KWin

Sep 3 2019

jpalecek added a reviewer for D23704: Allow tmpfs in ksysguard disk space monitor: Plasma.
Sep 3 2019, 2:23 PM · Plasma
jpalecek requested review of D23704: Allow tmpfs in ksysguard disk space monitor.
Sep 3 2019, 2:23 PM · Plasma

Sep 2 2019

jpalecek added reviewers for D23595: Speed up sending request to ksysguardd: Plasma, davidedmundson.
Sep 2 2019, 10:20 PM · Plasma

Aug 31 2019

jpalecek updated subscribers of D23601: Fix the fallback code used when restoring session fails.

BTW it is even possible to load session from older kopete using the old code, see this patch in Debian. That would provide the users a seamless experience on upgrades.

Aug 31 2019, 10:37 AM · Konsole
jpalecek requested review of D23601: Fix the fallback code used when restoring session fails.
Aug 31 2019, 10:24 AM · Konsole
jpalecek added a comment to T11473: #407526: plasma + ksysguardd causing high cpu load.

Thoughts:

  • D23592 should fix the CPU load seen in bug 407526, but only if it is caused by duplicate mount points in mtab
  • D23593 is a quick fix on the plasma side
  • D23595 would make the whole plasma <-> ksysguardd communication faster
Aug 31 2019, 2:26 AM
jpalecek requested review of D23595: Speed up sending request to ksysguardd.
Aug 31 2019, 2:22 AM · Plasma
jpalecek set the repository for D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors() to R120 Plasma Workspace.
Aug 31 2019, 2:14 AM · Plasma
jpalecek requested review of D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors().
Aug 31 2019, 2:13 AM · Plasma
jpalecek set the repository for D23593: Don't accept duplicated sensor names from ksysguardd to R120 Plasma Workspace.
Aug 31 2019, 2:02 AM · Plasma
jpalecek requested review of D23593: Don't accept duplicated sensor names from ksysguardd.
Aug 31 2019, 2:01 AM · Plasma
jpalecek added a reviewer for D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully: davidedmundson.
Aug 31 2019, 1:45 AM · Plasma
jpalecek requested review of D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully.
Aug 31 2019, 1:40 AM · Plasma
jpalecek created T11473: #407526: plasma + ksysguardd causing high cpu load.
Aug 31 2019, 1:20 AM

Aug 9 2019

jpalecek requested review of D23045: Don't leave dangling pointers in AlarmCalendar when removeKAEvents doesn't remove the whole collection.
Aug 9 2019, 1:45 PM · KDE PIM

Mar 4 2019

jpalecek updated the summary of D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Mar 4 2019, 3:02 PM · Frameworks
jpalecek added inline comments to D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Mar 4 2019, 3:01 PM · Frameworks
jpalecek updated the test plan for D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Mar 4 2019, 2:55 PM · Frameworks
jpalecek updated the test plan for D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Mar 4 2019, 2:54 PM · Frameworks
jpalecek requested review of D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case.
Mar 4 2019, 2:52 PM · Frameworks

Jan 22 2019

jpalecek updated the summary of D18445: Fix missing parentheses around macro.
Jan 22 2019, 2:39 AM · Kopete
jpalecek added a reviewer for D18445: Fix missing parentheses around macro: Kopete.
Jan 22 2019, 2:38 AM · Kopete
jpalecek requested review of D18445: Fix missing parentheses around macro.
Jan 22 2019, 2:37 AM · Kopete
jpalecek added a reviewer for D18444: Fix crashes and freezes when Bonjour contact comes on/offLine: Kopete.
Jan 22 2019, 2:22 AM · Kopete
jpalecek requested review of D18444: Fix crashes and freezes when Bonjour contact comes on/offLine.
Jan 22 2019, 2:16 AM · Kopete

Apr 13 2018

jpalecek added a comment to D8673: Sanitize signal handling in ksmserver.

Thanks, do you have commit access?

Apr 13 2018, 5:17 PM · Plasma
jpalecek updated the diff for D8673: Sanitize signal handling in ksmserver.

I finally got round to this. So:

Apr 13 2018, 3:28 PM · Plasma

Nov 6 2017

jpalecek added a comment to D8673: Sanitize signal handling in ksmserver.

Do the sockets need closing in the destructor?

Nov 6 2017, 11:44 PM · Plasma
jpalecek updated the summary of D8673: Sanitize signal handling in ksmserver.
Nov 6 2017, 12:25 AM · Plasma
jpalecek updated the summary of D8673: Sanitize signal handling in ksmserver.
Nov 6 2017, 12:24 AM · Plasma
jpalecek created D8673: Sanitize signal handling in ksmserver.
Nov 6 2017, 12:22 AM · Plasma

Oct 25 2017

jpalecek updated the diff for D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.

Recreated the diff usign arc (on branch Plasma/5.10)

Oct 25 2017, 6:21 PM · KWin

Oct 22 2017

jpalecek added a comment to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.

Could you please upload the patch in git-format against a git branch? I just wanted to pull it in,but it failed with:

error: kwin-5.10.5.orig/plugins/platforms/x11/standalone/x11_platform.cpp: does not exist in index

 Patch Failed! 
Usage Exception: Unable to apply patch!
Oct 22 2017, 3:46 PM · KWin
jpalecek updated the summary of D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Oct 22 2017, 3:40 PM · KWin

Oct 18 2017

jpalecek updated the diff for D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.

By reviewers' demand:

Oct 18 2017, 11:47 PM · KWin
jpalecek added a comment to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.

Thanks for putting this on phab! Looks good to me, I like the idea with disabling KCrash.

Oct 18 2017, 5:43 PM · KWin
jpalecek added inline comments to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Oct 18 2017, 3:19 PM · KWin
jpalecek created D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Oct 18 2017, 1:02 PM · KWin