In D29810#674815, @dfaure wrote:

This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/

In D29814#674730, @dfaure wrote:

This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?"

In D29809#674721, @dfaure wrote:

The changes you mention don't appear in phabricator.

I suggest amending your commit locally (so there's only one) and then

arc diff HEAD~

Remove contamination from another patch made by the last upload

Really commit the last changes

Polished the style as requested

Renamed the socketpath variable to s_socketpath, and make it static as requested

In D29814#674013, @dfaure wrote:

I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??

Also, it sounds like a null check might be enough.

Change remove_if and copy to copy_if, per suggestion

Edited the commit msg, also prune the dependencies I want to abandon

Change the code a bit for readability

(edited the commit msg)

In D29808#673157, @sandsmark wrote:

It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now.

I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up.

I assume this is for performance reasons, but a tiny microbenchmark showing that it is actually faster would be nice.

In D29811#672534, @davidedmundson wrote:

Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths.

Move the client deregistering code from SensorBrowserModel to HostInfo

Could this be committed please?

@davidedmundson Can you please have a look at this?

In D27924#628197, @davidedmundson wrote:

Not performing any action till the next call makes sense, kinda like the delay in the first call after a swapBuffers(), but even so surely the order of events remains the same and we realloc before usage? It doesn't seem to make sense to me.

BTW it is even possible to load session from older kopete using the old code, see this patch in Debian. That would provide the users a seamless experience on upgrades.

Thoughts:

• D23592 should fix the CPU load seen in bug 407526, but only if it is caused by duplicate mount points in mtab
• D23593 is a quick fix on the plasma side
• D23595 would make the whole plasma <-> ksysguardd communication faster

In D8673#245716, @davidedmundson wrote:

Thanks, do you have commit access?

I finally got round to this. So:

In D8673#164830, @davidedmundson wrote:

Do the sockets need closing in the destructor?

Recreated the diff usign arc (on branch Plasma/5.10)

In D8356#157952, @graesslin wrote:

Could you please upload the patch in git-format against a git branch? I just wanted to pull it in,but it failed with:

error: kwin-5.10.5.orig/plugins/platforms/x11/standalone/x11_platform.cpp: does not exist in index

 Patch Failed! 
Usage Exception: Unable to apply patch!

By reviewers' demand:

In D8356#156920, @graesslin wrote:

Thanks for putting this on phab! Looks good to me, I like the idea with disabling KCrash.