Differential D23045

Don't leave dangling pointers in AlarmCalendar when removeKAEvents doesn't remove the whole collection
ClosedPublic
Actions

Authored by jpalecek on Aug 9 2019, 1:45 PM.

Details

Reviewers
djarvie
Commits
R205:1cefdb07c558: Bug 410596: Don't leave dangling pointers in AlarmCalendar when removeKAEvents…
Summary

AlarmCalendar::removeKAEvents can sometimes delete some, but not all
events from a KAEvent::List stored in mResourceMap. In that case, the
list is left as is, with some pointers invalid. That would later
cause crashes.

This patch only retains valid pointer in the collection.

BUG: 410596

Diff Detail

Repository
R205 KAlarm
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jpalecek created this revision.Aug 9 2019, 1:45 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 9 2019, 1:45 PM
jpalecek requested review of this revision.Aug 9 2019, 1:45 PM
djarvie accepted this revision.Aug 9 2019, 2:32 PM
This revision is now accepted and ready to land.Aug 9 2019, 2:32 PM
Closed by commit R205:1cefdb07c558: Bug 410596: Don't leave dangling pointers in AlarmCalendar when removeKAEvents… (authored by jpalecek, committed by djarvie). · Explain WhyAug 14 2019, 10:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/alarmcalendar.cpp (8 lines)

Diff 63770

View Options

src/alarmcalendar.cpp

Loading...