Use sensor index for request ID in SystemMonitorEngine::updateSensors()
Needs ReviewPublic

Authored by jpalecek on Sat, Aug 31, 2:13 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

When id is -1, the answerReceived function expects the response to be the list of sensors. However, this function sends commands to update values of individual sensors. These should have a positive id in the answerReceived function.

However, I may be wrong there. I couldn't find a place that actually calls that function, so I couldn't verify the functionality. But IMHO it should be akin to updateSourceEvent, which this patch does.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15880
Build 15898: arc lint + arc unit
jpalecek requested review of this revision.Sat, Aug 31, 2:13 AM
jpalecek created this revision.
jpalecek set the repository for this revision to R120 Plasma Workspace.Sat, Aug 31, 2:14 AM

You're right.

-N response to "someSensorName?" (which returns metadata of a sensor)
-1 response to "monitors" (which lists things)
+N response to a given call

. I couldn't find a place that actually calls that function, so I couldn't verify the functionality

it's not called, which also means it's a non-issue.

FYI, I've been working on a branch to provide a nicer declarative port of sensor information