I think thanks to @feverfew 's work on getting that last patch merged, that the final items on here are complete now?

Cool! IMHO, I think the arrows should stay. With this feature being new to Dolphin, not everyone reads the release notes, and won't be aware that the navigation history is there in the next version. The arrows would give a hint. At least that's how I see it

Dolphin appears to not compile without F6773036 in KWidgetAddons though. All I can find for F6773036 is the diff. Is there a Dxxxxx thing in phab for that?

Looks good. I do have a weird occurrence with three slashes appearing in the path for

I patched Dolphin and KWidgetAddons.
I get

I'd like to test this... ...will Oxygen need similar changes?

I gave the alias of
Nerdopolis Turfwalker
for the previous commit I made that broke it, so can we go with that for consistency I guess?
email address is
bluescreenavenger@gmail.com

bluescreenavenger@gmail.com
I was able to get a previous commit in without my full name. I just don't want it to appear in Google...

I don't think I have commit access...

Awesome! For what I can input, base file operations work. I can copy, delete, rename files, and testing, and diffing the trees with my kiocopy test script, it copies them perfectly. However, for example, some of the files I cannot open with kate

I tried with my script that tried to reproduce that "kio skips files" issue
https://raw.githubusercontent.com/n3rdopolis/otherstuff/master/kiocopy
(changing the TEST_INVALID_UNICODE_CHARS=0 line to TEST_INVALID_UNICODE_CHARS=1 )
and then letting it run.
Unfortunately, I get "The file protocol died unexpectedly

Thanks for merging!

I was able to get previous patches merged with this alias https://cgit.kde.org/kwin.git/commit/?id=e737a6193c805d8e480fdd22abe815acddafd483 ?

In D9572#307162, @zzag wrote:

Please replace 'framebuffer:' with '[platforms/fbdev]', so the title looks like

[platforms/fbdev] Attempt to set the framebuffer color layout on the framebuffer device

I don't think I have commit access to push that though? Is there something I need to do?

Any chance that this can be reviewed? I tried to address the requested changes

rebase

In D9572#281886, @rkflx wrote:

In D9572#267372, @rkflx wrote:

@davidedmundson As you "requested changes", are those implemented now?

@nerdopolist You could try pinging David (d_ed) on IRC or asking in the #kwin channel.

Let me know if the change I made was good enough?

I'd like to know if I need to change anything?

Can you use "Nerdopolis Turfwalker <bluescreenavenger@gmail.com>"
Or do I need to resubmit? My build scripts set that other one as a place holder, and I forgot that that was still in the config...

rebase

Update for requested changes

Rebase

Also change the order of "Sort" and "View By" in the "View" menu

In D12911#265759, @rkflx wrote:

In D12911#264435, @nerdopolist wrote:

Move below paste

Seems like you lost that change.

Rebase, Switch order of "View Mode" and "Sort By" in the Dolphin control menu

Switch order of "View Mode" and "Sort By" in the Dolphin control menu

Let me know if I need to change this one?

In D12911#264547, @rkflx wrote:

In D12911#264368, @rkflx wrote:

Also, you should update your test plan to the current state of your patch ;)

@nerdopolist Please don't forget to update your test plan.

Rebase with arc

Move below paste

In D12911#264374, @ngraham wrote:

I don't have a very strong opinion on the matter, but it does look a bit odd having them right above the Paste item (when it's active). I almost wonder if these would make sense to have at the very bottom of the menu, after Properties.

Only show the 'Sort By' and 'View Mode' options when right clicking on whitespace, and not on files and folders

Let me know if I need to make any more changes?

rebase the requested changes

Try to adjust for requested changes

Thanks for merging my other patches! What does it mean when one is accepted, but not merged though? Do I need to rebase this one?

I might need to research the best way to do this (although I really had bad luck finding info)... This more that secondary framebuffer devices, seem to initialize with the screens off (such as udlfb/displaylink devices) sending the ioctl, seems to be the only way to turn the screen on. (and IIRC, it's due to some attribute changing, (at this moment, I forget the exact one)

was this rebase correct?

ended up doing
arc patch D9557 --skip-dependencies

rebase

It still tries to include the changes of D9556 . even after git branch --set-upstream-to=arcpatch-D9556

rebase

rebase

It's trying to pull and include other diffs into the submission
https://phabricator.kde.org/differential/diff/31453/
after
arc diff --preview

rebase

rebase

rebase.

I am trying. It keeps pulling D9551 for some reason, and then making it part of the diff... I am going to turn off the dependency on it

undo another git messup

I don't think I have commit access

rebase

Is there something I need to run before

git checkout arcpatch-D9567

arcpatch-D9567 is unknown to git

undo my git messup

Rebase

Log the failing seat name.

I am not sure what to do from here?

rebase

rebase

Let me know if I did this correctly. I might need help with the other ones.
Trying to do arc patch D9556
and arc diff prompts for 3 others...

Make compatible with arc

Bring back the old diff

OH NO!

Try to make compatible with arc

In D9567#228429, @rkflx wrote:

@nerdopolist As you've been around for a while, please make the effort to set up Arcanist. Then do arc patch D9567 and re-upload with arc diff. Otherwise Martin does not have your contact information for landing the patch.

---

I am able to download raw diff... ...did I upload something wrong?

Is this patch acceptable?

Is there anything that needs to be changed with this one?

Is there anything that needs to be changed with this one?

Is there something that needs to be changed with this one?

Initialize defaultSeat properly with QStringLiteral

as another note, I am going to have to dig deeper into the fact that seat0 is the only one with TTYs. (not doing VirtualTerminal::self()->init(); on non-seat0) , there is no way for it to determine that it is active, and that is one of the reasons why the framebuffer does not draw on seat1)

Update for changes

Update for needed changes

Adjust for requested changes