Details
- Reviewers
graesslin - Group Reviewers
KWin - Commits
- R108:8321453fdeee: fb_backend: use new udev function to detect framebuffer devices, if one is not…
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| plugins/platforms/fbdev/fb_backend.cpp | ||
|---|---|---|
| 89 | strdup allocates memory and you should call free to prevent memory leaks. To use QString is easier. | |
Please use QString or QByteArray
| plugins/platforms/fbdev/fb_backend.cpp | ||
|---|---|---|
| 91–92 | Coding style nitpick: please use {} | |
as another note, I am going to have to dig deeper into the fact that seat0 is the only one with TTYs. (not doing VirtualTerminal::self()->init(); on non-seat0) , there is no way for it to determine that it is active, and that is one of the reasons why the framebuffer does not draw on seat1)
| plugins/platforms/fbdev/fb_backend.cpp | ||
|---|---|---|
| 89 | You use udev only here, so you can write it like that framebufferDevice = Udev().primaryFramebuffer()->devNode() i.e. make Udev local to this scope. I see potentially primaryFramebuffer can return nullptr which will cause a crash without exclusive check. | |
@nerdopolist Please rebase on D9554 (!) after you updated D9554 itself (and update authorship information on Phab as usual ;):
git checkout 50b948134c81 arc patch D9556 git rebase arcpatch-D9554 # might be arcpatch-D9554_1 or similar for you # Check if it still compiles arc diff
I am not sure what to do from here?
nerdopolis@nerdopolis:~/kwin2upstream$ arc diff
Usage Exception: There are several revisions which match the working copy:
- D9554: udev: Add the ability to query the current framebuffer.
- D9556: fb_backend: use new udev function to detect framebuffer devices, if one is not set
Use '--update' to choose one, or '--create' to create a new revision.