Differential D9552

libinput/connection: Don't hardcode seat0 anymore
ClosedPublic
Actions

Authored by nerdopolist on Dec 29 2017, 5:20 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:ddda524974d9: libinput/connection: Don't hardcode seat0 anymore
Summary

use a new function to get the logind, instead of assuming seat0

Test Plan

kwin still starts

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nerdopolist created this revision.Dec 29 2017, 5:20 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptDec 29 2017, 5:20 PM
nerdopolist added a comment.Feb 12 2018, 11:23 AM

Is there anything that needs to be changed with this one?

rkflx added subscribers: graesslin, rkflx.EditedMar 21 2018, 11:48 AM

@nerdopolist Please rebase on latest master and update authorship information on Phab:

git fetch
git checkout 50b948134c81
arc patch D9552
git rebase origin/master
# Check if it still compiles
arc diff

@graesslin Friendly ping to review the code afterwards ;)

davidedmundson accepted this revision.Mar 24 2018, 11:58 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
libinput/connection.cpp
141

why remove the seat name from here?

This revision is now accepted and ready to land.Mar 24 2018, 11:58 PM
nerdopolist updated this revision to Diff 30680.Mar 27 2018, 2:27 AM

Log the failing seat name.

nerdopolist updated this revision to Diff 30682.Mar 27 2018, 2:30 AM

undo my git messup

davidedmundson added a comment.Mar 27 2018, 11:59 PM

Do you have commit access?

nerdopolist added a comment.Mar 28 2018, 12:02 AM

I don't think I have commit access

libinput/connection.cpp
141

I guess I could do
qCWarning(KWIN_LIBINPUT) << "Failed to assign seat" << LogindIntegration::self()->seat();

nerdopolist updated this revision to Diff 30777.Mar 28 2018, 2:55 AM

undo another git messup

graesslin added a comment.Apr 5 2018, 5:50 PM

arc failed to apply this one. Could you please rebase again?

nerdopolist added a comment.Apr 6 2018, 12:49 AM

I am trying. It keeps pulling D9551 for some reason, and then making it part of the diff... I am going to turn off the dependency on it

nerdopolist added a comment.Apr 18 2018, 2:36 AM

was this rebase correct?

rkflx added a comment.Apr 18 2018, 1:06 PM
In D9552#248549, @nerdopolist wrote:

was this rebase correct?

Looks like it.

Closed by commit R108:ddda524974d9: libinput/connection: Don't hardcode seat0 anymore (authored by nerdopolist, committed by graesslin). · Explain WhyApr 22 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibinput/connection.cpp (5 lines)

Diff 32815

View Options

libinput/connection.cpp

Loading...