Do you have commit access or should I push this for you?

I don't think so and Frameworks also need 3.5 since quite some time.

Used the ReadWrite flag to simplify

All those regressions from f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68 :(

This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console

I don't know much about python, but it works fine with python3 where it previously didn't. +1

In D23883#529898, @davidedmundson wrote:

Happy to help, but I don't understand yet.

kde-cli-tools doesn't use sessionmanagementbackend.h?

The only user is inside plasma-workspace source.

Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot easily split plasma-workspace into multiple packages (actually we could, kind of, but the user would still need to build p-w and all of its dependencies). Thus we have some patches to build libkworkspace separately. Given that I could add this one too, if it's inappropriate that it'll get merged.

Thanks!

Looks like a missing "git add audex.qrc" ;-)

I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked fine.