Reduce size of test file
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 23 2019
Mar 17 2019
Add a test
Mar 16 2019
Use MIT license
Mar 15 2019
Also check for present formats
Mar 9 2019
In D19644#428074, @bruns wrote:Do not create a new transaction per file, thats costly.
Don't create transaction for every file
In D19644#428047, @bruns wrote:A transaction can not be split up, thats the reason it is a transaction ...
Mar 7 2019
ehhh, damn arc land, I didn't knew it will squash commits, oh well...
Mar 5 2019
In D19457#422812, @davispuh wrote:Only I had to disable tests, because they depend on kdevplatform/tests/*.h which doesn't get installed with KDevelop
These headers should normally be installed.
Some distro packages of KDevelop omit them, because of explicitly setting -DBUILD_TESTING=OFF during the build process.
You should be able to copy them manually, or add the source dir as an extra include path.
In D19457#424138, @apol wrote:Are you planning to maintain it?
Make tests buildable
Don't duplicate code
Whoops...
Allow invalid Format()
Improvements
In D19532#425381, @cullmann wrote:Calling the ::get is no issue.
In D19532#425378, @cullmann wrote:test.diff3 KBDownloadThis would be my proposed patch + unit test.
In D19532#424926, @cullmann wrote:Hi, first: good thing to get this fixed, yes, it shall not crash.
For the fix: Wouldn't it be enough to just change the
if (!d->m_definition.isValid()) {
applyFormat(0, text.size(), Format()); ...
shortcut to check for
if (!d->m_definition.isValid() || defData->isLoaded()) {
Mar 4 2019
Actually fix it
Creating a syntax highlighting file with few unclosed tags made Kate to crash. No matter how malformed XML it loads, editor should never crash as it can cause loss of unsaved work.
Mar 2 2019
Only I had to disable tests, because they depend on kdevplatform/tests/*.h which doesn't get installed with KDevelop